Tk Source Code

Makefile.vc creates the HTML help files with a .html extension but the "inline file" code in makefile.vc lists them with a .htm extension and so the Microsoft Help Workshop cannot find them.

In addition, the file contents.htm is also listed but perhaps should be listed as index.html instead.

I can't help with the missing Inventory and Keywords tabs.  I know next to nothing about the Workbench product and my copy of the Workbench IDE does not list all the possible options, contrary to what we'd expect from an IDE.  I defer to Ashok on this feature.

> the Tabs (on the left side) for Inventory and Keywords are missing.

Any idea how to add those?

Thank you for looking into this. For me, a Tk target "htmlhelp" is not required, as TCL builds the unified TCL/Tk help file. The now generated help file has the start page correctly. Nevertheless, the Tabs (on the left side) for Inventory and Keywords are missing. Ashok had them in his help file and I find them quite handy.

Anyway, great work !

Harald

> There is one other difference between the Tcl and Tk makefile behaviors when they invoke hhc.exe. The return code from hhc is zero for the Tcl version but the Tk version returns the status one. In the latter case, nmake interprets it as an error and will terminate by default. Even so, the .chm file appears to be okay.

[70f8918985dadb71|this] should help

Closing

Your patch works but will be complete if you add the HHP option "Full-text search=Yes" to the Tk makefile.  This option is already present in the Tcl makefile.

This option creates the toolbar above the documentation pane and also creates a topic-search pane to the left of the documentation pane.  

The toolbar contains the choices "Show/Hide", "Back", "Print" and "Options".  The "Show/Hide" button is used to show or hide the search-topic pane.  This is important because I have found that the first time that Tk .chm is launched, the search-topic pane is not visible and the "Show/Hide" button is labeled "Show".  For unknown reasons, the Tcl makefile, with corrections, does show the search-topic pane by default.  This is a minor nit because once the search-topic pane is displayed, that choice is recorded somewhere, perhaps in the Registry.

There is one other difference between the Tcl and Tk makefile behaviors when they invoke hhc.exe.  The return code from hhc is zero for the Tcl version but the Tk version returns the status one.  In the latter case, nmake interprets it as an error and will terminate by default.  Even so, the .chm file appears to be okay.

@msoyka, does [11b60316ae833198|this] work for you? (If it works for Tk, I will have a look at Tcl too)

@ashok, would you be so kind to have a look please?

There is an "Attach" button on top of the ticket page, you can use it to provide a patch. Thanks!

I neglected to mention that the file makefile.vc is in the Tcl distribution.  The htmlhelp target in the Tk distribution's makefile.vc is also broken in somewhat the same way but has some additional problems.

I have a fix for the Tk makefile but don't know how to provide it to you since the ticket system doesn't seem to support patches.