| Ticket UUID: | 8bd39bede9e017bf515264c6f6cbd2205a40ca8c | |||
| Title: | Word wrap regressions since [e3ef73ae0b] (mojibake line breaks) | |||
| Type: | Bug | Version: | trunk | |
| Submitter: | nab | Created on: | 2026-10-01 20:30:10 | |
| Subsystem: | 18. [text] | Assigned To: | nobody | |
| Priority: | 5 Medium | Severity: | Important | |
| Status: | Closed | Last Modified: | 2026-10-03 13:25:51 | |
| Resolution: | Fixed | Closed By: | nab | |
| Closed on: | 2026-10-03 13:25:51 | |||
| Description: |
Since the merge of tk_text_grapheme in e3ef73ae0b,
Cases 1 and 2 come from the backward search in The tests textDisp-2.10, 2.23 and 26.14.2 caught this; their expected results were rewritten in e3ef73ae0b (textDisp-2.23 now expects a negative spacing, Script (case 1):
Case 2: the body of textDisp-26.14.2 as in 9.1.0 gives Proposed fix: branch
The breaks wanted by e3ef73ae0b are kept: Thai, Lao and Khmer still wrap at their words, and the other UAX #14 breaks still apply. textDisp-2.10, 2.23, 19.11.23, 26.14.2 and 27.1 are restored as in 9.1.0. The full textDisp.test of 9.1.0 passes with this check-in (400 tests, 0 failure; 3 failures on trunk before it), and the text test family of trunk passes (1786, 0). With the breaks after tabs restored, textDisp-26.14.2 wraps between two tabs again, the case of 7353d930de: its fix in branch text-tab-chunk-free b5684e005a is independent and still needed. Both together pass the textDisp.test of 9.1.0 and the text test family of trunk. Checked on macOS (aqua) only. textDisp-19.11.23 and 27.1 already passed on macOS with their 9.1.0 results: if they were changed because of Windows or X11, please check them there. | |||
| User Comments: |
nab added on 2026-10-03 13:25:51:
Merged into trunk in [9bc623c8ed]. No backport is needed: the regression only exists in trunk. serhiy.storchaka added on 2026-10-03 12:48:20: Merged [text-tab-chunk-free]. Please merge nab-wrap-locale. jan.nijtmans added on 2026-10-03 09:45:51: Great! +1 nab added on 2026-10-03 09:30:43: Yes, I think nab-wrap-locale is ready to be merged. Please merge [text-tab-chunk-free] with it: the branch restores the break between two tabs, which triggers [7353d930de]. Tested together with current trunk on macOS: the text tests and the textDisp.test of 9.1.0 pass. kevin_walzer added on 2026-10-02 19:21:03: Nicolas, are you at a point where you believe your branches that address this ticket can be merged? serhiy.storchaka added on 2026-10-02 06:56:19: Tested on X11 (with and without bidi, and without Xft) and on Windows 11: the example gives the same result as 9.1.0, and the textDisp.test of both the branch and 9.1.0 passes. The other text tests pass too, except textImage-4.3 without Xft and textImage-4.2 on Windows, which also fail on trunk. Builds without bidi warn about the unused variable bTotal. [text-tab-chunk-free] is still needed: LayoutDLine still frees the chunk of the last tab during textDisp.test. kevin_walzer added on 2026-10-01 20:42:09: This branch addresses the wrap issue documented in the sample script, and script breaks look unchanged on macOS and X11. I do not have access to my Windows system at this time. | |||
Home
Timeline
Branches
Tags
Forum
Tickets
Download
Wiki