| Ticket UUID: | ae32eb7e1003024fb91b7d2bd281eafad4c0af99 | |||
| Title: | Win + specific text widget configuration : textDisp-18.6, -20.2 -20.3 -20.4 fail | |||
| Type: | Bug | Version: | core-8-6-branch | |
| Submitter: | fvogel | Created on: | 2017-01-07 14:49:52 | |
| Subsystem: | 18. [text] | Assigned To: | fvogel | |
| Priority: | 6 | Severity: | Minor | |
| Status: | Closed | Last Modified: | 2017-02-05 17:20:06 | |
| Resolution: | Fixed | Closed By: | fvogel | |
| Closed on: | 2017-02-05 17:20:06 | |||
| Description: |
On Windows, when both following flags are defined (add this in tkWinInt.h for testing purposes): #define TK_LAYOUT_WITH_BASE_CHUNKS 1 #define TK_DRAW_IN_CONTEXT 1 The following tests fail: textDisp-18.6 textDisp-20.2 textDisp-20.3 textDisp-20.4
==== textDisp-18.6 GetXView procedure FAILED
==== Contents of test case:
.t configure -wrap none
.t delete 1.0 end
.t insert end xxxxxxxxx\n
.t insert end "xxxxx xxxxxxxxxxx xxxx xxxxxxxxxxxxxxxxxxxx xxxxxxxxxxxx\n"
.t insert end "xxxx xxxxxxxxx xxxxxxxxxxxxx"
.t xview moveto 0
.t xview scroll 31 units
update
set x {}
lappend x $scrollInfo
.t configure -wrap char
update
lappend x $scrollInfo
.t configure -wrap word
update
lappend x $scrollInfo
.t configure -wrap none
update
lappend x $scrollInfo
---- Result was:
{0.5535714285714286 0.9107142857142857} {0.0 1.0} {0.0 0.9523809523809523} {0.0 0.35714285714285715}
---- Result should have been (exact matching):
{0.5535714285714286 0.9107142857142857} {0.0 1.0} {0.0 1.0} {0.0 0.35714285714285715}
==== textDisp-18.6 FAILED
==== textDisp-20.2 FindDLine FAILED
==== Contents of test case:
.t yview 100.0
.t yview -pickplace 53.0
list [.t dlineinfo 50.0] [.t dlineinfo 50.14] [.t dlineinfo 50.21]
---- Result was:
{3 -2 147 15 12} {3 -2 147 15 12} {3 13 133 15 12}
---- Result should have been (exact matching):
{3 -2 140 15 12} {3 -2 140 15 12} {3 13 133 15 12}
==== textDisp-20.2 FAILED
==== textDisp-20.3 FindDLine FAILED
==== Contents of test case:
.t yview 100.0
.t yview 49.0
list [.t dlineinfo 50.0] [.t dlineinfo 50.24] [.t dlineinfo 57.0]
---- Result was:
{3 18 147 15 12} {3 33 133 15 12} {}
---- Result should have been (exact matching):
{3 18 140 15 12} {3 33 133 15 12} {}
==== textDisp-20.3 FAILED
==== textDisp-20.4 FindDLine FAILED
==== Contents of test case:
.t yview 100.0
.t yview 42.0
list [.t dlineinfo 50.0] [.t dlineinfo 50.24] [.t dlineinfo 50.40]
---- Result was:
{3 123 147 15 12} {3 138 133 15 12} {}
---- Result should have been (exact matching):
{3 123 140 15 12} {3 138 133 15 12} {}
==== textDisp-20.4 FAILED
| |||
| User Comments: |
fvogel added on 2017-02-05 17:20:06:
I have received separate confirmations by private email from Kevin Walzer and Brad Lanam that the changes made in the context of the present ticket do not trigger any "tremble and shiver" effect and that they did not see any other adverse impact on their OS X machines. No new issue was found by both of them. Actually, redrawing artifacts (aka "ghosts") could be found however (on OS X only) but testing showed that they were present before the changes related to this ticket, and are even present in the vanilla 8.6.6 release. These issues will be the subject of another ticket. Based on the above, I have merged the changes from this ticket into core-8-6-branch and trunk. fvogel added on 2017-01-29 16:51:44: On OS X, textDisp-18.6 is in fact failing identically as in the report. Moreover, checking the content of textDisp-20.1, -20.2, -20.3, -20.4 and -20.5, it appears that the constraint is not needed and can be removed: this is [278779a88e]. The reported tests now fail identically on OS X and on the modified Win build that is the object of the report. Then, [8847b487] really seems to fix the problem. Could someone having a Mac check that the rendering is OK with the code currently in branch bug-ae32eb7e10 ? By "correct" I mean no issue can be seen in a text widget displaying some text, moving the cursor in this text, selecting and so on performing any action in the widget... What I'm wondering more specifically is whether the following effect (from a comment in tkTextDisp.c) can be seen in the above branch or not. * This is necessary for text rendering engines that provide ligatures * and sub-pixel layout, like ATSU on Mac. If we don't do this, the * measuring will change all the time, leading to an ugly "tremble and * shiver" effect. This is because of the continuous splitting and * re-merging of chunks that goes on in a text widget, when the cursor or * the selection move. Also, in that same branch, make -C ./macosx test TESTFLAGS="-file textDisp.test"should run 100% error free. Confirmation welcome here as well, thanks. fvogel added on 2017-01-07 14:58:31: [8847b487] fixes this issue for me on Windows. On OS X one needs to check that this fix is correct. Unfortunately the tests reported as failing are skipped because of an unsatisfied "textfonts" constraint, so these cannot be a way to check. It is possible that the code was correct and the tests should be adjusted or skipped for Mac OS X. Indeed the change that had to be made in the code by the fix is a bit odd to me. Could anyone having a Mac featuring ATSU rendering check that the rendering of text by the text widget is still correct in branch bug-ae32eb7e10 please? | |||
Home
Timeline
Branches
Tags
Forum
Tickets
Download
Wiki