| Ticket UUID: | 88dcdc8f96bf2dc1625af52b57d85854995999ad | |||
| Title: | Wayland branch: zooming a window does not work under GNOME since wm geometry applies pending changes (wm-state-2.20 and wm-maxsize-2.7 fail) | |||
| Type: | Bug | Version: | wayland | |
| Submitter: | serhiy.storchaka | Created on: | 2026-11-13 08:55:02 | |
| Subsystem: | 65. Generic Window Operations | Assigned To: | kevin_walzer | |
| Priority: | 5 Medium | Severity: | Important | |
| Status: | Closed | Last Modified: | 2026-11-13 20:59:16 | |
| Resolution: | Fixed | Closed By: | kevin_walzer | |
| Closed on: | 2026-11-13 18:34:21 | |||
| Description: |
Since [46929db12a], wm-state-2.20 and wm-maxsize-2.7 fail under GNOME, both headless and on a real screen (Fedora VM), in every run. After zoomWindow .t 1 the window reports the zoomed state but has its normal size. The cause is the change in wm geometry without arguments, which now calls UpdateGeometryInfo() before reporting. waitForWm queries wm geometry while GNOME is maximizing the window, and each query applies the normal size again before the window is reported as maximized. With only that block reverted, wm.test has no failures under GNOME (headless and real screen), and the other changes of that commit show no problems; unixWm-40.2 and wm-geometry-2.1 pass. On X11 a query of wm geometry does not apply pending changes. | |||
| User Comments: |
serhiy.storchaka added on 2026-11-13 20:59:16:
About a baseline: you may find some tips useful at https://serhiy-storchaka.github.io/tcltk-dev/docs/testing.html#wayland-branch. It describes how I test the wayland branch under headless sway, KWin and GNOME Shell on one machine, also with different display scales and several outputs. serhiy.storchaka added on 2026-11-13 18:02:40: My fix [6fa82540c9] has a regression: since wm geometry no longer applies the pending changes, it can return an outdated size after the requested size was changed, e.g. 250x60 instead of 270x140 in unixWm-6.3. This is rare in the test suite, but repeating the steps of unixWm-6.1 to 6.3 with a new window gives the outdated size in up to 11% of the cases under headless GNOME Shell at the scale 200%. Proposed fix in branch wayland-geometry-query-zoomed: wm geometry applies the pending changes again, as before, and instead the size of a window is not set while it is requested to be maximized or fullscreen, which the compositor may not have done yet. kevin_walzer added on 2026-11-13 15:35:37: I see no regressions in the test suite, so merging this branch. Thank you. serhiy.storchaka added on 2026-11-13 13:43:22: Proposed fix in branch wayland-geometry-query-pending: wm geometry applies the pending geometry changes only if there are any. With it, wm.test and unixWm.test have no failures in headless GNOME Shell 50.1 and KWin, and in GNOME Shell 51.1 on a real screen, including the minsize/maxsize tests. This is not specific to GNOME Shell 51, and it is not related to [90d85ad8ce]: without the fix, wm-state-2.20 and wm-maxsize-2.7 also fail in headless GNOME Shell 50.1 and KWin at the scale 100%. kevin_walzer added on 2026-11-13 13:24:34: Revising one statement- I am sticking with gnome-shell 48. kevin_walzer added on 2026-11-13 12:51:03: Will fixing the screen size issues in [90d85ad8ce] also help here? More generally, I want to establish a baseline system that we use as the reference implementation for testing and deem the test suite passed if it succeeds there. Targeting whatever the CI runner is using is probably a reasonable solution. I do not want to try to accommodate every conceivable compositor and distro. I am currently working on Debian 13 and Gnome Shell 48. If you think I need to make the effort to update my systems to Debian unstable to accommodate Gnome Shell 51, I am willing to do this, but would want to draw a line there. I do not want to have to accommodate the same API churn on Wayland that we see on macOS. kevin_walzer added on 2026-11-13 11:40:58: Can you propose a fix that does not restore the wm maxsize/minsize failures? serhiy.storchaka added on 2026-11-13 11:34:10: The CI runs GNOME Shell 46 (Ubuntu 24.04). The tests fail with GNOME Shell 51.1 (Fedora 45), both headless and on a real screen. kevin_walzer added on 2026-11-13 11:19:59: These tests passed for me, and on the CI runner. | |||
Home
Timeline
Branches
Tags
Forum
Tickets
Download
Wiki