Tk Source Code

View Ticket
Login
Ticket UUID: 66db98f30dc03d33f68b88b80f3eaa114c28c854
Title: choosedir, filebox, msgbox tests fails on macOS + undocumented options -message and -command
Type: Bug Version: core-8-6-branch
Submitter: fvogel Created on: 2018-04-30 18:03:41
Subsystem: 36. [tk_chooseDirectory] Assigned To: fvogel
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2018-08-21 19:07:43
Resolution: Fixed Closed By: fvogel
    Closed on: 2018-08-21 19:07:43
Description:

choosedir-1.5 fails on macOS as follows:

==== choosedir-1.5 tk_chooseDirectory command FAILED
==== Contents of test case:

    tk_chooseDirectory -foo bar

---- Result was:
bad option "-foo": must be -initialdir, -message, -mustexist, -parent, -title, or -command
---- Result should have been (exact matching):
bad option "-foo": must be -initialdir, -mustexist, -parent, or -title
==== choosedir-1.5 FAILED

User Comments: fvogel added on 2018-08-21 19:07:43:
Thanks for your confirmation, this is now merged to core-8-6-branch and trunk.

marc_culler (claiming to be Marc Culler) added on 2018-08-21 01:00:55:
This all looks good to me.  The dialogs work.  The tests pass.

fvogel added on 2018-08-20 21:01:40:

In addition to my testing,

  make -C ./macosx test TESTFLAGS="-file msgbox.test -verbose beps -constraint  nonUnixUserInteraction"

is 100 % passing (that is: including the interactive tests from the test suite).

I plan to merge this very soon.


fvogel added on 2018-08-19 16:52:32:

Fix proposal is [4634437cb6] in the bugfix branch bug-66db98f30d.

- The test suite for msgbox.tcl runs 100% OK again.
- The message box buttons in the interactive demo (the "message boxes" sample in the widget demo) return the correct answer, i.e. regression [98dce84781] does not reappear.

Kevin and/or Marc, please test and confirm.


fvogel added on 2018-08-15 16:25:02:

Reopened since the fix needs further refinement, see [98dce847819].


fvogel added on 2018-05-13 17:43:04:
Merged to core-8-6-branch and trunk.

fvogel added on 2018-05-01 12:55:56:

At [ceca7257], test files choosedir.test, filebox.test and msgbox.test now pass fully OK on Windows, Linux and macOS.

I have taken this opportunity to unify the error messages for tk_messageBox among platforms, there is no reason they would be different (even though the underlying implementation of the dialog is platform-dependent).


fvogel added on 2018-05-01 10:49:18:

Again same issue with msgbox-1.1, msgbox-1.2, msgbox-1.11, msgbox-1.12, msgbox-1.14, msgbox-1.16, msgbox-1.18. This is now fixed in [39ba3d5069]


fvogel added on 2018-05-01 08:40:03:

Rhe macOS-specific options -message and -command are now documented, see the bugfix branch for the detailed commits.

Also tests filebox-1.1-0, filebox-1.3-0, filebox-4.1-0, filebox-4.3-0, filebox-1.1-1, filebox-1.3-1, filebox-4.1-1, and filebox-4.3-1 failed for the same reason choosedir-1.5 failed. This is now fixed in [c86f4aab83]


fvogel added on 2018-04-30 18:19:05:

Fixed in branch bug-66db98f30d.

BTW this reveals that the macOS-specific options -message and -command are undocumented. Leaving this bug open to fix that.