Tk Source Code

View Ticket
Login
Ticket UUID: 659129
Title: Tk_Uids clean up incorrectly w/ threads
Type: Bug Version: obsolete: 8.4.1
Submitter: nobody Created on: 2002-12-27 20:12:33
Subsystem: 72. Atoms Assigned To: hobbs
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2026-10-22 17:22:37
Resolution: Duplicate Closed By: serhiy.storchaka
    Closed on: 2026-09-24 20:35:17
Description:
From Christian Werner (chw ch-werner de)

While playing around with Tk 8.4.1 and multi-threading 
on Win32
I observed some strange behaviour w.r.t. Tk_Uids:

1. Tk_ConfigureWidget() converts the name/class/default 
values
in the given Tk_ConfigSpec to UIDs.

2. Tk_GetUid() installs a per-thread exit handler
(FreeUidThreadExitProc()) which destroys the per-thread 
UID
table (and the UIDs, too) on thread termination, i.e.
after the thread using Tk exited, some Tk_ConfigSpec 
fields
point to free'd memory.

3. When Tk is re-animated later (Tk_Init()) in a new 
thread,
arbitrary Bad Things happen as consequence to 
invalidated UIDs
from point 2.

Questions:

- Is it really necessary to convert name/class/default 
values to
UIDs in Tk_ConfigureWidget ?
- Is it really necessary to have a per-thread UID table ? 
---
In the meantime I tried to temporarily fix it by:

1. Making dbName/dbClass/defValue fields in 
Tk_ConfigSpec
to normal char pointer instead of Tk_Uids
2. Using a mutex locked global (= per process) Uid table
3. Making a temporary copy of the Tk_ConfigSpec array 
in
Tk_ConfigureWidget

See the attached patch. However, this isn't perfect since 
the
TK_CONFIG_OPTION_SPECIFIED bit is not reflected to 
callers
of Tk_ConfigureWidget for threaded builds of Tk. 
---
And attached patch.
User Comments: serhiy.storchaka added on 2026-09-24 20:35:17:

Duplicate of [749908ffff]: the same cause (Uids of one thread stored in the shared static Tk_ConfigSpec arrays), fixed in 8.4.12 and 8.5 by [acff622ae6] (8.4: [8efe94d3d4]). Each interpreter now gets its own copy of the specs.


nobody added on 2002-12-28 03:12:33:

File Added - 38313: TK841.patch

Attachments: