Tk Source Code

View Ticket
Login
Ticket UUID: 1870330
Title: Remove some Tk_Uid usage
Type: Patch Version: 8.7, 9.0
Submitter: pspjuth Created on: 2008-01-13 13:28:47
Subsystem: None Assigned To: jan.nijtmans
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2026-10-22 17:22:35
Resolution: Fixed Closed By: serhiy.storchaka
    Closed on: 2026-09-22 12:27:44
Description:
This patch cleans up some meaningless usages of Tk_Uid.

If noone objects, I'll commit this some day.
User Comments: serhiy.storchaka added on 2026-09-22 12:27:44:

This is done in 9.0. [fc05409ebc] ([0189a9ae39]) changed the same functions as the patch here -- Tk_GetColor(), Tk_Get3DBorder(), Tk_GetCursor(), Tk_GetCursorFromData() and the internal TkpGetColor()/TkpGetCursor() -- to take a "const char *" instead of a Tk_Uid, so color and cursor names are no longer interned permanently. See also [3109856], the memory growth which that interning caused in the canvas.


pspjuth added on 2008-01-16 22:30:08:
Logged In: YES 
user_id=98900
Originator: YES

Since most of them are documented to be char*, changing them
could be viewed as a bug fix...
And the change should be fully compatible unless I have missed
some aspect?

hobbs added on 2008-01-14 06:53:30:
Logged In: YES 
user_id=72656
Originator: NO

These unfortunately change the signatures of public APIs

pspjuth added on 2008-01-13 20:28:47:

File Added - 262006: tkuid.patch

Attachments: