Tk Source Code

View Ticket
Login
Ticket UUID: f40d9debad4364a1fcc8c8449d2778a6c72e0476
Title: Aqua: fix size of FourCC bitmaps
Type: Patch Version: 8.6.13
Submitter: chrstphrchvz Created on: 2023-05-16 04:41:38
Subsystem: 25. Built-in Bitmaps Assigned To: fvogel
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2023-05-23 17:29:26
Resolution: Fixed Closed By: fvogel
    Closed on: 2023-05-23 17:29:26
Description:

On Aqua, this example fails to create a label whose bitmap is a system icon specified using a OSType FourCC (four character code):

% label .l -bitmap flpy

This is because the bitmap being created has size 0×0 due to TkpGetNativeAppBitmap() neglecting to write *width or *height in the “last resort” OSType case. The attached patch fixes this.

User Comments: fvogel added on 2023-05-23 17:29:26:
Merged in core-8-6-branch and trunk (including difference in casting). Thanks!

fvogel added on 2023-05-21 18:36:53:

Thanks! Committed in [4df7b9066e].

Note: your report mentions version 8.6.13, but your patch is against trunk. The difference (which is casting the sizes into ints in trunk) will be handled at merge time.


Attachments: