| Ticket UUID: | f39133da29604cd301d357c8f393dd90cc284019 | |||
| Title: | Revised [text]: undoing a tag priority change releases the tag twice | |||
| Type: | Bug | Version: | revised_text | |
| Submitter: | nab | Created on: | 2026-10-11 12:41:57 | |
| Subsystem: | 18. [text] | Assigned To: | nobody | |
| Priority: | 5 Medium | Severity: | Important | |
| Status: | Closed | Last Modified: | 2026-10-11 12:46:47 | |
| Resolution: | Fixed | Closed By: | nab | |
| Closed on: | 2026-10-11 12:46:47 | |||
| Description: |
In the revised text widget, undoing
and this one fails
Without assertions, the reference count of the tag drops to zero while the text still uses it. UndoChangeTagPriorityPerform calls ChangeTagPriority with undo set, so replaying the token creates a second, retained token for the same change, and it always gives the reused token the redo type. UndoChangeTagPriorityDestroy ignores its Fix in branch nab-tag-priority-undo, with test textTag-20.1 (raise, undo, redo, undo, then destroy; without the fix it fails the assertion at the second undo). On a debug build on macOS, text*.test pass, and a fuzzer that mixes tag priority changes with undo and redo no longer fails in TkTextReleaseTag. | |||
| User Comments: |
nab added on 2026-10-11 12:46:47:
Merged into revised_text with [d42058c412|d42058c412]. | |||
Home
Timeline
Branches
Tags
Forum
Tickets
Download
Wiki