Tk Source Code

View Ticket
Login
Ticket UUID: ee40fd1fce8f2e407b25f158f3c079a52eedc2d
Title: report error message in Tk_CreateConsoleWindow
Type: Bug Version: 8.5.14
Submitter: anonymous Created on: 2013-06-26 09:50:19
Subsystem: 54. [console] Assigned To: fvogel
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2017-08-24 19:26:08
Resolution: Fixed Closed By: fvogel
    Closed on: 2017-08-24 19:26:08
Description:
In Tk_CreateConsoleWindow(), if an error occurs in Tcl_Init(consoleInterp) or Tk_Init(consoleInterp), the error is not redirected to interp.

    if (Tcl_Init(consoleInterp) != TCL_OK) {
	goto error;
    }

must become:

    if (Tcl_Init(consoleInterp) != TCL_OK) {
	Tcl_Obj *result_obj = Tcl_GetObjResult(consoleInterp);
	Tcl_SetObjResult(interp, result_obj);
	goto error;
    }
User Comments: fvogel added on 2017-08-24 19:26:08:
Merged to core-8-6-branch and trunk. Thanks!

fvogel added on 2017-08-12 19:37:56:

Thanks for the report and patch. I have committed this to a bugfix branch as [de6dd92084].

I wanted to credit you on this but realized I don't know your name?