Tk Source Code

View Ticket
Login
Ticket UUID: ec9270f5fd38d49b51cca7a4b7289386de09aa24
Title: font-45.3 test fails on macOS
Type: Bug Version: core-8-6-branch
Submitter: fvogel Created on: 2018-07-24 21:01:01
Subsystem: 45. Aqua Fonts Assigned To: fvogel
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2018-07-27 21:10:36
Resolution: Fixed Closed By: fvogel
    Closed on: 2018-07-27 21:10:36
Description:

font-45.3 test fails on macOS as follows:

==== font-45.3 TkFontGetAliasList: match FAILED
==== Contents of test case:

    # can fail on Unix systems that have a real "times new roman" font
    font actual {{times new roman} 10} -family

---- Result was:
Times New Roman
---- Result should have been (exact matching):
Times
==== font-45.3 FAILED

User Comments: fvogel added on 2018-07-27 21:10:36:
Merged to core-8-6-branch and trunk.

fvogel added on 2018-07-24 21:15:42:

The reason is contained in the test comment. Therefore the fix [4a081c223c]

As a bonus the "unix" constraint can be removed since the test will no longer fail on systems having "Times New Roman" such as Windows or macOS.

Purpose of the "noExceed" constraint is more obscure to me though. Who can explain this constraint to me? Here is how it is defined:

testConstraint noExceed [expr {
    ![testConstraint unix] || [catch {font actual "\{xyz"}]
}]

Is there any system on which font actual "\{xyz" will not error out?