Tk Source Code

[tk print $canvas] doesn't implement the raw smooth method on windows for both lines and polygons.

Running the attached demo script (using a virtual pdf printer) produces the attached file "smooth_raw_trunk.pdf"

The branch tk-print-fixes have a fix for this issue: see this commit.

After the change, the same script produces the attached file "smooth_raw_fixes.pdf"

> So my idea was commit what we have now all together

I looked at the code, and it looks fine to me. Just don't use "bool" as variable-name that's my only remark ;-)

Therefore, now merged to core-9-0-branch (and trunk)

The plan looks fine to me.

One week later, since we got no further comment I think you can merge if you wish so.

My plan was to address the issues I found, with visible impact in the final user, in an ordered manner. I filled three tickets because, while all related, they can be seen as different aspects of the same functionality.

I've stopped commiting further changes to allow reviewers (and testers) check the changes and give ok (or not, or propose changes), before going further in two more issues: full support for text rotation and a bit of housekeeping.

So my idea was commit what we have now all toghether (along with proposed changes) despite having several bug reports pointing out small issues.

I have reviewed the [b09c19dbccd1176e|patch], it looks totally fine to me. I also have tested the code and it works for me.

Do you want me to merge? Since all your patches are in a single branch, how do you think this should all be merged? Cherrypick each patch, or merge the tk_print_fixes branch at once?