Tk Source Code

View Ticket
Login
Ticket UUID: d6ca319010c34bcc56f5a6c3c94d55fc0da2962d
Title: Tests fail without a window manager (failsOnCILinux, failsOnXQuartz)
Type: Bug Version: 8.6.18, 9.0.5, 9.1b1
Submitter: serhiy.storchaka Created on: 2026-09-26 21:05:25
Subsystem: 86. Test Tools Assigned To: jan.nijtmans
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2026-09-30 19:07:22
Resolution: Fixed Closed By: nobody
    Closed on: 2026-09-28 09:16:15
Description:

Several tests fail without a window manager, e.g. in the GitHub CI environment, and are therefore constrained with failsOnCILinux and failsOnXQuartz; the comments in pack.test and place.test say that the cause is unknown.

The cause is that these tests use wm iconify to unmap a toplevel. On X11 iconifying is done by the window manager: without one (and also with some window managers, e.g. mutter or tiling ones) the window stays mapped, and WaitForMapNotify gives up after 2 seconds. wm withdraw unmaps the window without a window manager. The affected tests are pack-18.1.1, pack-18.2, place-8.1, place-8.2, winfo-9.4, winfo-9.7, unixWm-42.1 and wm-forget-1.5 (which also checks that [winfo rooty] is not 0, but without a window manager the toplevel is at the screen origin).

unixEmbed-8.1 depends on the pointer position: without a window manager the focus follows the pointer, so it fails if the pointer is left over the container, e.g. by focus-8.1 when running the whole test suite.

Other tests with these constraints pass without a window manager: canvas-8.1, select-9.2-9.4, select-10.4-10.6, select-11.1, select-13.1 and unixWm-50.9.

Proposed fix in branch tests-without-wm. It removes these constraints from the tests above, so they run on CI too.

User Comments: serhiy.storchaka added on 2026-09-30 19:07:22:

Merged into trunk by [29dd51f768], as approved by Erik Leunissen on tcl-core, and backported to core-9-0-branch ([334d14e2f3]) and core-8-6-branch ([d037c34f65]). The GitHub CI run had no failures other than those which occur on trunk too.


oehhar added on 2026-09-28 10:07:50:
Wrong ticket with "It is ME", sorry. Thanks for reopening ticket, sorry,
Harald

oehhar added on 2026-09-28 09:16:15:
It is ME !

serhiy.storchaka added on 2026-09-28 09:10:21:

Thank you, Jan. Merged into trunk [9fa118ae0c] and backported to core-9-0-branch [bcbfe955cc] and core-8-6-branch [99ad325229].

The remaining failsOnCILinux tests in wm.test and unixWm.test really need a window manager: they fail without one and pass with it. Branch with-window-manager-constraint replaces failsOnCILinux and failsOnXQuartz there with a new constraint withWindowManager, which checks whether a window manager has set the WM_STATE property on the main window. So these tests are skipped without a window manager and run with one, also locally.


jan.nijtmans added on 2026-09-27 08:39:39:

Found it: [dfda3ef8f8363cfa1afe]


jan.nijtmans added on 2026-09-27 08:39:01:

+1. Feel free to merge to trunk (and core-9-0-branch/core-8-6-branch if you want)

There already is a ticket about canvas-8.1 somewhere. It started failing with Ubuntu 26-04, works fine with Ubuntu 22-04


serhiy.storchaka added on 2026-09-27 08:01:19:

On GitHub CI all tests from which the constraints were removed passed on Linux, except canvas-8.1. It does not need a window manager, but fails there for another reason: the bbox of the arc created with -height is {39798 2013 39902 15185} instead of {98 171 302 202}. I cannot reproduce it locally. Its failsOnCILinux constraint is restored in [d2bd2b96a8].