Tk Source Code

View Ticket
Login
Ticket UUID: d48cbf0641443df5b8071f2b1d8b0caa72b535d0
Title: build failure on macOS < 10.13
Type: Bug Version: 9.0b3
Submitter: chpock Created on: 2024-09-13 18:11:15
Subsystem: 83. Mac OS X Build Assigned To: marc_culler
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2024-10-17 19:21:37
Resolution: Fixed Closed By: jan.nijtmans
    Closed on: 2024-10-17 19:21:37
Description:

There is a block which is only defined on macOS >= 10.13: https://github.com/tcltk/tk/blob/e7965961f917a275ff28b5689385935ce02539b3/macosx/tkMacOSXWm.c#L183-L297

But the variables from it are used throughout the file with no restrictions on macOS versions. E.g.:

appearanceStrings array: https://github.com/tcltk/tk/blob/e7965961f917a275ff28b5689385935ce02539b3/macosx/tkMacOSXWm.c#L1688

styleMaskBits: https://github.com/tcltk/tk/blob/e7965961f917a275ff28b5689385935ce02539b3/macosx/tkMacOSXWm.c#L1782

There are too many errors. It is possible to reproduce them using CFLAGS with -mmacosx-version-min=10.6

User Comments: jan.nijtmans added on 2024-10-17 19:21:37:

Dup of [cb052066de]?

Anyway, I think this is fixed now.


chpock added on 2024-09-13 19:02:42:
My initial description is not correct. It seems that block is included when maximum macOS version in build environment is >= 10.13.

However, the title is correct. During a build in macOS 10.12.6 environment, this definition is 101204 and this block is disabled, resulting in numerous compilation errors.