Tk Source Code

View Ticket
Login
Ticket UUID: d0bceae242a44b16a89b08da4a7ebae9925c4929
Title: Wayland branch: CI failures hidden by the constraints.tcl error
Type: Bug Version: wayland
Submitter: serhiy.storchaka Created on: 2026-11-16 09:21:59
Subsystem: (unused) Assigned To: nobody
Priority: 5 Medium Severity: Minor
Status: Open Last Modified: 2026-11-16 11:25:08
Resolution: None Closed By: nobody
    Closed on:
Description:

Until the merge of trunk on 2026-11-15, tests/constraints.tcl on the wayland branch stopped with can't unset "fs": no such variable, a leftover of [03c66d8453] fixed on main in [787e0bd278]. The test suite did not run at all, but the CI jobs still reported success. Now the tests run again and show failures which were hidden:

  • Linux: scale-3.18 (119.0 instead of 119.5) and scale-7.8 (118 40 instead of 114 39). tkScale.c and scale.test are the same as on main, where these tests pass.
  • macOS: imgPhInstance-7.1, imgPhInstance-7.2, progressbar-3.4, unixEmbed-10.2.
  • Windows (gcc): imgPhInstance-7.1, 7.2 and 7.3. The photo image code on the branch differs from main, so the recent -gamma and -palette fixes on main may be missing.
  • Windows (MSVC): the build fails on warning C4101, unused local variable offset, in tkImgPhoto.c line 2453 and tkImgPhInstance.c line 944.
  • Linux (with Tcl 9.0): the workflow now installs tcl9.1-dev, which Ubuntu does not provide (Unable to locate package tcl9.1-dev). Main still uses tcl9.0-dev.

See the CI runs of 2026-11-16.

User Comments: kevin_walzer added on 2026-11-16 11:25:08:
The -singleproc flag should be set to 1.

serhiy.storchaka added on 2026-11-16 11:08:52:

imgPhInstance-7.x: see [b17dcd7168].

progressbar-3.4 and unixEmbed-10.2 on macOS fail only because the test files run in separate processes. progressbar-3.4 passes on main only because entry.test leaves the "default" theme set. unixEmbed-10.2 passes on main in one process; I cannot test it on macOS.


serhiy.storchaka added on 2026-11-16 10:57:01:

scale-3.18 and scale-7.8 fail because of a bug in scale.test, not in the wayland branch. Since Tk 9, tk.tcl sets the default scale sizes in the option database in points (-length 75p, -width 11.25p, -sliderlength 22.5p), but the tests expect 100, 15 and 30 pixels, which is the same only at 96 DPI. On main they pass because the test files run in one process, and several earlier files (config.test, option.test, palette.test and others) clear the option database. On the wayland branch the test files run in separate processes (TESTFLAGS = -singleproc 0 in unix/Makefile.in, since [71d611096a]), so scale.test starts with the sizes in points. On main both tests fail too when scale.test is run alone.

The fix is [aa57e2a1bb] on branch tests-high-dpi ([deca13e833]): scale.test sets the sizes in pixels in its option database. It also does this for the panedwindow sash width and the X11 scrollbar width.


serhiy.storchaka added on 2026-11-16 10:27:09:

The MSVC build failure (warning C4101) is fixed on wayland in [133667e053].

Why the jobs reported success although no test ran is filed separately, since it affects all branches: [ead4782b08], with a proposed fix in branch ci-test-exit-status, and Tcl ticket 7abc1460c0 for the cause in tcltest.

The other failures listed above are still open.