Tk Source Code

Build tk 9.0.1 failed on macos 10.13.

Error log:

clang -dynamiclib -O2 -pipe  -arch x86_64 -finput-charset=UTF-8     -headerpad_max_install_names -Wl,-search_paths_first  -o libtcl9tk9.0.dylib tk3d.o tkArgv.o tkAtom.o tkBind.o tkBitmap.o tkBusy.o tkClipboard.o tkCmds.o tkColor.o tkConfig.o tkConsole.o tkCursor.o tkError.o tkEvent.o tkFocus.o tkFont.o tkGet.o tkGC.o tkGeometry.o tkGrab.o tkGrid.o tkMain.o tkObj.o tkOldConfig.o tkOption.o tkPack.o tkPkgConfig.o tkPlace.tkSelect.o tkStyle.o tkUndo.o tkUtil.o tkVisual.o tkWindow.o tkButton.o tkEntry.o tkFrame.o tkListbox.o tkMenu.o tkMenubutton.o tkMenuDraw.o tkMessage.o tkPanedWindow.o tkScale.o tkScrollbar.o tkCanvas.o tkCanvArc.o tkCanvBmap.o tkCanvImg.o tkCanvLine.o tkCanvPoly.o tkCanvPs.o tkCanvText.o tkCanvUtil.o tkCanvWind.o tkRectOval.o tkTrig.o tkImage.o tkImgBmap.o tkImgGIF.o tkImgPNG.o tkImgPPM.o tkImgPhoto.o tkImgPhInstance.o tkImgListFormat.o tkImgSVGnano.o tkText.o tkTextBTree.o tkTextDisp.o tkTextImage.o tkTextIndex.o tkTextMark.o tkTextTag.o tkTextWind.o tkStubInit.o ttkBlink.o ttkButton.o ttkCache.o ttkClamTheme.o ttkClassicTheme.o ttkDefaultTheme.o ttkElements.o ttkEntry.o ttkFrame.o ttkImage.o ttkInit.o ttkLabel.o ttkLayout.o ttkManager.o ttkNotebook.o ttkPanedwindow.o ttkProgress.o ttkScale.o ttkScrollbar.o ttkScroll.o ttkSeparator.o ttkSquare.o ttkState.o ttkTagSet.o ttkTheme.o ttkTrace.o ttkTrack.o ttkTreeview.o ttkWidget.o ttkStubInit.o tkMacOSXBitmap.o tkMacOSXButton.o tkMacOSXClipboard.o tkMacOSXColor.o tkMacOSXConfig.o tkMacOSXCursor.o tkMacOSXDebug.o tkMacOSXDialog.o tkMacOSXDraw.o tkMacOSXEmbed.o tkMacOSXEntry.o tkMacOSXEvent.o tkMacOSXFileTypes.o tkMacOSXFont.o tkMacOSXHLEvents.o tkMacOSXImage.o tkMacOSXInit.o tkMacOSXKeyboard.o tkMacOSXKeyEvent.o tkMacOSXMenu.o tkMacOSXMenubutton.o tkMacOSXMenus.o tkMacOSXMouseEvent.o tkMacOSXNotify.o tkMacOSXPrint.o tkMacOSXRegion.o tkMacOSXScrlbr.o tkMacOSXSend.o tkMacOSXServices.o tkMacOSXSubwindows.o tkMacOSXSysTray.o tkMacOSXWindowEvent.o tkMacOSXWm.o tkMacOSXXStubs.o tkFileFilter.o tkMacWinMenu.o tkPointer.o tkUnix3d.o tkUnixScale.o xcolors.o xdraw.o xgc.o ximage.o xutil.o ttkMacOSXTheme.o    -headerpad_max_install_names -Wl,-search_paths_first  -framework CoreFoundation -framework Cocoa -framework Carbon -framework IOKit -framework QuartzCore -framework Security -framework CoreGraphics    -lz  -lpthread -framework CoreFoundation  -ltommath  -L/usr/local/Cellar/tcl-tk/9.0.1/lib -ltclstub  -compatibility_version 9.0 -current_version 9.0.1 -install_name "/usr/local/Cellar/tcl-tk/9.0.1/lib/libtcl9tk9.0.dylib" -unexported_symbols_list $(f=libtcl9tk9.0.dylib.E && nm -gp tkMacOSX*.o 2>/dev/null | awk "/^[0-9a-f]+ . \.objc/ {print \$3}" > $f && nm -gjp "/usr/local/Cellar/tcl-tk/9.0.1/lib"/libtclstub.a | grep ^_[^_] >> $f && echo $f) -sectcreate __TEXT __info_plist Tk-Info.plist 
Undefined symbols for architecture x86_64:
  "_placeAsTab", referenced from:
      _WmSetAttribute in tkMacOSXWm.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

This bug was introduced from the line in tkMacOSXWm.c and this commit.

I changed the macro "#if MAC_OS_X_VERSION_MAX_ALLOWED >= 101400" back to "#if MAC_OS_X_VERSION_MAX_ALLOWED >= 101300", and it built successfully.