Tk Source Code

View Ticket
Login
Ticket UUID: bb8041c2393b615455bf0843118538d414649716
Title: Call legacy Tk_ImageCreateProc using correct function pointer type
Type: Patch Version: 8.6.13
Submitter: chrstphrchvz Created on: 2023-10-15 14:08:22
Subsystem: 39. Image Basics Assigned To: fvogel
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2023-10-28 08:22:09
Resolution: Fixed Closed By: fvogel
    Closed on: 2023-10-28 08:22:09
Description:

See attached patch. UBSan -fsanitize=function error triggered by image-5.6:

tk/generic/tkImage.c:375:6: runtime error: call to function ImageCreate through pointer to incorrect function type 'int (*)(struct Tcl_Interp *, const char *, int, struct Tcl_Obj *const *, const struct Tk_ImageType *, struct Tk_ImageMaster_ *, void **)'
tkOldTest.c:154: note: ImageCreate defined here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior tk/generic/tkImage.c:375:6 in

User Comments: fvogel added on 2023-10-28 08:22:09:
Thank you! Now merged in core-8-6-branch and trunk.

Attachments: