Tk Source Code

View Ticket
Login
Ticket UUID: bb528557810db962e9c231239811e15be0be95e0
Title: ttk treeview tests not robust against display scaling
Type: Bug Version: main
Submitter: fvogel Created on: 2024-05-04 19:57:43
Subsystem: 86. Test Tools Assigned To: fvogel
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2024-05-12 19:02:13
Resolution: Fixed Closed By: fvogel
    Closed on: 2024-05-12 19:02:13
Description:

At least on Linux (Ubuntu-22.04 or Debian 11), when the display scale is set to 200 %, four treeview tests fail as follows:

==== treeview-identify-6 vertical scan - with headings FAILED
==== Contents of test case:

    .tv configure -displaycolumns #all -show {tree headings}
    update idletasks
    identify* .tv {region item} 25 10  25 30  25 50  25 90  25 110

---- Result was:
heading {} heading {} tree branch tree item1 tree item2
---- Result should have been (exact matching):
heading {} tree branch tree item1 tree item2 tree item3
==== treeview-identify-6 FAILED

==== treeview-identify-7 vertical scan - headings, no tree FAILED
==== Contents of test case:

    .tv configure -displaycolumns #all -show {headings}
    update idletasks
    identify* .tv {region item cell} 25 10  25 30  25 50  75 90 25 110

---- Result was:
heading {} {} heading {} {} cell branch {branch #1} cell item1 {item1 #2} cell item2 {item2 #1}
---- Result should have been (exact matching):
heading {} {} cell branch {branch #1} cell item1 {item1 #1} cell item2 {item2 #2} cell item3 {item3 #1}
==== treeview-identify-7 FAILED

==== treeview-identify-8 identify element FAILED
==== Contents of test case:

    .tv configure -show {tree}
    .tv insert branch  0 -id branch2 -open true
    .tv insert branch2 0 -id branch3 -open true
    .tv insert branch3 0 -id leaf3
    update idletasks;
    identify* .tv {item element} 10 10  30 30  50 50

---- Result was:
branch Treeitem.indicator branch2 {} branch3 {}
---- Result should have been (glob matching):
branch *.indicator branch2 *.indicator branch3 *.indicator
==== treeview-identify-8 FAILED

==== treeview-identify-8.1 identify element FAILED
==== Contents of test case:

    .tv configure -show {tree headings}
    update
    identify* .tv element 1 1  10 10  25 25
    # Heading elements are currently not reported

---- Result was:
{} {} {}
---- Result should have been (exact matching):
{} {} text
==== treeview-identify-8.1 FAILED

This was reported by Jaime Villate on Tcl-Core when testing Tcl/Tk 9.0b2 release candidate.

User Comments: fvogel added on 2024-05-12 19:02:13:
Merged in trunk.

fvogel added on 2024-05-05 21:58:37:
Side note: I intend to correct this problem in 9.0 only, not in 8.6.

fvogel added on 2024-05-05 21:41:02:

I have committed a fix, see branch bug-bb52855781.

The fix promotes the treeview identify command so that it is now points-aware, i.e. any distance in screen units can be used (not just pixels). This is the same as what was done for -rowheight/-columnseparatorwidth/-indent in [c7ae9a87].


erikleunissen added on 2024-05-04 21:09:27:
Sorry, correct message for the wrong ticket. Please ignore.

erikleunissen added on 2024-05-04 21:07:50:
Just ran the minimal script in the following environments on Linux X11:

A. with these window managers:

       e16 Fluxbox fvwm IceWM KWin Metacity Openbox TWM WindowMaker Xfwm4

   All of them without a desktop environment, just the window manager.

B. without any window manager or desktop environment, just the raw X server.

C. with the KDE desktop, using openbox as the window manager (instead of the default window manager KWin).

Result: the root window resized as expected in all cases, except for case A. with KWin.

Conclusion: it's the KWin window manager that's misbehaving, not the KDE desktop environment.