Tk Source Code

In the clam theme, the Checkbutton.indicator and Radiobutton.indicator elements have a -indicatorforeground option.  However, the library file clamTheme.tcl doesn't contain any code related to this option, especially to its value in the disabled state.  Obviously, this was simply forgotten.  As a result, as easily seen in the left half of the attachment screenshots_clam.png, the inner parts of disabled ttk::checkbutton and ttk::radiobutton widgets are displayed in black color, unlike their text, which is rendered in the color $colors(-disabledfg).  I strongly doubt that this discrepancy was intentional.

I have prepared the necessary patch (see the attachment clamTheme.diff), which I would like to commit myself, provided that there are no objections.  The right half of the attachment screenshots_clam.png shows the improved appearance of the disabled widgets after applying this change.

Agreed!

I thought I should do it tomorrow, after seeing the CI status (I am not expecting any problems, but who knows).

Great. Any reason for not closing this ticket?

Fixed with commits [64439dea], [bd88e189], and [0c69de86].

Csaba, this looks OK to me please proceed. I'm assigning the ticket to you.

Thanks Harald, I can do the commit into a branch myself. I just want to see whether there are any objections against my proposal before doing the commit.

Csaba,
fossil is difficult.
Nevertheless, please try to first commit into a branch.
In this case for example:

fossil commit --branch a69fd7cd-clam-indicator

Shall I do the action for you ?

Thanks for all,
Harald

Looks great as always !

Thanks for all your work,
Harald