| Ticket UUID: | 9fd3fbaf03b8a5d41a03cfd419b4dfd9fffcccec | |||
| Title: | spinbox.test failures | |||
| Type: | Bug | Version: | 8.6+ | |
| Submitter: | dgp | Created on: | 2017-02-02 17:08:15 | |
| Subsystem: | 17. [spinbox] | Assigned To: | nobody | |
| Priority: | 5 Medium | Severity: | Minor | |
| Status: | Open | Last Modified: | 2017-12-20 21:13:48 | |
| Resolution: | None | Closed By: | nobody | |
| Closed on: | ||||
| Description: |
These tests appear to fail in a `make test`
but not (reliably) in isolation.
Suspect poor test suite hygiene.
==== spinbox-19.10 spinbox widget validation FAILED
==== Contents of test case:
spinbox .e -validate all -validatecommand [list doval %W %d %i %P %s %S %v %V] -invalidcommand bell -textvariable ::e -background red -foreground white
pack .e
.e insert end abcd ;# previous settings
focus -force .e
# update necessary to process FocusIn event
update
set ::vVals
---- Result was:
.e -1 -1 abcd abcd {} all focusout
---- Result should have been (exact matching):
.e -1 -1 abcd abcd {} all focusin
==== spinbox-19.10 FAILED
==== spinbox-19.14 spinbox widget validation FAILED
==== Contents of test case:
spinbox .e -validate focuso -validatecommand [list doval %W %d %i %P %s %S %v %V] -invalidcommand bell -textvariable ::e -background red -foreground white
pack .e
.e insert end abcd ;# previous settings
set ::vVals {} ;# previous settings
focus -force .e
# update necessary to process FocusIn event
update
set ::vVals
---- Result was:
.e -1 -1 abcd abcd {} focusout focusout
---- Result should have been (exact matching):
==== spinbox-19.14 FAILED
| |||
| User Comments: |
fvogel added on 2017-12-20 21:13:48:
Hmmm, spinbox-19.8 fails when running 'make test' (still in trunk) and doing nothing with the computer. fvogel added on 2017-12-20 21:05:36: I can only reproduce this (on CentOS7, and it happens reliably) if I use the computer while the test suite is running, for instance with: make test TESTFLAGS="-file spinbox.test" If I don't use it this does not fail. Problems output by the test suite is due to unexpected focus events happening. In addition to the reported failing spinbox-19.10 and spinbox-19.14 I can also make spinbox-19.8 fail (for the same reason). These tests can be made to fail just by clicking inside any window while the test suite is running. Is this really a bug...? fvogel added on 2017-02-09 20:24:32: The OP reports that platform is CentOS Linux on KDE but cannot be more precise. Should be either 7.2.1511 or 7.3.1611. fvogel added on 2017-02-02 20:28:58: What platform? Does not happen for me on Win (Vista), OSX 10.12.2 or Linux Debian 8. Do these tests fail reliably in a `make test`? (I have understood it's not the case in isolation, but how is reliability in a complete full Tk test run?) Also, did you use the computer while the test suite was running? Could be the cause for the wrong focus event in the result of spinbox-19.10. Won't look at the second failure until the first one is solved, see comment in spinbox.test: ## ## Spinbox widget VALIDATION tests ## # The validation tests build each one upon the previous, so cascading # failures aren't good # # 19.* test cases in previous version highly depended on the previous # test cases. This was replaced by inserting recently set configurations # that matters for the test case | |||
Home
Timeline
Branches
Tags
Forum
Tickets
Download
Wiki