Tk Source Code

There is currently this compiler warning (at least for sufficiently recent Xcode clang or SDK):

macosx/tkMacOSXImage.c:692:7: warning: implicit conversion from enumeration type 'CGImageAlphaInfo' (aka 'enum CGImageAlphaInfo') to different enumeration type 'CGBitmapInfo' (aka 'enum CGBitmapInfo') [-Wenum-conversion]
  687 |             cg_context = CGBitmapContextCreate(NULL, width, height,
      |                          ~~~~~~~~~~~~~~~~~~~~~
  688 |                     CGImageGetBitsPerComponent(cg_image),
  689 |                     //CGImageGetBytesPerRow(cg_image), // wastes space?
  690 |                     CGImageGetBitsPerPixel(cg_image) * width / 8,
  691 |                     colorspace,
  692 |                     CGImageGetAlphaInfo(cg_image));
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

The use of CGImageGetAlphaInfo(cg_image) came from the example from which I had adapted this code. To eliminate the warning, I think it would be okay or possibly better to use CGImageGetBitmapInfo(cg_image) instead.

Fixed [cd63d694753c0e81|here]

Proposed [cd88fa9e3bcc6e60|fix] looks good to me.

Thanks!