Tk Source Code

View Ticket
Ticket UUID: 776545
Title: TIP 109 implementation
Type: Patch Version: TIP Implementation
Submitter: bgriffin Created on: 2003-07-23 21:48:55
Subsystem: 02. Appearance Assigned To: dkf
Priority: 9 Immediate Severity:
Status: Closed Last Modified: 2003-11-13 03:17:34
Resolution: Accepted Closed By: dkf
    Closed on: 2003-08-14 12:34:54
Attached are the patches to apply to 8.5 HEAD versions
of tkUnixButton.c and tkUnixMenu.c.  These changes
implement TIP 109.

User Comments: dkf added on 2003-08-15 16:06:17:
Logged In: YES 

The problem was quite simply a failure to pass the test
suite, and it looked to me like an unexpected case,
somewhere where you thought something would never be NULL
but which could actually happen.  I find the test suite to
be fairly good for finding such stuff.

BTW, it looks good.

bgriffin added on 2003-08-15 08:47:20:
Logged In: YES 

I'm sorry for submitting bad code.  I rushed it trying to
submit the implementation before the conference.  Always a
bad move :-(

I did test the patch across multiple platforms, but in all
cases I did not have a stressed color map.  I fixed this bug
a couple days ago.  There seems to be another bug that is
showing up only on 64-bit AIX5 which is color related, but
is not a crash.  I'm still trying to track this down.  

We will be releasing product by September which will include
this patch, so rest assured that I will wring out any
remaining bugs.


dkf added on 2003-08-14 19:34:54:
Logged In: YES 

Applied to CVS HEAD.

Brian, I had to alter a few bits to stop the test suite crashing 
with accesses to NULL pointers.  Please could you stress-test 
the version in the core ASAP to check that it is still behaving 
correctly; the problem was that both buttons and menus 
would sometimes try to derive the selectColor argument to 
TkpDrawCheckIndicator() from a NULL pointer, and my fix in 
each case was to force a NULL to get passed through for 
that argument which might not be correct.  If what I have 
done is wrong, please create a new bug and assign it to me.

dkf added on 2003-08-13 22:24:36:
Logged In: YES 

I have marginally more free time than Jeff.

bgriffin added on 2003-07-29 12:16:39:

File Added - 57200: tip109.tgz

Logged In: YES 

Fix problems found with previous patch.

bgriffin added on 2003-07-24 04:48:56:

File Added - 56672: tip109.patch