| Ticket UUID: | 719ae3991b3958d447485813fc1fb7e18ae5345b | |||
| Title: | ttk scrollbar-1.[23] tests fail on macOS (regression) | |||
| Type: | Bug | Version: | core-8-6-branch | |
| Submitter: | fvogel | Created on: | 2018-09-09 15:35:27 | |
| Subsystem: | 16. [scrollbar] | Assigned To: | fvogel | |
| Priority: | 5 Medium | Severity: | Minor | |
| Status: | Closed | Last Modified: | 2018-10-18 20:29:30 | |
| Resolution: | Fixed | Closed By: | fvogel | |
| Closed on: | 2018-10-18 20:29:30 | |||
| Description: |
ttk tests scrollbar-1.[23] are now failing (regression) on macOS as follows:
==== scrollbar-1.2 Set orientation FAILED
==== Contents of test case:
.tsb configure -orient vertical
set w [winfo reqwidth .tsb] ; set h [winfo reqheight .tsb]
expr {$h > $w}
---- Result was:
0
---- Result should have been (exact matching):
1
==== scrollbar-1.2 FAILED
==== scrollbar-1.3 Change orientation FAILED
==== Contents of test case:
.tsb configure -orient horizontal
set w [winfo reqwidth .tsb] ; set h [winfo reqheight .tsb]
expr {$h < $w}
---- Result was:
0
---- Result should have been (exact matching):
1
==== scrollbar-1.3 FAILED
This didn't happen before the recent scrollbar management reform that started with [2be8fdb7]. | |||
| User Comments: |
fvogel added on 2018-10-18 20:29:30:
Merged to core-8-6-branch and trunk. At this point scrollbar.test runs 100% PASS on all 3 plaftorms (Win Vista, Linux Debian 8 and macOS 10.12). kevin_walzer added on 2018-09-24 12:15:38: Francois, I see your work is much further along than mine, so I've closed my branch. I've re-opened [a84b20ed] to see if our goals can converge here--both passing the test suite and fixing the reported buggy behavior in the referenced ticket. I thought my previous fix addressed the reported behavior, but it had some side effects, and so I've backed that out. Can you try the test script in [a84b20ed] and advise if your fixes address it? fvogel added on 2018-09-24 06:30:51: Well, since it was quick and easy I updated to mac-scrollbar-metrics-restore and ran make -C ./macosx test TESTFLAGS="-file scrollbar.test" Results are worse than before: now 30 tests are failing (instead of 11) with the Develoment target, or 21 with the Deployment target. This is probably due to the fact the variables width and height are used uninitialized in your code (which problem the compiler correctly complains about). Strange that you see an operational improvement. My suggestion: not sure it's worth to waste your time here, I have a clear view on the needed fixes to make the test suite pass. I will submit these to your operational testing very soon. I have already created a branch fv-macos-scrollbar-tests yesterday to gather all the fixes from different tickets (there are at least three or four different issues at play with the scrollbar test suite, I will open a different ticket for each of them, it's much cleared IMO). fvogel added on 2018-09-24 06:22:34: Sure, I will try your fix. However I would be surprised if it would fix the failing tests. I have investigated those failing tests 1-2 weeks ago and I have found what is incorrect, and it's different from what you put in the mac-scrollbar-metrics-restore branch (except addition of minThumbHeight, which I already proposed in [16fdad9d39] for the present ticket). I would be very surprised if all tests would suddenly pass, that would mean I was grossly mistaken (always possible!). I will provide my fixes, just give me some time I need to clean them a little bit first. kevin_walzer added on 2018-09-24 02:40:34: Francois, can you please check the branch I just committed, mac-scrollbar-metrics-restore, and see if it addresses this bug and any of the other failing scroll tests on macOS? My informal testing of the scrolling, especially hit-testing to ensure the mouse on the scroller, shows a lot of improvement here. kevin_walzer added on 2018-09-09 21:47:53: This change, at the very least, does not introduce any breakage in the widget demo. fvogel added on 2018-09-09 16:05:28: These failures are due to the loss of the minThumbHeight in the Tk_GeometryRequest in TkpComputeScrollbarGeometry (tkMacOSXScrlbr.c) in the process of the below fixes when copying TkpComputeScrollbarGeometry from tkUnixScrlbr.c to tkMacOSXScrlbr.c. The requested height does no longer take into account the min size of the thumb. Fix proposal is therefore [16fdad9d39]. Note: the 11 (Tk, not Ttk) scrollbar* tests that fail (scrollbar-3.26, 3.27, 3.28, 3.35, 3.50, 6.11, 6.12, 6.25, 6.39, 10.1, 10.2) still fail identically with this fix. fvogel added on 2018-09-09 15:55:56: The detailed recent story of failure/success for these two tests is as follows:
| |||
Home
Timeline
Branches
Tags
Forum
Tickets
Download
Wiki