Tk Source Code

View Ticket
Login
Ticket UUID: 68385104aa960ceac592bfbcf1fd7eafd2f8ec84
Title: Wayland branch does not build for X11: redefinition of nc in tkUnixBidiFont.c
Type: Bug Version: wayland
Submitter: serhiy.storchaka Created on: 2026-10-14 16:17:48
Subsystem: (unused) Assigned To: aku
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2026-10-22 17:22:37
Resolution: Fixed Closed By: serhiy.storchaka
    Closed on: 2026-10-14 18:34:02
Description:

The wayland branch ([438c60c73f]) fails to build with the default (X11) configuration:

unix/tkUnixBidiFont.c:2113:34: error: redefinition of 'nc'

The block that keeps ZWJ, VS16 and the keycap mark in the color face's subrun is there twice, the old version and the new one from trunk. It came with the merge of color_emoji_wayland [5926adb608]; color_emoji_wayland itself ([36af675f11]) has it too. Removing the old block (11 lines starting at the first FcChar32 nc) gives the code of trunk and builds.

User Comments: kevin_walzer added on 2026-10-14 18:31:55:
I have pruned the redundant lines.

serhiy.storchaka added on 2026-10-14 18:00:42:

Thanks, the wayland branch builds for X11 again. The old block is still there before the new one, though ([fc6944ed2e] removed only the second declaration): the 11 lines of the old ZWJ/VS16/keycap check are redundant, since the new check covers these characters, and without them the file is the same as on trunk, which avoids a conflict at the next merge of trunk.


kevin_walzer added on 2026-10-14 16:27:01:
Fix committed. Thank you.