Ticket UUID: | 5da1d76e011f3bb30712e6c896d2a170abf3deeb | |||
Title: | X11: add default bindings for non-emulated horizontal scrolling to Tk 8.6 | |||
Type: | RFE | Version: | 8.6.9.1 | |
Submitter: | chrstphrchvz | Created on: | 2019-08-18 07:00:52 | |
Subsystem: | 01. Bindings | Assigned To: | jan.nijtmans | |
Priority: | 5 Medium | Severity: | Minor | |
Status: | Closed | Last Modified: | 2019-08-22 14:36:05 | |
Resolution: | Fixed | Closed By: | chrstphrchvz | |
Closed on: | 2019-08-22 14:36:05 | |||
Description: |
In light of [7ff5f55b] and the recent efforts on the mousewheel-refactor branch, would it be desirable to add default bindings in Tk 8.6 for non-emulated horizontal scrolling on X11 (i.e. buttons 6 and 7), particularly where there are already bindings for emulated horizontal scrolling (i.e. using This is different from [38dc27bd], as events for binding directly to buttons 6 and higher will likely not arrive until after 8.6, and might even be replaced with The approach for adding these bindings would be to bind to For more aggressive refactoring of emulated and non-emulated horizontal scrolling into single binding scripts, bit 0 of | |||
User Comments: |
chrstphrchvz added on 2019-08-22 14:36:05:
It works! Thanks for addressing this, Jan. I do like how relatively simple the translation approach is. I think the main reason I thought that approach might be less desirable is because it has a broader impact than making the default bindings more complex by checking jan.nijtmans added on 2019-08-22 06:43:42: Fixed in core-8-6-branch. jan.nijtmans added on 2019-08-19 21:58:01: Added experimental https://core.tcl-lang.org/tk/timeline?r=rfe-5da1d76e01-bis branch, in which Buttons 6/7 are simply translated to Shift 4/5. As suggested. Surprisingly simple! jan.nijtmans added on 2019-08-18 21:24:51: Please test/review the [rfe-5da1d76e01] branch. Does this work, and does what this RFE suggests for you? I think that it's no problem defining additional <ButtonPress> bindings. If user programs do that, the User program definition wil break the default Button 6/7 handling, but it doesn't work either way now so that's not a regression. But I would like to do more testing (help appreciated!) before definitely concluding that it doesn't do harm. This branch should be "merge-mark"-ed to trunk, since trunk already has proper Button 6/7 handling. |
