Tk Source Code

View Ticket
Login
Ticket UUID: 489b69a8203c7cf03eab7cc8d69a442d5adae5fb
Title: Slightly wrong error message on 'wm attributes $w -junk'
Type: Bug Version: 8.6.11
Submitter: oehhar Created on: 2021-09-14 16:18:44
Subsystem: 23. Option Parsing Assigned To: fvogel
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2021-09-15 19:06:32
Resolution: Fixed Closed By: fvogel
    Closed on: 2021-09-15 19:06:32
Description:

Dear Tk group,

very minor issue. The following command gives the error message 'wrong # args', while 'wrong attribute '-toplevel' would be correct:

% wm attributes . -toplevel
wrong # args: should be "wm attributes window ?-alpha ?double?? ?-transparentcolor ?color?? ?-disabled ?bool?? ?-fullscreen ?bool?? ?-toolwindow ?bool?? ?-topmost ?bool??"

Thank you, Harald

User Comments: fvogel added on 2021-09-15 19:06:32:
Merged to core-8-6-branch and trunk.

oehhar added on 2021-09-15 08:37:36:
Will you merge the patch or shall I do that?

Thanks,
Harald

oehhar added on 2021-09-15 08:36:57:

Thank you, Francois. The side issues are minor and may wait for release testing time, as other similar things will show-up.

THanks, Harald


fvogel added on 2021-09-15 08:25:08:
Thanks, it was a very low hanging fruit.

Regarding the side issues you mention please file new tickets so that they can be addressed.

oehhar added on 2021-09-15 07:10:29:

Dear Francois, you are really amazing, light-speed fix, thank you.

I tested it and it works great. Test suite is clean,only unrealted test textTag-18.1 fails.

This may directly be merged.

Thank you and best regards, Harald

---- Notes on Compilation ---

There are some interesting unrelated outputs when compiling with MS-VC6 on 32 bin Windows (TK_WIN_VERSION should be 8.6.11.0, no)?:

...
winMain.c
  0 '@MACHINE@' => 'X86'
  1 '@TK_WIN_VERSION@' => '8.6.0.0'
 
...

tkWinFont.c
C:\test\tk8.6.11_bug-8112c25a32f6804f_wm_attribute_error_message_correction\win\..\win\tkWinFont.c(1500) : warning C4761: integral size mismatch in argument; conversion supplied
C:\test\tk8.6.11_bug-8112c25a32f6804f_wm_attribute_error_message_correction\win\..\win\tkWinFont.c(1522) : warning C4761: integral size mismatch in argument; conversion supplied

Jan fixes those normally before a release...


fvogel added on 2021-09-14 19:43:18:

This is a Windows issue only. Both Linux and macOS get the error message right.

I have committed a fix in a bugfix branch, please see [8112c25a32].