Tk Source Code

View Ticket
Login
Bounty program for improvements to Tcl and certain Tcl packages.
Tcl 2019 Conference, Houston/TX, US, Nov 4-8
Send your abstracts to [email protected]
or submit via the online form by Sep 9.
Ticket UUID: 44e92d896eb31b8c6a6bca99f0a381bd4d4a1751
Title: reworked textDisp.test : font agnostic
Type: Patch Version: revised_text
Submitter: bll Created on: 2017-07-09 15:16:46
Subsystem: 18. [text] Assigned To: fvogel
Priority: 5 Medium Severity: Minor
Status: Open Last Modified: 2018-10-07 09:39:02
Resolution: None Closed By: nobody
    Closed on:
Description:
Attached find a new textDisp.test.

Many of the tests have been rebuilt to be font agnostic so that they will work on all platforms, and should also work with a different fixed width font.

Tests involving scroll positioning have not been rebuilt as yet.

The original textDisp.test has many values hard-coded.

In some cases the resulting hard-coded values were determined by using the return values from the test, resulting in an invalid self-referential test.

In some cases, tests were updated and "fixed" by plugging in the return values from the test, again resulting in invalid self-referential tests.

In some cases, the assumption was that the differences were due to font differences between the machines, and marked as such, where in fact the code or the test was buggy.

Any test still marked with the 'textfonts' constraint is suspect.

Test 24.11.1 works on Mac OS X, appears to be buggy on Linux and Windows.
Test 27.10 fails on all platforms (there is plenty of room for the numeric 
alignment on the first line, but the calculation for space needed is incorrect).
Test 27.11 has not been rebuilt, as I don't know what it is supposed to 
be testing.

Test 27.5 has differences between windows and Linux/Mac OS X and has been
left marked with 'textfonts' for the time being.
User Comments: bll added on 2017-08-16 15:24:25:
Current font agnostic textDisp.test suite updated (attachment).
27.8 may need fixing later.
27.10.1 is added.
Still need a test to make sure wrapping only wraps to the next line.

Oops...left some debug in, will re-attach.

gcramer added on 2017-07-15 15:35:03:
I think that this is an important improvement, looks very good.

When I have time I will examine why the test cases 24.11.1 and 27.10 are failing. (Currently I'm busy with a bigger release of application Scidb.)

fvogel added on 2017-07-12 18:38:48:
I have tried the proposed textDisp.test on Windows and on Linux Debian 8.

On both platforms results are as reported by the OP (Brad).

Gregor, what's your opinion on this proposal please?

Attachments: