Tk Source Code

With an un-gridded, un-placed, un-packed window, [grid info] and [place info] return "" but [pack info] returns an error:

% package require Tk
8.6.9
% frame .f
.f
% grid info .f
% place info .f
% pack info .f
window ".f" isn't packed
%

This looks inconsistent.

Note that this inconsistency is enforced in the test suite:

• the behavior of [pack info] in this case is tested by pack-17.2 (an error is the expected result)
• the behavior of [grid info] in this case is tested by grid-5.4 (the empty string is the expected result)
• the behavior of [place info] in this case is not tested

Great. As complementary info to this ticket: all three cases now return the empty string. This is now documented.

Thanks to the team! Harald

Many thanks to Jan for the fix and to Serhiy for the review! Merged to main by commit [ebe87fbf]. Removed the unfinished sentence from doc/place.n and added a test for the case "content without a container", as suggested by Serhiy.

Due to the change in the functionality of pack, no backport to core-9-0-branch or core-8-6-branch is planned.

Returning an empty string from grid info and place info for an unmanaged window was not documented, so an alternative solution to make all three commands return an error should also be considered. Either way it is an incompatible change, which I would not backport to 8.6 and 9.0.

Review of the branch:

• doc/place.n: an unfinished sentence "If the " is left after the new text.
• place-9.13 tests a window that was never placed, which already returned an empty string. The new case in place info (content without a container) is not tested.

Proposed fix [320e533d8dba4c6a|here]

Anyone who would like to review?