Tk Source Code

View Ticket
Login
Ticket UUID: 0a0fae80cdb57aa857642930f3d1948d8c270d5b
Title: mac os : makefile fails if there are spaces in the pathname
Type: Bug Version: core-8-6-branch
Submitter: bll Created on: 2021-04-29 16:18:16
Subsystem: 83. Mac OS X Build Assigned To: jan.nijtmans
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2024-09-24 14:41:47
Resolution: Fixed Closed By: jan.nijtmans
    Closed on: 2024-09-24 14:41:47
Description:
The GNUmakefile does not handle spaces in the path correctly.

I happened to try with:
    /Volumes/VMWare Shared Folders/Users/bll/t/tcl-work/tcl/macosx
User Comments: jan.nijtmans added on 2024-09-24 14:41:47:

Fixed by 1b8a893ded5f2a9b0c70


bll added on 2021-04-29 18:17:16:
I don't know that I can fix this.   It needs a complete rewrite.

GNUmakefile changes directory to ../../build/Development, then runs the 
makefile from the original directory.  Which is probably why all that TOP_DIR
stuff is in the unix/Makefile.

This is rather backwards.  Usually staging operations specify a destination
directory for the objects, binaries and libraries.  More of a push operation.

GNUmakefile would need to be rewritten to push the files over to the staging
directories.

Or Makefile.in could be changed to support staging objects, libraries and binaries to alternate directories.  I've seen this with other packages.

I don't think the TOP_DIR is a common method.

bll added on 2021-04-29 17:29:55:
I have only looked at the unix/Makefile so far.
WIth the three attached patches, the build works using
 ../unix/configure and make -f Makefile

The main issue seems to be that there a lot of absolute paths in Makefile.in.
Not sure why that was done.  The attached files fix the Tcl build using
 ../unix/configure

I have not yet looked at GNUmakefile (though I know it does not work),
and I assume the same sorts of changes need to be made for Tk.

Assigning this ticket to Jan.
I will look at the Tcl GNUmakefile next.

bll added on 2021-04-29 16:45:00:
I can play around with it and see if I get anywhere.

marc_culler (claiming to be Marc Culler) added on 2021-04-29 16:33:57:
I just noticed that too.  I had "Macintosh HD" in the path.  Probably it
just needs a couple of quotation marks.  Do you think you could provide a
patch?

Attachments: