Tk Source Code

Signed-off-by: Pat Thoyts <[email protected]> check-in: 66b19d9c user: patthoyts tags: trunk

Added additional flags to the vsapi element engine to enable specifying the system metrics to use when calculating the size of certain elements. This was being done already for the XP theme but the scripted definitions using the vsapi engine for vista/win7 could not use such flags. This fixes scrollbars not reflecting the users configured scrollbar size.

Reported-by: Mark Garvey <[email protected]> Signed-off-by: Pat Thoyts <[email protected]> check-in: 13e1965a user: patthoyts tags: trunk

If a button is disabled while the state is pressed, then the release event handler did not remove the pressed state. Modified the handler to always remove the pressed state while only calling invoke if !disabled.

Reported-by: Thomas MENEZ <[email protected]> Signed-off-by: Pat Thoyts <[email protected]> check-in: d36ac26e user: patthoyts tags: trunk

The fix for [Bug 2009788] prevented a crash but causes windows to be lost if their parent is unmapped when [wm forget] is called. Added a test for this case and ensure that the parent window exists when we remap the child to its parent.

Reported-by: Koen Danckaert <[email protected]> Reported-by: Eric Boudaillier <[email protected]> Signed-off-by: Pat Thoyts <[email protected]> check-in: d6b1369e user: patthoyts tags: trunk

Commit f59e9722e9 changed tearoff menu windows to be transient toolwindow toplevels. However the hidden menu hierarchy confuses the toplevel search when the menu being torn off is a submenu and not a direct child of the menubar. This patch fixes the search to exclude these hidden menu windows.

Signed-off-by: Pat Thoyts <[email protected]> check-in: 7878ce5c user: patthoyts tags: trunk

The tkhtml widget doesn't set it's window class. The Windows implementation of the wm manage command checks to see if the contained window is actually a menu (looking for torn-off menus) by examining the class. This patch adds a check for a null class to avoid crashing as suggested.

Suggested-by: Eric Boudaillier <[email protected]> Signed-off-by: Pat Thoyts <[email protected]> check-in: 6c9715e8 user: patthoyts tags: trunk

* doc/tk_mac.n (new file): Description of OSX-specific functionality in Tk, contributed by Kevin Walzer. * doc/button.n, doc/font.n, doc/menu.n: Noted which parts of these commands are intentionally not fully supported on OSX.

* generic/tkInt.decls (TkDrawAngledTextLayout,TkDrawAngledChars,...): Expose angled text API for Emiliano Gavilan. Still only in internal stub table.

* changes: Updates for 8.6b2 release.

* win/Makefile.in (genstubs): [Tcl Bug 3082049]: Typo.

* generic/tkImgPhoto.c (Tk_PhotoPutBlock, Tk_PhotoPutZoomedBlock): [Bug 3078902]: Ensure that zero-dimensioned data blocks cause no changes at all instead of causing a hang.

* library/bgerror.tcl: [Bugs 3046742,3046750]: Improve keybindings for the background error dialog, and allow the use of the window manager controls for closing it (where supported). The Escape key now causes all remaining background error messages in the queue to be dropped.

* unix/Makefile.in: add valgrind target * unix/configure, unix/tcl.m4: SHLIB_LD_LIBS='${LIBS}' for OSF1-V*. Add /usr/lib64 to set of auto-search dirs. [Bug 1230554] (SC_PATH_X): Correct syntax error when xincludes not found.

* win/Makefile.in (VC_MANIFEST_EMBED_DLL VC_MANIFEST_EMBED_EXE): * win/configure, win/configure.in, win/tcl.m4: SC_EMBED_MANIFEST macro and --enable-embedded-manifest configure arg added to support manifest embedding where we know the magic. Help prevents DLL hell with MSVC8+.

* generic/tkText.c (DumpLine): s/segPtr->size/currentSize/ throughout, but particularly in if lineChanged block where segPtr may no longer be valid. [Bug 3053347]

* win/Makefile.in (%.${OBJEXT}): better implicit rules support

* unix/configure: regen with ac-2.59 * unix/configure.in, unix/Makefile.in: * unix/tcl.m4 (AIX): remove the need for ldAIX, replace with -bexpall/-brtl. Remove TK_EXP_FILE (export file) and other baggage that went with it. Remove pre-4 AIX build support.

* changes: Updates for 8.6b2 release.

* library/button.tcl (::tk::CheckEnter): use uplevel set instead of set :: to work with other var resolvers (itcl). [AS Bug#87409]

* generic/tkImgGIF.c (StringWriteGIF): Added ability to write a GIF to a string (as a byte array, of course) following comments on c.l.t by Aric Bills. Also improved readability of some of the function and field names in this file.

Simplifications enabled by previous change:

* TkCreateBindingProcedure() and associated machinery no longer needed. * TkBindDeadWindow() no longer needed. * TK_DEFER_MODAL_LOOP and associated machinery no longer needed. * Tests related to C binding procedures no longer needed.

* library/text.tcl (TextCursorInSelection): [Patch 2585265]: Make it so that pressing delete or backspace when the primary selection does not include the insertion cursor does not cause the deletion of the inserted text.

* win/tkWinX.c (HandleIMEComposition): [Bug 2992129]: Ensure that all places that generate key events zero them out first; Tk relies on that being true for the generic parts of the fix for Bug 1924761.

* generic/tk.h: Bump patchlevel to 8.6b1.2 to distinguish * library/tk.tcl: CVS snapshots from earlier snapshots as well * unix/configure.in: as the 8.6b1 and 8.6b2 releases. * win/configure.in:

* unix/configure: autoconf-2.59 * win/configure:

* library/button.tcl (CheckInvoke, CheckEnter): [Patch 1530276 redux]: Apply a bit more care to ensure that things continue to work correctly even when there is no -selectcolor defined.

* generic/tkImgPNG.c (ReadIDAT, DecodePNG): Move the check for overall termination of the compressed stream until after the final IDAT has been read, so that multi-segment images will work right. Reported by Andy Goth on the Wiki.

* generic/tkImgPNG.c (WriteIDAT): [Bug 2984787]: Use the correct flushing semantics when handling the last data from the image. Without this, many PNG readers (notably including Firefox) refuse to show the image and instead complain about errors. (ReadIDAT): Added sanity checks to ensure that when we've got bad data of the sorts of forms we were previously generating, we detect it and error out rather than silently failing. (WriteExtraChunks): New function to write in some basic metadata.

* generic/tkImgPhoto.c (ImgPhotoCmd): [Bug 2983824]: Use the file extension to guess the output format to use if one isn't specified.

* unix/tkUnixRFont.c (GetFont): [Bug 2978410]: Do not use non-constant initializers for structures, since HP-UX cc doesn't like it.

* unix/configure.in, unix/Makefile.in: [Bug 2965133]: Get rid of the spurious NONE and some pointless quotes that were causing problems with building Tk on OSX. Overall bug might not yet be solved.

* library/entry.tcl: [Bug 2971663]: Make the <Up> and <Down> keys * library/ttk/entry.tcl: explicitly do nothing, since Tk-on-Cocoa will generate (invisible zero-width) characters for them otherwise. The explicitly empty bindings are harmless on other platforms.

* generic/tkText.c (DumpLine): [Bug 2968379]: When peers are about, there can be unnamed marks present during a dump. Ignore them as they will just be for the peers' insert and current marks, which aren't very important.

* generic/tkPlatDecls.h: Correct broken 2886635 fix. [Bug 2965600]

When the pointer moves to another entry from a cascade entry the sub-menu should popdown. This is how other menus on X11 work today. This effect will not be used if the user has configured ClickToFocus to maintain the previous Tk menu effects. check-in: 97932211 user: patthoyts tags: trunk

(Translation for LM: that means "3X faster!") check-in: 6e607dab user: jenglish tags: trunk

Modern unix window managers use a set of window properties to give hints as to the purpose of a toplevel window. They then use these hints to apply various animation and decoration options based on the type (dialog, menu, tooltip and more).

This patch adds a [wm attributes $w -type] option to control and read the type hint and makes use of this for the ttk::combobox and the dialogs raised from the Tk library scripts.

Signed-off-by: Pat Thoyts <[email protected]> check-in: 93a297dd user: patthoyts tags: trunk

Tk is the only toolkit to continue the Motif scheme of anchoring a Help menu to the extreme right of the menubar. This patch disables the special handling of the .help menu so that the help menu will be grouped with the other menu items as is common with other toolkits.

The old behaviour can be restored by setting the option *Menu.useMotifHelp to true or by calling 'tk::classic::restore menu'.

Signed-off-by: Pat Thoyts <[email protected]> check-in: 6821c287 user: patthoyts tags: trunk

This patch makes Tk menus on unix follow mouse motion in the same way Windows and GNOME menus follow the mouse. Once a menubar dropdown has been activated, moving the mouse to another menubar button or cascade item will activate the dropdown without needing another click.

The previous behaviour can be restored by setting the *Menu.clickToFocus option true or by calling 'tk::classic::restore menu' if this is preferred.

Signed-off-by: Pat Thoyts <[email protected]> check-in: 73a6d046 user: patthoyts tags: trunk

Multiple edits have peverted the original meaning of the phrase 'image file data' to reference a filename option that does not exist. check-in: ef621874 user: patthoyts tags: trunk

The standard for Windows and Gtk+ is that the <Return> binding invokes the button that currently has the keyboard focus. This can be seen in tk_messageBox which implements this. This patch implements this feature and also makes use of the tk grab utility functions to replace the grab handling code. check-in: 8f0a215f user: patthoyts tags: trunk

This patch by Anton Kovalenko adds support for the Windows system-wide UI setting that prevents accelerators being underlined unless the Alt key is pressed.

Modified to support the system keyboard cues flag and to handle dynamic changes to the system parameters by the user. check-in: 1f427626 user: patthoyts tags: trunk

The torn-off menu entries do not activate except immediately over the label or icon. If the window containing the torn-off menu is expanded then a lot of dead space may be created, including the cascade arrow. This patch fixes this making the whole width for any menu entry capable of activation when the pointer hovers over the item. check-in: c613aa58 user: patthoyts tags: trunk

* generic/tkConfig.c: Added another dimension of refCounting to the * generic/tkInt.c: "option" Tcl_ObjType to improve memory troubles * generic/tkObj.c: detailed in [Bug 2492179]. Also removed registration of the "option" Tcl_ObjType. *** POTENTIAL INCOMPATIBILITY *** for callers of Tcl_GetObjType("option") which must now handle a NULL return.

+ Where possible, replace [a; update; b] with [a ; after 0 b]. + Where not possible, use [update idletasks] instead of full [update]. + Use [after 0] in favor of [after idle] for delayed work, to reduce likelihood of reentrancy issues in [update idletasks]. check-in: fca757cb user: jenglish tags: trunk

* generic/tkPlatDecls.h: Restore C++ friendliness to the tkPlatDecls.h header file, which we insist extensions #include to gain access to the Tk_*HWND*() routines. [Bug 2886635].

* unix/Makefile.in: Remove $(PACKAGE).* and prototype from the `make distclean` target. Completes 2009-10-20 commit.

* unix/Makefile.in: Compiling Tk no longer requires header files * win/Makefile.in: from the TCL_PLATFORM DIR. Baby step in pursuit of [Bug 1712098].

* generic/tkMenuDraw.c (TkPostSubmenu): Fix reposting of submenu in * win/tkWinMenu.c (TkWinHandleMenuEvent): torn off Windows menu. [Bug 873613] (DrawMenuEntryArrow): Draw Win menu arrow after being torn off. [Bug 873608]

* generic/tkFocus.c: fix potential null dereference flagged by clang * generic/tkMenu.c: static analyzer. * generic/tkTextBTree.c: * generic/tkTextDisp.c: * generic/tkTextIndex.c:

* generic/tkConsole.c: silence false positives from clang static * generic/tkTest.c: analyzer about potential null dereference. * generic/tkText.c: * generic/tkTextBTree.c: * generic/tkTextTag.c: * generic/tkVisual.c:

* generic/tkInt.h: Annotate Tcl_Panic as noreturn for clang static analyzer in PURIFY builds, replacing preprocessor/assert technique.

* carbon/Wish.xcode/project.pbxproj: remove references to obsolete * carbon/Wish.xcodeproj/project.pbxproj: prolog.ps file.

* unix/configure: autoconf-2.59

* macosx/Wish.sdef (new file): Install and enable sdef file * macosx/Wish-Info.plist.in: into Wish application bundle, * macosx/Tk.xcode/project.pbxproj: describing TkAqua apple event * macosx/Tk.xcodeproj/project.pbxproj: support for use by AppleScript. * unix/Makefile.in: (replaces functionality of * unix/configure.in: 'aete' resource removed with Cocoa port & fixes AppleScript issues reported on tcl-mac)

* macosx/tkMacOSXHLEvents.c (ScriptHandler): Fix "do script" apple * carbon/tkMacOSXHLEvents.c (ScriptHandler): event handler issues on recent OS X releases by using AE coercion to 'utf8' for text data and to 'fsrf' for alias data. (reported by Youness Alaoui on tcl-mac)

* macosx/tkMacOSXDraw.c (TkMacOSX{Setup,Restore}DrawingContext): Disable window flushing during Tk drawing to avoid immediate flush of NSView-based native widgets on draw. (fixes drawing performance issue reported by Youness Alaoui on tcl-mac)

* macosx/tkMacOSXWindowEvent.c: Allow WM_DELETE_WINDOW handlers to prevent window closure by generating WM destroy event earlier (from window delegate's -windowShouldClose:). [Bug 2821084]

* generic/tkBind.c (HandleEventGenerate): Don't generate events for windows that don't exist yet (fixes TkAqua testsuite crash).

* macosx/tkMacOSXWm.c: Workaround for textured windows being draggable from opaque content areas. [Bug 2824538] (walzer)

* macosx/tkMacOSXDraw.c: Avoid exception in XCopyArea() when copying from toplevel that has never been mapped. (reported by Youness Alaoui on tcl-mac)

* unix/Makefile.in: Define NDEBUG in optimized (non- symbols) build to disable assert()s.

* macosx/tkMacOSXBitmap.c: Fix tk::mac::iconBitmap crash due to off-by-one ckalloc error. [Bug 2821318]

* library/demos/mclist.tcl: use native sort arrows with aqua theme.

* macosx/ttkMacOSXTheme.c: Update notebook tab appearance to * library/ttk/aquaTheme.tcl: modern L&F; adjust tab & notebook padding and tabmargins; correct appearance of selected tree header; add support for native tree header sort arrows via user1 state. [Patch 2819620]

* generic/tkInt.h: add assert macros for clang static analyzer and redefine Tcl_Panic to assert after panic in clang PURIFY builds.

* generic/tkImgPhInstance.c: small fixes to make clang static * generic/tkTextDisp.c: analyzer happier.

* generic/tkConfig.c: add clang assert for false positives * generic/tkUndo.c: from static analyzer.

* carbon/ (new directory): copy of current state of 'macosx' source directory, to preserve legacy TkAqua implementation based on Carbon API (with support for Mac OS X releases older than 10.5).

* unix/Makefile.in: add support for --enable-aqua=carbon * unix/configure.in: configure option (legacy fallback for pre-Mac OS X 10.5 releases).

* unix/configure: autoconf-2.59

If a checkbutton offvalue is the same as the tristate value we should use the off state in preference. (andrey gusev)

Vista and Windows 7 like to display larger icon sizes than previous versions although we do not include the largest suggested size (256x256) as that prevents building with msvc6. Both icons are rendered from SVG versions of the Tcl feather or the Wish lamp.

This ensures the icon can be drawn properly on various colour depth surfaces - in particular it fixes a problem with remote desktop and looks better in the vista task switching overlay. (cjmcdonald)

* unix/tcl.m4, unix/configure (SC_CONFIG_CFLAGS): harden the check to add _r to CC on AIX with threads.

* win/tkWinDialog.c (ChooseDirectoryValidateProc): no need to set cwd on selchange. Prevents delete of selected folder in dialog.

* win/tkWinDialog.c (Tk_ChooseDirectoryObjCmd): enable the new style choosedir that has a "New Folder" button, with ::tk::winChooseDirFlags override for new behavior. [Bug 2779910]

* unix/configure.in (Darwin): use Darwin SUSv3 extensions if available. * unix/configure: autoconf-2.59 * unix/tkConfig.h.in: autoheader-2.59

* library/demos/filebox.tcl: only show "Motif Style Dialog" checkbutton on X11 windowingsystem.

* library/demos/widget: GOOBE: use ttk::cursor

* library/demos/knightstour.tcl: fix knightstour demo not running from interactive wish.

* library/console.tcl (::tk::ConsoleInit): remove redundant TkAqua Quit menu item.

* generic/tkPointer.c (Tk_UpdatePointer): use all 5 buttons.

* generic/tkMenu.c (PostProcessEntry): delay call to TkpConfigureMenuEntry() until all menu entry attributes are setup.

* library/menu.tcl (::tk::MbPost): fix error thrown in y position computation with indicatoron.

* generic/tkMenubutton.c: s/DEF_BUTTON_JUSTIFY/DEF_MENUBUTTON_JUSTIFY/

* generic/tkUtil.c (TkBackgroundEvalObjv): use Tcl_BackgroundException.

* generic/tkBind.c (HandleEventGenerate): ensure window exists before generating an event for it (fixes testsuite crash).

* generic/tkTextBTree.c (TkBTreeDeleteIndexRange): add bounds check to startEnd array access (fixes testsuite crash).

* tests/unixFont.test: only use xlsfonts with X11 windowingsystem.

* win/tcl.m4, win/configure: Check if cl groks _WIN64 already to avoid CC manipulation that can screw up later configure checks. Use 'd'ebug runtime in 64-bit builds.

* win/configure.in, win/configure: align better with tcl version. Ensures finding correct CPP for Win64.

* generic/tkImgPhInstance.c: fix numerous leaks discovered with the * generic/tkMenu.c: Mac OS X Instruments.app Leaks tool. * generic/tkText.c: * generic/tkTextImage.c: * generic/tkTextIndex.c: * generic/tkUndo.c: * generic/tkUtil.c: * generic/ttk/ttkFrame.c: * macosx/tkMacOSXWm.c:

* generic/tk.h: Bump patchlevel to 8.6b1.1 to distinguish * library/tk.tcl: CVS snapshots from the 8.6b1 and 8.6b2 releases. * unix/configure.in: * win/configure.in:

* unix/configure: autoconf-2.59 * win/configure:

* win/rules.vc: small bug not setting SYMBOLS macro fixed.

* changes: Updates for 8.6b1 release.

* tests/clrpick.test: Eliminate duplicate test names. * tests/embed.test: * tests/text.test: * tests/textMark.test:

* README: Bump version number to 8.6b1 * generic/tk.h: * library/tk.tcl: * unix/configure.in: * unix/tk.spec: * win/configure.in:

* unix/configure: autoconf-2.59 * win/configure:

* library/msgs/de.msg: Updated German messages. Thanks to Ruediger Haertel. [Patch 2442309].

TIP #338 IMPLEMENTATION

* doc/Tk_Main.c: Removed the last two '#include "tclInt.h"'. * generic/tkMain.c: Tk is now limited to Tcl's public interface. * macosx/tkMacOSXInit.c:

* generic/tkInt.h: Turn [tk] into an ensemble (thoyts, steffen) * generic/tkBusy.c: * generic/tkCmds.c: * generic/tkWindow.c:

* macosx/tkMacOSXInit.c (TkpInit): unconditionally show Tk console if TK_CONSOLE env var is set.

TIP 337

* generic/tkBind.c: Updated callers of Tcl_BackgroundError() * generic/tkCanvas.c: to use the new routine * generic/tkEntry.c: Tcl_BackgroundException() as appropriate. * generic/tkImgBmap.c: * generic/tkListbox.c: * generic/tkSelect.c: * generic/tkTextDisp.c: * generic/tkTextWind.c: * macosx/tkMacOSXHLEvents.c: * macosx/tkMacOSXMenu.c: * macosx/tkMacOSXMenus.c: * macosx/tkMacOSXScale.c: * macosx/tkMacOSXWindowEvent.c: * unix/tkUnixScale.c: * unix/tkUnixWm.c: * win/tkWinButton.c: * win/tkWinMenu.c: * win/tkWinScrlbr.c: * win/tkWinWm.c:

(More remain in other files; will get to those later). check-in: a42da439 user: jenglish tags: trunk

* tests/unixSelect.test: Revise the unixSelect-1.* tests so that they test the ability of Tk's selection mechanism to faithfully pass valid Tcl values without corruption, and stop testing details of Tcl's internal encoding scheme. With this change, the Tk test suite no longer uses the identity encoding or [string bytelength].

Although dkf's solution (simply adding a type cast) is correct as well, changing the return value (as das suggested) has the advantage that all Tk_OptionPrintProc implementations don't need a type cast any more in its code. This makes all those functions robust against the -Wwrite-strings warning option.

Further on, the customPtr field of Tk_ConfigSpec can be a constant, without any danger of source incompatibility. check-in: bb3ffd49 user: nijtmans tags: trunk

* win/tkWinTest.c: Revise [testclipboard] to form that * tests/winClipboard.test: handles encodings. [Bug 2191960] * tests/constraints.tcl: [tcltest::bytestring] no longer used.

* README: Bump version number to 8.6a4 * generic/tk.h: * library/tk.tcl: * unix/configure.in: * unix/tk.spec: * win/configure.in:

* unix/configure: autoconf-2.59 * win/configure:

*** 8.6a3 TAGGED FOR RELEASE ***

* changes: Updates for 8.6a3 release.

* tests/entry.test: Restore test naming consistency with Tk 8.5. * tests/listbox.test: Remove some more dependency on precision in * tests/spinbox.test: test results.

* generic/tkListbox.c: Make literal return values consistent with those generated by Tcl_PrintDouble().

* tests/entry.test: Restore test naming consistency with Tk 8.5. * tests/listbox.test: Remove some more dependency on precision in test results.

* unix/tcl.m4: fix for bug [2073255] * unix/configure: regenerated

* tests/textDisp.test (textDisp-16.34): Update test that tested string equality of double values based on an assumption of tcl_precision==12. Test now does its own formatting.

* tests/scrollbar.test: Revised testing of the cget subcommand so that it tests consistency with the configure subcommand and not agreement with a hardcoded value that will change as tastes in GUIs evolve.

* unix/tkUnixWm.c: Restored consistency of error messages from * macosx/tkMacOSXWm.c: [wm iconphoto] with the test suite and across * tests/unixWm.test: all platforms. [Bug 2021443]

* tests/canvText.test (canText-17.1): Update expected result to match revised PostScript output due to more predictable formatting of floating point values.

* unix/tkUnixWm.c: Restored consistency of error messages from * macosx/tkMacOSXWm.c: [wm iconphoto] with the test suite and across all platforms. [Bug 2021443]

* tests/wm.test: Update expected error messages from [wm iconphoto] to match the new message. [Bug 2021443]

* generic/tk.h: Dropped use of _ANSI_ARGS_ macro to preserve * generic/tkSelect.h: Tk's TCL_NO_DEPRECATED build.

* unix/tkConfig.sh.in: Added @XFT_LIBS@ to the definition of TK_LIBS to avoid link failures when a "big wish" program links against a --disable-shared build of libtk. (Discovered building expectTk).

* generic/tkImgPhoto.c: Changed TclStack* calls to ck* calls so that we don't create new dependencies on Tcl internals.

* unix/tkUnixPort.h: Removed #include of tclInt.h that has been * win/tkWinPort.h: disabled for three years. If we needed this we'd have noticed by now.

* README: Bump version number to 8.6a3 * generic/tk.h: * library/tk.tcl: * unix/configure.in: * unix/tk.spec: * win/configure.in:

* unix/configure: autoconf-2.59 * win/configure: