Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
286 check-ins using file generic/tkCanvas.c version d003478f
2024-03-13
| ||
21:24 | NotifyNormal was wrongly passed in a detail field while it is a value for the mode field. Replacing by NotifyAncestor is a correct detail field (and this does not change the behavior because both NotifyNormal and NotifyAncestor values happen to be zero). check-in: 1dac28ab user: fvogel tags: bug-22349fc78a | |
2024-03-10
| ||
18:04 | One more use of proc create_and_pack_frames. check-in: cb6c8177 user: fvogel tags: bug-22349fc78a | |
17:59 | Enlarge windows and widgets in event-9.* in order to be more independent of the height of the top decoration of toplevel windows on macOS with XQuartz. check-in: 8e55f77c user: fvogel tags: bug-22349fc78a | |
11:57 | Formatting. check-in: 185c9e86 user: fvogel tags: bug-22349fc78a | |
2024-03-09
| ||
17:47 | Remove useless statements. check-in: 60fbc1fa user: fvogel tags: bug-22349fc78a | |
17:45 | Remove tests event-9.1 and event-9.2 since they are (now better) covered by event-9.13. check-in: bf6234fc user: fvogel tags: bug-22349fc78a | |
10:48 | Formatting. check-in: 4bfe17ad user: fvogel tags: bug-22349fc78a | |
10:43 | More comments. check-in: 8c39ff15 user: fvogel tags: bug-22349fc78a | |
10:40 | Prevent hang in event-9.15 on Linux by removing stuff no longer needed since we're using _pause now instead of update. check-in: d569f3a7 user: fvogel tags: bug-22349fc78a | |
09:41 | Don't use the root (.) toplevel for the new tests. This resolves the hang in the test suite during focusTcl-2.1. check-in: b16759f7 user: fvogel tags: bug-22349fc78a | |
08:58 | Use proc create_and_pack_frames where possible. check-in: 5cc592dd user: fvogel tags: bug-22349fc78a | |
08:45 | Adjust comments. check-in: 5732961e user: fvogel tags: bug-22349fc78a | |
2024-03-08
| ||
21:40 | Now event.test passes on Windows (when run standalone only). check-in: b1256d26 user: fvogel tags: bug-22349fc78a | |
20:54 | Indentation is 4 spaces. check-in: 4f5222a6 user: fvogel tags: bug-22349fc78a | |
20:50 | Remove proc init_pos check-in: 62089756 user: fvogel tags: bug-22349fc78a | |
20:45 | Indentation is 4 spaces. check-in: 08627227 user: fvogel tags: bug-22349fc78a | |
20:43 | Remove tkWithNotifyInferior, clean proc at end of the file, and make proc initpos unhang as an emergency temporary measure. check-in: d3a50a9c user: fvogel tags: bug-22349fc78a | |
20:30 | Add event tests from [22349fc78a]. Not functional yet. check-in: e1d55198 user: fvogel tags: bug-22349fc78a | |
2024-03-07
| ||
20:08 | merge core-8-6-branch check-in: 3eb956ad user: fvogel tags: bug-22349fc78a | |
20:06 | Fix [47d4f29159]: Ignored binding scripts for events with detail field NotifyInferior. Patch from Erik Leunissen. check-in: 8aee368f user: fvogel tags: core-8-6-branch | |
2024-03-06
| ||
14:15 | typo's in changes file (backported) check-in: 423cb861 user: jan.nijtmans tags: core-8-6-branch | |
2024-02-29
| ||
22:09 | merge core-8-6-branch check-in: 70572fed user: fvogel tags: less_tests_constraints | |
2024-02-28
| ||
21:22 | merge release check-in: ade24c0a user: dgp tags: core-8-6-branch | |
15:17 | Fixes to changes file. (Thanks Christopher Chavez!) Closed-Leaf check-in: e987bb51 user: dgp tags: rc2, core-8-6-14-rc, core-8-6-14 | |
2024-02-25
| ||
21:29 | Again... check-in: bffcc206 user: fvogel tags: bug-47d4f29159 | |
21:29 | Fix spaces. check-in: fbbf1f4c user: fvogel tags: bug-47d4f29159 | |
21:27 | Let this bugfix branch build and test at Github Actions. check-in: cef684da user: fvogel tags: bug-22349fc78a | |
21:27 | Let this bugfix branch build and test at Github Actions. check-in: 29c05981 user: fvogel tags: bug-47d4f29159 | |
20:27 | Fix [47d4f29159]: Ignored binding scripts for events with detail field NotifyInferior. Patch from Erik Leunissen. check-in: 58a10b35 user: fvogel tags: bug-47d4f29159 | |
20:21 | Fix [22349fc78a]: Incorrect crossing events upon destruction of the pointer window under MS Windows. Patch from Erik Leunissen. check-in: 04732899 user: fvogel tags: bug-22349fc78a | |
2024-02-22
| ||
16:01 | Added a missing bugfix to changes file. check-in: 4acec597 user: csaba tags: rc1, core-8-6-14-rc | |
2024-02-21
| ||
20:46 | rest of the changes check-in: 9a11a991 user: dgp tags: core-8-6-14-rc | |
18:00 | Addition of changes continues... check-in: 702bce76 user: dgp tags: core-8-6-14-rc | |
15:58 | merge 8.6 check-in: 06061eb5 user: dgp tags: core-8-6-14-rc | |
2024-02-16
| ||
15:16 | Fix [82d5a93a46]: 8.6 Documentation/comment typo fixes check-in: 71f581f3 user: jan.nijtmans tags: core-8-6-branch | |
2024-02-14
| ||
20:57 | Work in progress updating changes file for Tk 8.6.14 check-in: de0f97e4 user: dgp tags: core-8-6-14-rc | |
19:20 | merge 8.6 check-in: 9501496c user: dgp tags: core-8-6-14-rc | |
2024-02-13
| ||
22:04 | Merge core-8-6-branch. This is actually a no-op since branch less_tests_constraints already contained [9deacbbe] which was recommitted in core-8-6-branch as [c8315f40]... check-in: 6c694ed0 user: fvogel tags: less_tests_constraints | |
15:07 | Fix compilation warning with -DDEBUG_FONTSEL check-in: c8315f40 user: jan.nijtmans tags: core-8-6-branch | |
2024-02-12
| ||
16:20 | Merge 8.6 check-in: 5f39d044 user: jan.nijtmans tags: less_tests_constraints | |
16:16 | "eval destroy" -> "destroy {*}" in testcases/demo's check-in: 47589603 user: jan.nijtmans tags: core-8-6-branch | |
2024-02-09
| ||
14:19 | merge 8.6 check-in: c8309a4a user: dgp tags: core-8-6-14-rc | |
2024-02-08
| ||
20:38 | Fix [57b821d2db]: text index {insert wordstart} fails at 0 and 1 word start positions. check-in: 9742700a user: fvogel tags: core-8-6-branch | |
2024-02-07
| ||
20:27 | Fix previous commit. Closed-Leaf check-in: eea9fab5 user: fvogel tags: bug-57b821d2db | |
19:20 | merge 8.6 check-in: d64ba250 user: dgp tags: rc0, core-8-6-14-rc | |
2024-02-06
| ||
20:53 | Build binaries at GitHub. check-in: 2bdfc8bb user: fvogel tags: bug-57b821d2db | |
2024-02-05
| ||
20:13 | Add a link to the 'MARKS' section in text.n check-in: c21dbc13 user: fvogel tags: bug-57b821d2db | |
2024-02-03
| ||
17:46 | Expand coverage of textIndex-22.16 check-in: 841577fa user: fvogel tags: bug-57b821d2db | |
11:25 | The text widget does not need to be packed for test textIndex-22.16. check-in: a92a24b2 user: fvogel tags: bug-57b821d2db | |
11:05 | Fix [57b821d2db]: text index {insert wordstart} fails at 0 and 1 word start positions. check-in: e869047e user: fvogel tags: bug-57b821d2db | |
11:05 | Make textIndex-22.16 really fail. check-in: 76874248 user: fvogel tags: bug-57b821d2db | |
08:31 | Add test textIndex-22.16 demonstrating bug [57b821d2db]. Currently fails (expectedly). check-in: 79cae57f user: fvogel tags: bug-57b821d2db | |
2024-01-29
| ||
10:51 | Make test-cases work for UNIX/MacOS as well. check-in: edeb2274 user: jan.nijtmans tags: core-8-6-branch | |
2024-01-28
| ||
10:26 | Fix [9fa3e08243]: Ctrl-Arrow binding for spinbox: unknown option '-show'. check-in: 22669240 user: fvogel tags: core-8-6-branch | |
09:26 | Do the same for ttk::spinbox and ttk::combobox. This is not absolutely needed: there is no error triggering on <<NextWord>>/<<PrevWord>> because these widgets inherit the -show option from ttk::entry even if it does not really make sense for these types of widget. However it's better to do it for those widgets so that the behavior is consistent with Tk widgets, and in case people use -show with ttk::spinbox/combobox they would not be able to identify the words in the widget (see [2a32225cd1]). Closed-Leaf check-in: bbb4b981 user: fvogel tags: bug-9fa3e08243 | |
09:03 | Fix [9fa3e08243]: Ctrl-Arrow binding for spinbox: unknown option '-show'. check-in: e55cb6b7 user: fvogel tags: bug-9fa3e08243 | |
08:55 | Add tests demonstrating bug [9fa3e08243]: Ctrl-Arrow binding for spinbox: unknown option '-show'. For Tk, spinbox-25.3 fails (as expected). For Ttk, spinbox-11.2 does not fail because the ttk::spinbox inherits the -show option of the ttk::entry widget, event though it's not used nor documented for ttk::spinbox. (Note: tests numbering mirror their counterparts in entry.test). check-in: 00c6ff81 user: fvogel tags: bug-9fa3e08243 | |
2024-01-27
| ||
13:48 | Fix [8da7af2f8e]: slow widget creation if default font is not used. check-in: f45960ae user: fvogel tags: core-8-6-branch | |
10:38 | Install unifont package before running tests. check-in: c0db977d user: fvogel tags: less_tests_constraints | |
09:09 | Fix [7e5f72c9dd]: Test script option.test deletes file option.file3 in Tk distribution. check-in: 416368c3 user: fvogel tags: core-8-6-branch | |
08:04 | Remove instrumentation from font-44.2 since the test now passes at GitHub Actions on Linux without Xft, with xvfb. check-in: 413da431 user: fvogel tags: less_tests_constraints | |
2024-01-26
| ||
21:02 | Fix [7e5f72c9dd]: Test script option.test deletes file option.file3 in Tk distribution Closed-Leaf check-in: e259ac2d user: fvogel tags: bug-7e5f72c9dd | |
20:42 | Install fonts before running tests. check-in: 774b19d5 user: fvogel tags: less_tests_constraints | |
06:59 | Instrument font-44.2 failing (not a new failure, discovered when starting testing --disable-xft). Failure happens at GitHub Actions on Linux without Xft, with xvfb - not on my same setup. check-in: 7f92f163 user: fvogel tags: less_tests_constraints | |
2024-01-24
| ||
19:40 | merge 8.6 check-in: 4e8ae373 user: dgp tags: core-8-6-14-rc | |
2024-01-23
| ||
20:23 | Since we are here make font-15.1, font-15.2 and font-15.3 robust against previous fonts potentially used by the test suite. check-in: c120c687 user: fvogel tags: bug-8da7af2f8e | |
19:49 | merge core-8-6-branch check-in: 965e9cca user: fvogel tags: less_tests_constraints | |
14:17 | Stop building this branch (eventually) Closed-Leaf check-in: 61b28b8e user: jan.nijtmans tags: bug-026e2bb685 | |
12:10 | Fix [026e2bb685]: text tag sets bad relief, gets error, but bad relief is saved anyway. Continued fix check-in: d5bcba02 user: jan.nijtmans tags: core-8-6-branch | |
2024-01-22
| ||
21:50 | Fix typo check-in: da912fe2 user: fvogel tags: bug-8da7af2f8e | |
21:46 | Test suite hygiene - Let font-17.1 and font-18.1 be independent from previous tests (interaction was with config-4.47 and config-4.48). check-in: 07f1820b user: fvogel tags: bug-8da7af2f8e | |
21:35 | Update comments in tkText.h. Minor further tweaks Closed-Leaf check-in: fea60d43 user: jan.nijtmans tags: bug-026e2bb685-alt | |
20:46 | Implementation cleanup: We know that always internalPtr != NULL, and that the options handled are never saved/restored. check-in: 644ed6a6 user: jan.nijtmans tags: bug-026e2bb685-alt | |
09:18 | Use internal flag OPTION_NONNEG check-in: af71f03d user: jan.nijtmans tags: bug-026e2bb685-alt | |
2024-01-21
| ||
22:36 | Boolean uses -1 as value when not provided. Same for Relief and Justify check-in: f35f6481 user: jan.nijtmans tags: bug-026e2bb685-alt | |
22:16 | Implement the same for Boolean, Relief and Justify as well check-in: d3f69d94 user: jan.nijtmans tags: bug-026e2bb685-alt | |
21:26 | Alternative solution for [026e2bb685]: text tag sets bad relief, gets error, but bad relief is saved anyway check-in: 289a155a user: jan.nijtmans tags: bug-026e2bb685-alt | |
21:26 | Let this bugfix branch build and test at Github Actions. check-in: 10a4b886 user: fvogel tags: bug-8da7af2f8e | |
21:14 | Fix [8da7af2f8e]: slow widget creation if default font is not used check-in: d7b0c443 user: fvogel tags: bug-8da7af2f8e | |
17:30 | Adapt textTag-1.29 demonstrating that [026e2bb685] is not completely solved yet check-in: 042c281f user: jan.nijtmans tags: core-8-6-branch | |
2024-01-20
| ||
13:41 | Let this bugfix branch build and test at Github Actions. check-in: 3889aa75 user: fvogel tags: bug-026e2bb685 | |
13:40 | Implement a better solution built on the savePtr parameter of Tk_SetOptions. check-in: 507fdcab user: fvogel tags: bug-026e2bb685 | |
13:26 | Return to state [4c67cefe] (backout several commits). check-in: 8ad32a91 user: fvogel tags: bug-026e2bb685 | |
2024-01-19
| ||
08:51 | Update build scripts (backported from 8.7/9.0). Travis is no longer supported (probably won't even work any more). typo in tkMenubutton.h check-in: a8515bb7 user: jan.nijtmans tags: core-8-6-branch | |
2024-01-18
| ||
16:54 | Merge 8.6. No need to build this branch on Github any more check-in: 47292b2a user: jan.nijtmans tags: bug-026e2bb685 | |
2024-01-17
| ||
16:44 | More needed 13 -> 14 bumps check-in: 2b098a24 user: jan.nijtmans tags: core-8-6-14-rc | |
09:38 | Fix [026e2bb685]: text tag sets bad relief, gets error, but bad relief is saved anyway, remaining options. check-in: 0f5bf543 user: jan.nijtmans tags: core-8-6-branch | |
09:18 | Fix compiler warning on Windows check-in: df90f42d user: jan.nijtmans tags: core-8-6-branch | |
09:17 | Fix memory leak, and let's see what happens if we add lMargin2: Problem will be performance if we add a lot of these check-in: 592a36ae user: jan.nijtmans tags: bug-026e2bb685 | |
05:16 | Following previous commits, there is no need to initialize to INT_MIN anymore, therefore restore the old statement initializing to zero. check-in: 37c003c7 user: fvogel tags: bug-026e2bb685 | |
05:06 | Let this bugfix branch build and test at Github Actions. check-in: a9199dcd user: fvogel tags: bug-026e2bb685 | |
04:51 | Following previous commit, remove now useless statement. check-in: b4c3a74a user: fvogel tags: bug-026e2bb685 | |
04:45 | Restore -lmargin1 string value after an invalid value was specified. check-in: 65261e8a user: fvogel tags: bug-026e2bb685 | |
2024-01-16
| ||
22:32 | Handle the remaining options in a similar way check-in: 4c67cefe user: jan.nijtmans tags: bug-026e2bb685 | |
21:28 | (partial) fix for [026e2bb685]: text tag sets bad relief, gets error, but bad relief is saved anyway. -relief and -justify is working now, but other options hstill have the same problem check-in: 6ab21a0c user: jan.nijtmans tags: bug-026e2bb685 | |
01:09 | Bump to 8.6.14 for release check-in: 35457e6c user: griffin tags: core-8-6-14-rc | |
2024-01-14
| ||
21:22 | Fix [026e2bb685]: text tag sets bad relief, gets error, but bad relief is saved anyway check-in: 90a8df47 user: jan.nijtmans tags: core-8-6-branch | |
17:04 | merge core-8-6-branch check-in: 0afe4f52 user: fvogel tags: less_tests_constraints | |
2024-01-12
| ||
20:17 | Fix [737abf4523]: text widget has terrible performance with image create. check-in: bae491de user: fvogel tags: core-8-6-branch | |
2024-01-11
| ||
20:58 | Fix bug in previous commit. Closed-Leaf check-in: ed90c9b4 user: fvogel tags: bug-737abf45230 | |
07:24 | Modified implementation inspired by the revised text widget and proposal from Emiliano Gavilan. check-in: 17cf80d8 user: fvogel tags: bug-737abf45230 | |
2024-01-09
| ||
22:02 | Fix [b7abf0d817]: ttk::treeview shows O(n^2) destruction time check-in: 479e7b2d user: fvogel tags: core-8-6-branch | |
21:52 | Let this bugfix branch build and test at Github Actions. check-in: 0258e0c4 user: fvogel tags: bug-737abf45230 | |
21:40 | Adapt expected result of test textImage-1.19 following previous commit. This change is compliant with the documentation in text.n (section 'Embedded images'). check-in: 511c7ddd user: fvogel tags: bug-737abf45230 | |
21:38 | Fix [737abf4523]: text widget has terrible performance with image create. check-in: 55c3b394 user: fvogel tags: bug-737abf45230 | |
19:38 | Improvement in scrollbar.n. check-in: 6b2a4d7d user: csaba tags: core-8-6-branch | |
2024-01-08
| ||
22:30 | Fix and simplify Tk_FreeImage. Closed-Leaf check-in: 9030824a user: fvogel tags: bug-b7abf0d817 | |
21:21 | typo check-in: a7ff75ed user: jan.nijtmans tags: core-8-6-branch | |
2024-01-07
| ||
09:16 | Replace 'eval destroy ...' by 'destroy {*} ...' check-in: e4012c17 user: fvogel tags: less_tests_constraints | |
2024-01-06
| ||
22:28 | Let this bugfix branch build and test at Github Actions. check-in: 12ae5e63 user: fvogel tags: bug-b7abf0d817 | |
22:00 | Simplify Tk_FreeImage check-in: c2cdb45c user: fvogel tags: bug-b7abf0d817 | |
21:38 | Fix [b7abf0d817]: ttk::treeview shows O(n^2) destruction time check-in: a5ad9e81 user: fvogel tags: bug-b7abf0d817 | |
17:01 | USE_WIDECHAR_API isn't used anywhere. Comment fixes check-in: eb2d331c user: jan.nijtmans tags: core-8-6-branch | |
08:45 | Correction in documentation embedded in rules.vc check-in: aa895fef user: fvogel tags: core-8-6-branch | |
2024-01-05
| ||
09:00 | Fix [a9e637f1c8]: ttk::treeview does not show partial bottom row check-in: f32f7a24 user: jan.nijtmans tags: core-8-6-branch | |
2024-01-04
| ||
16:03 | No need for separate tktest manifest: just re-use the one from wish. Give tktest.exe a version-number check-in: a82ea6e1 user: jan.nijtmans tags: core-8-6-branch | |
15:59 | Fix [1ca3c8d9da]: nmake build with OPTS=static check-in: 1374b2d1 user: jan.nijtmans tags: core-8-6-branch | |
2024-01-03
| ||
20:50 | Better: generate tktest.res from a separate tktest.rc check-in: ff1a5283 user: jan.nijtmans tags: core-8-6-branch | |
20:34 | Add rule to generate "tktest.res" check-in: c2833a28 user: jan.nijtmans tags: core-8-6-branch | |
20:27 | "Check out" -> "CheckOut" check-in: 5bec5ad3 user: jan.nijtmans tags: core-8-6-branch | |
20:16 | Test OPTS=static (without staticpkg) too check-in: 9300093e user: jan.nijtmans tags: core-8-6-branch | |
15:39 | Possible fix for [1ca3c8d9da]: nmake build with OPTS=static check-in: dc10eade user: jan.nijtmans tags: core-8-6-branch | |
15:11 | try OPTS=static,staticpkg Windows build check-in: bde215b2 user: jan.nijtmans tags: core-8-6-branch | |
14:57 | Merge-mark check-in: a90fde5b user: jan.nijtmans tags: less_tests_constraints | |
14:52 | AllocFont() -> InitFont() in comments. Stolen from "less_tests_constraints" branch check-in: b194447b user: jan.nijtmans tags: core-8-6-branch | |
14:40 | Merge 8.6 check-in: eeb818ca user: jan.nijtmans tags: less_tests_constraints | |
14:37 | Fix [52df668390]: Measurement of control characters are wrong after measurement of characters that cannot be displayed by the given font check-in: 6fc75377 user: jan.nijtmans tags: core-8-6-branch | |
14:19 | unnecessary check for $last >= 0 check-in: 1f21cbe7 user: jan.nijtmans tags: core-8-6-branch | |
12:43 | Don't do a nmake build with OPTS=static (yet). See [1ca3c8d9da] check-in: 96a46054 user: jan.nijtmans tags: core-8-6-branch | |
01:33 | .. but prevent code duplication check-in: 58474794 user: jan.nijtmans tags: core-8-6-branch | |
2024-01-02
| ||
14:55 | Fix 2 (minor) compiler warnings on Windows check-in: 5d91303b user: jan.nijtmans tags: core-8-6-branch | |
2024-01-01
| ||
23:43 | missing ')' check-in: a7b4e779 user: jan.nijtmans tags: core-8-6-branch | |
23:37 | Keep menu.tcl/tearoff.tcl more in sync with 8.7 check-in: 9303b88e user: jan.nijtmans tags: core-8-6-branch | |
22:02 | Add --disable-shared windows build check-in: 9c0bab42 user: jan.nijtmans tags: core-8-6-branch | |
2023-12-31
| ||
15:16 | Update comments in unixFont-8.4, -8.6, -9.1 and -9.2: Character classification is gone since [1120dc4257], and GetControlCharSubst procedure is long gone as well. check-in: 29c0065b user: fvogel tags: less_tests_constraints | |
15:09 | Constrain unixFont-8.4 (nonPortable) and unixFont-8.6, -9.1 and -9.2 (withoutXft). Reasons are indicated in tests comments. check-in: 44ae9e71 user: fvogel tags: less_tests_constraints | |
2023-12-30
| ||
16:55 | Remove 3 failsOnXQuarz constraints since [52df668390] is fixed by the previous merge. check-in: 6ff5dc8f user: fvogel tags: less_tests_constraints | |
16:42 | merge branch bug-52df668390 check-in: 57fd8c96 user: fvogel tags: less_tests_constraints | |
16:28 | Fix [52df668390]: Measurement of control characters are wrong after measurement of characters that cannot be displayed by the given font. Closed-Leaf check-in: 02de74fa user: fvogel tags: bug-52df668390 | |
2023-12-26
| ||
14:12 | Fix [fec9e3879d]: Confusion regarding menu indexes "none" and {}. Also add some type-casts check-in: 9f8d8e42 user: jan.nijtmans tags: core-8-6-branch | |
00:30 | Fix [a9e637f1c8]: ttk::treeview does not show partial bottom row Closed-Leaf check-in: 8a8493a3 user: jan.nijtmans tags: bug-a9e637f1c8 | |
2023-12-22
| ||
16:45 | Fix [9c57421be8]: -relief strange behavior in scrollbar. Enhance Tcl_GetRelief() such that "interp" and "reliefPtr" are allowed to be NULL check-in: d7650b4e user: jan.nijtmans tags: core-8-6-branch | |
2023-12-20
| ||
12:01 | (cherry-pick): remove tkUnixDialog.c, since it's no longer used check-in: c44ee43d user: jan.nijtmans tags: core-8-6-branch | |
2023-12-18
| ||
22:27 | upload-artifact @3 -> @4 check-in: 6a3ea520 user: jan.nijtmans tags: core-8-6-branch | |
2023-12-16
| ||
08:52 | merge core-8-6-branch check-in: ad944490 user: fvogel tags: less_tests_constraints | |
2023-12-14
| ||
15:15 | Merge 8.6 Leaf check-in: 58f32512 user: jan.nijtmans tags: bug-c23f79ef96, bug-fde9dc2392 | |
12:58 | Add Tk_Window parameter to TtkSelectImage(). Not used yet check-in: 4c1667e1 user: jan.nijtmans tags: core-8-6-branch | |
10:56 | Merge 8.6 check-in: 53612921 user: jan.nijtmans tags: bug-c23f79ef96, bug-fde9dc2392 | |
2023-12-13
| ||
10:28 | There was a reason those 3 signatures were removed check-in: 0354549b user: jan.nijtmans tags: core-8-6-branch | |
2023-12-12
| ||
16:09 | Update keycode table (and documentation) to updated X11 headers check-in: 952c48a2 user: jan.nijtmans tags: core-8-6-branch | |
15:04 | Update to latest X11 headers check-in: 31d8e5eb user: jan.nijtmans tags: core-8-6-branch | |
13:03 | Backport some clean-up from 8.7 check-in: 6b85c82d user: jan.nijtmans tags: core-8-6-branch | |
11:54 | (cherry-pick)More adjustments to tests that failed on macOS Sonoma check-in: 5928318b user: jan.nijtmans tags: core-8-6-branch | |
2023-12-11
| ||
06:21 | More complete cleaning in ttk test image-3.1 check-in: fdcdf663 user: fvogel tags: bug-c23f79ef96, bug-fde9dc2392 | |
2023-12-10
| ||
13:53 | Better test suite hygiene in image-3.1 check-in: 72f80aad user: fvogel tags: bug-c23f79ef96, bug-fde9dc2392 | |
12:19 | Add non-regression test image-3.1 for [fde9dc2392]. check-in: d7784f60 user: fvogel tags: bug-c23f79ef96, bug-fde9dc2392 | |
11:41 | Simplify expected result calculation for frame-2.15 check-in: 78201759 user: fvogel tags: less_tests_constraints | |
11:39 | Remove superfluous constraint 'x11' on tests having constraint 'haveDISPLAY' since the latter already includes the former. check-in: 755df808 user: fvogel tags: less_tests_constraints | |
09:44 | Remove Androwish-specific test on #define check-in: 9f5cd983 user: fvogel tags: bug-c23f79ef96, bug-fde9dc2392 | |
2023-12-09
| ||
10:53 | Patch https://www.androwish.org/home/info/ccc996aeffde47f8 (fixes in ttk image management) from Christian Werner. Fixes bug [fde9dc2392]. check-in: 6de380f3 user: sbron tags: bug-c23f79ef96, bug-fde9dc2392 | |
10:18 | Fix [1d8b7124b6]: X11: Photo images not drawn correctly for 32-bit visuals. Patch from Christian Werner. check-in: a73ef1cb user: fvogel tags: core-8-6-branch | |
2023-12-06
| ||
19:12 | Increase delays so tests pass on macOS Sonoma. check-in: fb42a2db user: culler tags: core-8-6-branch | |
2023-12-04
| ||
14:51 | On UNIX, winPtr->window == 0 is as valid as any other windows ID check-in: 492e5337 user: jan.nijtmans tags: core-8-6-branch | |
2023-12-03
| ||
18:49 | Fix [fe942372aa]: Aqua: XPutImage() swaps red and blue channels. Patch from Christopher Chavez. check-in: 1877c045 user: fvogel tags: core-8-6-branch | |
16:23 | Add an update in visual-9.1 check-in: 66e803e4 user: fvogel tags: bug-c23f79ef96 | |
16:14 | Clean up handling of Apple FourCC Creator Codes - many thanks to Christopher Chavez for patches. check-in: 805f23c2 user: marc_culler tags: core-8-6-branch | |
15:53 | Add non-regression test visual-9.1 check-in: 776bdb0e user: fvogel tags: bug-c23f79ef96 | |
15:21 | Fix [40af63fa24]: Aqua: passing None to XMapWindow() should be fatal check-in: 63d02e8a user: jan.nijtmans tags: core-8-6-branch | |
13:48 | Remove useless statement. check-in: 96c61507 user: fvogel tags: bug-c23f79ef96 | |
13:45 | Better fix for Tcl error hanging the test suite during filebox.test (see previous commit). Patch from Christian Werner. check-in: a1c0b468 user: fvogel tags: bug-c23f79ef96 | |
09:54 | Fix hangs in filebox.test check-in: 01e397eb user: fvogel tags: bug-c23f79ef96 | |
2023-12-02
| ||
17:22 | Eliminate segfault in entry-7.1 ttk test. check-in: de479725 user: fvogel tags: bug-c23f79ef96 | |
14:56 | Fix test xmfbox-2.6 in accordance with the changes made in [7608b5e7]. check-in: 2e034b1d user: fvogel tags: bug-c23f79ef96 | |
14:44 | Fix error when applying one of the previous patches. check-in: 4269fdae user: fvogel tags: bug-c23f79ef96 | |
14:28 | Let this bugfix branch build and test at Github Actions. check-in: c07d0391 user: fvogel tags: bug-c23f79ef96 | |
14:26 | Fix formatting. check-in: f7fe5eb7 user: fvogel tags: bug-c23f79ef96 | |
14:12 | Fix error when applying one of the previous patches. check-in: 82780d5e user: fvogel tags: bug-c23f79ef96 | |
14:09 | Patch https://www.androwish.org/home/info/4979992f45ef6cb4 (another attempt to fix ttk object caching) from Christian Werner. check-in: 65565dba user: fvogel tags: bug-c23f79ef96 | |
14:02 | Patch https://www.androwish.org/home/info/08edf82b9b7e94e5 (some fixes in tk's library in order to support multiple display connections) from Christian Werner. check-in: 7608b5e7 user: fvogel tags: bug-c23f79ef96 | |
13:36 | sprintf --> snprintf check-in: 8cf14aad user: fvogel tags: bug-c23f79ef96 | |
13:35 | Patch https://www.androwish.org/home/info/8891f0f0927cb844 (fixes in ttk object caching) from Christian Werner. check-in: ea226ea5 user: fvogel tags: bug-c23f79ef96 | |
13:29 | Patch https://www.androwish.org/home/info/843e00e7fc400009 (fixes in tk's font rendering when using libxft) from Christian Werner. check-in: 4dc98988 user: fvogel tags: bug-c23f79ef96 | |
11:35 | Fix [1d8b7124b6]: X11: Photo images not drawn correctly for 32-bit visuals. Patch from Christian Werner proposed in https://www.androwish.org/home/info/7aeac931688d2525. Closed-Leaf check-in: 817e22cd user: fvogel tags: bug-1d8b7124b6 | |
11:28 | Backout [dfcb5408] and [182ef922]. check-in: 0a187b9a user: fvogel tags: bug-1d8b7124b6 | |
2023-12-01
| ||
10:09 | http -> https (see [b54a9193f6]) check-in: 2d455ab8 user: jan.nijtmans tags: core-8-6-branch | |
2023-11-28
| ||
17:53 | Fix [900f23c6a8]: Potential problem in PNG parser check-in: 17378151 user: jan.nijtmans tags: core-8-6-branch | |
2023-11-26
| ||
10:45 | unixFont.test - The font configured for the .b.l label which is used in many tests must be a fixed-width font. With Xft, this is not the case of the font that gets allocated when requesting 'fixed'. Use TkFixedFont instead, which really has -fixed 1 in its font metrics. The 'failsOnUbuntu' constraint can then be removed from tests unixFont-5.8, -5.9 and -5.12 (they now pass on Linux with or without Xft, and under Xvfb or not). check-in: 51ced8ab user: fvogel tags: less_tests_constraints | |
09:58 | Function AllocFont() became InitFont() in [1120dc4257] (Tk 8.1, in 1999!). Remove references to the old name. check-in: 81b8ad16 user: fvogel tags: less_tests_constraints | |
09:42 | Rename the 'injectkeyevent' aqua-specific test command to 'testinjectkeyevent'. check-in: c28f36ff user: fvogel tags: less_tests_constraints | |
09:40 | Rename the 'menubarheight' aqua-specific test command to 'testmenubarheight'. check-in: d5e60269 user: fvogel tags: less_tests_constraints | |
09:38 | Move definition of the 'movemouse' constraint, and rename it to 'testmovemouse' (to conform to other test constraint names on platforms other than macOS aqua). check-in: d934c3b0 user: fvogel tags: less_tests_constraints | |
09:35 | Sort test* constraint names alphabetically. check-in: 0e44194e user: fvogel tags: less_tests_constraints | |
09:34 | Factorize definition of the 'pressbutton' constraint, and rename it to 'testpressbutton' (to conform to other test constraint names on platforms other than macOS aqua). check-in: 84c86e40 user: fvogel tags: less_tests_constraints | |
09:16 | Remove superfluous 'unix' constraint in font-4.9. Given what is tested here, the 'haveTimesFamilyFont' constraint is enough. check-in: 6598e897 user: fvogel tags: less_tests_constraints | |
08:53 | merge core-8-6-branch check-in: 831f3dae user: fvogel tags: less_tests_constraints | |
2023-11-25
| ||
20:21 | Fix [52d83f67eb]: TkDestroyMenu(): outdated comment check-in: 27fe9161 user: fvogel tags: core-8-6-branch | |
15:51 | Let this bugfix branch build and test at Github Actions for the macOS platform. Closed-Leaf check-in: 4b032f13 user: fvogel tags: bug-fe942372aa | |
15:20 | Fix [fe942372aa]: Aqua: XPutImage() swaps red and blue channels. Patch from Christopher Chavez. check-in: 72cbe390 user: fvogel tags: bug-fe942372aa | |
09:54 | Fix [9c098a90e6]: macOS Aqua : crash in setMarkedText. Patch from Christopher Chavez. check-in: 62ed2fad user: fvogel tags: core-8-6-branch | |
2023-11-23
| ||
15:21 | Fix e653408972: autoconf warning check-in: 8dbd39be user: jan.nijtmans tags: core-8-6-branch | |
2023-11-22
| ||
20:51 | Let this bugfix branch build and test at Github Actions. check-in: 6775cefd user: fvogel tags: bug-1d8b7124b6 | |
20:50 | Repair the build on Windows. check-in: dfcb5408 user: fvogel tags: bug-1d8b7124b6 | |
12:28 | Fix [22a4ad2a6e]: Aqua: let Core Graphics manage pixmap data memory. Patch from Christopher Chavez. check-in: 3eb478b0 user: fvogel tags: core-8-6-branch | |
2023-11-21
| ||
22:19 | Let this bugfix branch build and test at Github Actions for the macOS platform. Closed-Leaf check-in: 547040ac user: fvogel tags: bug-22a4ad2a6e | |
22:11 | Fix [22a4ad2a6e]: Aqua: let Core Graphics manage pixmap data memory. Patch from Christopher Chavez. check-in: 6926b536 user: fvogel tags: bug-22a4ad2a6e | |
21:11 | Patch for [1d8b7124b6]: X11: Photo images not drawn correctly for 32-bit visuals, by Christopher Chavez. This does not build on Windows though. check-in: 182ef922 user: fvogel tags: bug-1d8b7124b6 | |
2023-11-17
| ||
19:41 | Let branch less_tests_constraints build at Github Actions for all platforms. check-in: 6ca68604 user: fvogel tags: less_tests_constraints | |
2023-11-16
| ||
20:09 | merge core-8-6-branch check-in: 618aa93c user: fvogel tags: less_tests_constraints | |
2023-11-15
| ||
19:55 | Fix [61550f38bf]: font actual returns wrong font size with Xft. check-in: 84cd707d user: fvogel tags: core-8-6-branch | |
19:54 | Remove debug outputs. Closed-Leaf check-in: dbc9bb9f user: fvogel tags: bug-61550f38bf | |
2023-11-14
| ||
04:44 | Remove useless abs() in font-44.1 check-in: 5209f0e8 user: fvogel tags: bug-61550f38bf | |
2023-11-13
| ||
21:52 | Reintroduce rounding in font-44.1 check-in: ac62db26 user: fvogel tags: bug-61550f38bf | |
17:26 | Using the application's TkMainInfo struct for sharing the nbTabsStickBit in a thread-safe manner. Thanks Christian W.! check-in: a1b5bcd3 user: csaba tags: core-8-6-branch | |
08:40 | Update README: Add links to Tk 8.7 and 9.0 development check-in: ceffff2a user: jan.nijtmans tags: core-8-6-branch | |
06:40 | Forgot abs() in previous commit. check-in: b8a3c8b0 user: fvogel tags: bug-61550f38bf | |
2023-11-12
| ||
14:07 | Backported the changes made in the branch bug-eedd2e078d to core-8-6-branch. check-in: a6b2dd84 user: csaba tags: core-8-6-branch | |
09:39 | Switch to a floating point approach in font-44.1 check-in: e9c932d7 user: fvogel tags: bug-61550f38bf | |
2023-11-10
| ||
13:23 | Add comment: /* Pert-Tk expects None and ControlMask to be a macro see ticket [593eb0227c] */ check-in: f3ed46c0 user: oehhar tags: core-8-6-branch | |
12:20 | Fix [593eb0227c]: X.h: define ControlMask and None as macros, even on Win32 check-in: bc8c792f user: jan.nijtmans tags: core-8-6-branch | |
2023-11-08
| ||
20:57 | merge core-8-6-branch check-in: 861fb276 user: fvogel tags: bug-61550f38bf | |
20:39 | Add temporary debug output to font-44.1 check-in: 98553875 user: fvogel tags: bug-61550f38bf | |
12:20 | Fix [7d849b95e9]: xft is disabled by default at Github Actions (CI runner) check-in: 6752674b user: jan.nijtmans tags: core-8-6-branch | |
2023-11-07
| ||
20:48 | Pixel sizes in font-44.1 must match as integers, therefore round computations. check-in: 5e03f765 user: fvogel tags: bug-61550f38bf | |
14:36 | Fix [09a11fb1228f]: Aqua use-after-free can occur when a posted menu is destroyed. Thanks to Christopher Chavez. check-in: 2f9cdcb7 user: culler tags: core-8-6-branch | |
2023-11-06
| ||
20:52 | Redo [f61a66d8]. check-in: 055170e5 user: fvogel tags: bug-61550f38bf | |
20:49 | Make font-44.1 more independent of the actual font size available by still checking the same thing (doubling of the font size). check-in: e8afac19 user: fvogel tags: bug-61550f38bf | |
20:46 | Redo [4ac7d975]. check-in: 2eba9877 user: fvogel tags: bug-61550f38bf | |
20:46 | Redo [c306fdd1]. check-in: 72139059 user: fvogel tags: bug-61550f38bf | |
20:22 | merge core-8-6-branch check-in: da9e854f user: fvogel tags: bug-61550f38bf | |
20:19 | merge core-8-6-branch check-in: b4f26eeb user: fvogel tags: less_tests_constraints | |
20:15 | Backout [6f485577] since it triggers an unexpected failure in the main branch. check-in: 6bf77fb6 user: fvogel tags: core-8-6-branch | |
06:52 | Fix [499f8e3313]: AdjustStartEndRefs(): avoid undefined realloc() call. Patch from Christopher Chavez. check-in: 1f3888da user: fvogel tags: core-8-6-branch | |
2023-11-05
| ||
20:46 | Add non-regression test for the 'activate' case check-in: d56eb804 user: culler tags: bug-09a11fb1228f-final | |
19:36 | Add a non-regression test for the invoke crash. check-in: 8ecf6563 user: culler tags: bug-09a11fb1228f-final | |
18:24 | Final fix for Aqua menu crashes. check-in: f2bf6993 user: culler tags: bug-09a11fb1228f-final | |
17:15 | merge core-8-6-branch check-in: c333e468 user: fvogel tags: less_tests_constraints | |
17:08 | Fix [61550f38bf]: font actual returns wrong font size with Xft. check-in: 6f485577 user: fvogel tags: core-8-6-branch | |
15:56 | Fix [499f8e3313]: AdjustStartEndRefs(): avoid undefined realloc() call. Patch from Christopher Chavez. Closed-Leaf check-in: 8ef8e223 user: fvogel tags: bug-499f8e3313 | |
2023-11-02
| ||
09:07 | Remove 4 more 'failsOnUbuntu' constraints by checking exactly the pre-requirement for tests unixFont-1.2 and -2.[689]. check-in: 2c176a68 user: fvogel tags: less_tests_constraints | |
08:50 | Restore original behavior with the old font system (i.e. without Xft). check-in: 47412dc2 user: fvogel tags: less_tests_constraints | |
2023-11-01
| ||
21:46 | Enhance previous commit: Without Xft also, check availability of the required font. check-in: 98a7166f user: fvogel tags: less_tests_constraints | |
21:32 | Let the constraints for unixFont-2.2, -2.3 and -2.4 be correctly computed with Xft (which lets these tests be skipped instead of failing). This is three less 'failsOnUbuntu' constraints. check-in: ae01655f user: fvogel tags: less_tests_constraints | |
14:25 | Rename some constraints so that they more accurately reflect what is needed. check-in: 5008dc9c user: fvogel tags: less_tests_constraints | |
14:16 | Remove 'haveTimes12Font' constraint by rewriting the only test using it in such a way that it's expected result is a computation instead of a hardcoded value. check-in: 52cd97a4 user: fvogel tags: less_tests_constraints | |
13:55 | Remove constraint 'withoutXft' from font-21.6 by applying the same font check as the later font-21.* tests already do (if the requested font is not available, the test result is forced to the expected result). check-in: f0c402f4 user: fvogel tags: less_tests_constraints | |
13:42 | font.test - Constrain some tests with 'haveTimesFamilyFont', which is an even more specific test constraint than 'withoutXft'. check-in: ea9e4b2a user: fvogel tags: less_tests_constraints | |
2023-10-29
| ||
21:04 | Let this bugfix branch build and test at Github Actions. check-in: f61a66d8 user: fvogel tags: bug-61550f38bf | |
21:02 | Backout useless [8271b8d2]. check-in: 4ac7d975 user: fvogel tags: bug-61550f38bf | |
21:00 | Fix [61550f38bf]: font actual returns wrong font size with Xft. check-in: c306fdd1 user: fvogel tags: bug-61550f38bf | |
14:40 | Remove warnings when DEBUG_FONTSEL is defined. Commits like [6c1859a0] seem to have forgotten to propagate the changes to the DEBUG_FONTSEL case. check-in: 9deacbbe user: fvogel tags: less_tests_constraints | |
2023-10-28
| ||
16:02 | Fix typo check-in: 9424e1df user: fvogel tags: less_tests_constraints | |
15:59 | Remove obsolete comment. Patch #971980 actually is implemented (this is TIP#205, implemented in 8.5). check-in: 0f7602ab user: fvogel tags: less_tests_constraints | |
15:56 | font.test - Remove all 'failsOnUbuntu' constraints, Ubuntu has nothing to do with the failure, these tests fail without Xft. check-in: e41b1921 user: fvogel tags: less_tests_constraints | |
10:59 | Fix [198376af5a]: When moving tab position to different edge of notebook tabs may not appear. check-in: 5fec1bcc user: fvogel tags: core-8-6-branch | |
10:03 | Move TtkBoxEqual() from ttkTheme.h to ttkThemeInt.h Closed-Leaf check-in: 079c12d0 user: fvogel tags: bug-198376af5a | |
08:53 | Ttk_BoxEqual has no need to be in the TTKAPI, let's limit its scope (--> TtkBoxEqual). check-in: 43616e1b user: fvogel tags: bug-198376af5a | |
08:18 | Fix [bb8041c239]: Call legacy Tk_ImageCreateProc using correct function pointer type. Thanks to Christopher Chavez. check-in: 91a6ecaa user: fvogel tags: core-8-6-branch | |
08:10 | Fix [84fe25065c]: Call non-legacy Tk_ImageStringWriteProc using correct function pointer type. Thanks to Christopher Chavez. check-in: c07ac6cd user: fvogel tags: core-8-6-branch | |
2023-10-23
| ||
19:42 | Backout [36cf234a], I was just wrong! Thanks Csaba! check-in: d03ae939 user: fvogel tags: less_tests_constraints | |
2023-10-22
| ||
14:03 | Missing removal of noExceed constraints in previous commit. check-in: 971b747a user: fvogel tags: less_tests_constraints | |
14:01 | Eradicate constraint noExceed. This was originally introduced in [73e913a6] where the comment there explained the reason why the constraint was built on a command that should return an error (i.e. font actual \{xyz) but didn't under Exceed. Let's get rid of this relic from the past, I'm sure nobody runs the test suite under unix from Exceed. check-in: ee857cd1 user: fvogel tags: less_tests_constraints | |
12:12 | Remove library/ttk/fonts.tcl. This is dead code since the implementation of TIP #145 in 2007. check-in: 36cf234a user: fvogel tags: less_tests_constraints | |
2023-10-21
| ||
21:37 | Let this bugfix branch build and test at Github Actions. check-in: 300696b2 user: fvogel tags: bug-198376af5a | |
21:35 | Make test notebook-198376af5a pass on macOS aqua. On this platform, the default theme used is 'aqua', which (currently) has a vertical padding of 5 pixels). On Linux and Windows the theme in use has 1 pixel padding. check-in: a6302f25 user: fvogel tags: bug-198376af5a | |
21:26 | Refine the fix, avoid endless calls to NotebookDoLayout() on macOS aqua. check-in: 1bb22bb5 user: fvogel tags: bug-198376af5a | |
12:35 | Simplify and robustify test notebook-198376af5a. check-in: bee88303 user: fvogel tags: bug-198376af5a | |
12:13 | Remove abbreviation. check-in: 68943170 user: fvogel tags: bug-198376af5a | |
12:11 | Fix [198376af5a]: When moving tab position to different edge of notebook tabs may not appear. check-in: 8730b178 user: fvogel tags: bug-198376af5a | |
11:56 | Add test notebook-198376af5a demonstrating bug [198376af5a]. check-in: e3d216f3 user: fvogel tags: bug-198376af5a | |
2023-10-20
| ||
19:47 | merge less_tests_constraints: no more failures on Linux Debian 11 for unixWm.test and wm.test check-in: 40b5f428 user: fvogel tags: core-8-6-branch | |
2023-10-18
| ||
18:46 | merge core-8-6-branch check-in: 3b8e8705 user: fvogel tags: less_tests_constraints | |
13:42 | Implement applicationSupportsSecureRestorableState for Sonoma security warning, reported in 10b38a7a7c check-in: ed7cfbac user: kevin_walzer tags: core-8-6-branch | |
2023-10-16
| ||
20:46 | Fix [22eefb9368]: unixWm-45.2 and unixWm-45.4 fail on Linux. check-in: d53a2e9d user: fvogel tags: core-8-6-branch | |
2023-10-15
| ||
18:05 | Backout previous commit. In fact unixWM-45.2 and unixWm-45.4 do pass on XQuartz (which is expected since the Linux implementation is used in this case). Closed-Leaf check-in: 8215b835 user: fvogel tags: bug-22eefb9368 | |
16:38 | Restore the failsOnXQuarz constraint on unixWM-45.2 and unixWm-45.4 since on XQuartz these tests still do fail. check-in: 93f53f4a user: fvogel tags: bug-22eefb9368 | |
16:28 | Propagate changes from the previous commit to plaftorms other than Linux. This commit is for consistency only, because platforms other than X11 do not send an XSizeHints structure to the underlying window manager. check-in: 391bac1d user: fvogel tags: bug-22eefb9368 | |
16:21 | Fix [22eefb9368]: unixWm-45.2 and unixWm-45.4 fail on Linux. check-in: b4ae383b user: fvogel tags: bug-22eefb9368 | |
2023-10-14
| ||
21:28 | Missing !endif in makefile.vc check-in: 363eaba2 user: jan.nijtmans tags: core-8-6-branch | |
2023-10-13
| ||
16:32 | Fix broken commit [6659c39e]. See [4c6c553d5a]: tkBind.c: error: conflicting types for 'Tk_BindEvent' check-in: 1d77ad4a user: jan.nijtmans tags: core-8-6-branch | |
14:53 | Restore to rules.vc version 10, so we don't accidentally use Tcl 8.7/9.0 features check-in: 6e54fe52 user: jan.nijtmans tags: core-8-6-branch | |
14:42 | Fix [74bfd42098]: tkBind.c: error: unknown type name 'Tcl_Size' check-in: 6659c39e user: jan.nijtmans tags: core-8-6-branch | |
2023-10-12
| ||
12:01 | Fix [04d3e5ea8e]: Ttk_Use(): do not call functions through pointers to incorrect function type check-in: 0dc5b1e1 user: jan.nijtmans tags: core-8-6-branch | |
11:59 | Make somewhat more C++-compatible (backported from 8.7) check-in: 22fff4c5 user: jan.nijtmans tags: core-8-6-branch | |
2023-10-11
| ||
15:16 | Missed one simplification check-in: 754a3e85 user: jan.nijtmans tags: core-8-6-branch | |
15:13 | Fix [d96974d99d]: Functions passed to Tcl_EventuallyFree() must be declared/defined as Tcl_FreeProc check-in: 37556331 user: jan.nijtmans tags: core-8-6-branch | |
15:05 | Do away with all those type-casts. Compatibility with 9.0 is still no issue Closed-Leaf check-in: 9eaeddb3 user: jan.nijtmans tags: bug-d96974d99d | |