Tk Source Code

* unix/configure: regen'd * unix/tcl.m4: * unix/configure.in: added macros and calls to SC_TCL_EARLY_FLAGS and SC_TCL_64BIT_FLAGS, part of TIP #72.

* library/entry.tcl: * library/text.tcl: Adjust <Double-1> and <Triple-1> bindings so that no anchor point is set and the insertion cursor is set to the last character in the selection. [Bug 220943] * tests/event.test: Add test cases for double click and drag as well as triple click and drag in the text and entry widgets.

* library/entry.tcl: * library/text.tcl: Adjust <Double-1> and <Triple-1> bindings so that no anchor point is set and the insertion cursor is set to the last character in the selection. [Bug 220943] * tests/event.test: Add test cases for double click and drag as well as triple click and drag in the text and entry widgets.

* tests/event.test (_text_ind_to_x_y, _get_selection): Fix incorrect use of results from bbox invocation so that y center point for a give index is calculated correctly. Add new method to return the selection and use it in test cases. Always lappend to the result list to avoid case where initial result includes a space.

* modified some callers of Tcl routines that were restored to return (char *) pointing into Tcl_DStrings.

* generic/tkCmds.c (Tk_TkObjCmd): don't use 'bool' as an arg as it conflicts with the C99 spec. [Bug #511956] (ingham)

* Overlooked COSNTification of XSetCommand

* The POTENTIAL INCOMPATIBILITY in the changing interface of Tk_ParseArgv can now be removed by the -DUSE_NON_CONST compiler flag.

* unix/configure.in: Don't set TCL_LIB_SPEC and TCL_STUB_LIB_SPEC variables since this breaks the AIX build. This was used in the past to support linking with Tcl from the build dir or the install dir, but it is no longer needed.

* unix/Makefile.in: Remove commented out vars. * unix/configure: Regen. * unix/configure.in: Don't subst vars that are already taken care of in SC_LOAD_TCLCONFIG. * unix/tcl.m4: Update from Tcl. * win/configure: Regen. * win/tcl.m4: Update from Tcl.

* generic/tkFileFilter.c: * mac/tkMacInit.c: * mac/tkMacKeyboard.c: * mac/tkMacMenus.c: TIP 27 CONSTification induced changes

* Updated callers of Tcl_SplitList and Tcl_Merge. * Updated callers of Tcl_GetStringResult. Rewrote PrintScrollFractions to ScrollFractions to stop scribbling directly on interp->result. * Updated callers of Tcl_GetVar, Tcl_GetVar2 * Updated callers of Tcl_SplitPath, Tcl_JoinPath, and Tcl_TranslateFileName.

* macosx/tkMacOSXInit.c (TkpInit): Move ALL the MacOS X specific initialization code into TkpInit so extension writers don't have to do anything special to initialize Tk.

This is patch #495549 check-in: 4dec70a7 user: wolfsuit tags: macosx-8-4-branch

* tests/wm.test: Rewrite stackorder tests that deal with toplevels that have the overrideredirect flag set. [Tk bug 492259]

* Overloked Tcl_GetIndexFromObj callers

* mac/tkMacDialog.c: * mac/tkMacSend.c: TIP 27 CONSTification broke the mac build in a few places.

* generic/tkListbox.c (ChangeListboxOffset): improved tracking when scrolling on x axis with entry/text. [Bug #225025] (voskuil)

* An overlooked caller of Tcl_GetIndexFromObj.

* An overlooked caller of Tcl_GetIndexFromObj() and a style fix.

* Updates to handle change in type of tablePtr argument of Tcl_GetIndexFromObj(Struct) from (char **) to (CONST char **). [TIP 27] [Patch 504705]

* Updated callers of Tcl_Utf* and Tcl_Regexp* APIs to reflect TIP 27 API changes (see Tcl Patch 471509). [Patch 471513]

* unix/configure: Regen. * unix/tcl.m4: Update from Tcl. * win/configure: Regen. * win/tcl.m4: Update from Tcl.

* Updated callers of CONSTified Tcl interfaces Tcl_EvalFile and TclGetStartupScriptFileName.

* Updated Tk's console to CONSTified channel driver interface. [Tcl Patch 503565, Tk Patch 503983]

* Updated Tk's console to CONSTified channel driver interface. [Tcl Patch 503565, Tk Patch 503983]

Use ${libdir} instead of ${exec_prefix}/lib. [Tcl bug 489370]

* unix/configure: Regen. * unix/configure.in: Define and use libdir. * win/configure: Regen. * win/configure.in: Define libdir.

* unix/Makefile.in: Burn Tcl and Tk build directories into tktest executable to avoid crashes caused by ld loading a previously installed version of the tcl or tk shared libraries. Remove setting of LD_LIBRARY_PATH, LIBPATH, and SHLIB_PATH before running tktest since it should no longer be required.

Enable use of Tcl stubs when building Tk as a shared library. This should fix the build under AIX. [Bugs 220858, 220955, 220921]

* unix/Makefile.in: Add TCL_STUB_LIB_SPEC and TCL_STUB_LIB_FLAG variables. * unix/configure: Regen. * unix/configure.in: Pass TCL_STUB_LIB_SPEC into Makefile and use it when linking the tk shared library. Define USE_TCL_STUBS when building shared. Subst TCL_STUB_LIB_SPEC and TCL_STUB_LIB_FLAG.

* generic/tkBind.c (TkBindFree): * generic/tkGrid.c (ResolveConstraints,CheckSlotData,DestroyGrid): * generic/tkSelect.c (Tk_DeleteSelHandler,TkSelDeadWindow): Replaced Tcl_Free calls with ckfree so that memory debugging is fully supported.

* test/winButton.test: * win/tkWinButton.c: added updated patch #463234 which returns the default sizing behavior (not so native), but enables native L&F with negative sizing (-11 for example).

* win/tkWinWm.c (InitWindowClass): corrected init routines to allow unicode in window titles on Windows (for Win2K/XP). (TkWmStackorderToplevel): Corrected casts to enable debug compile

* win/tkWinDialog.c (Tk_MessageBoxObjCmd): use MessageBoxW for proper display of unicode errors. Added patch which uses new OLE based directory chooser. This still has some issues, so is disabled by default. [Patch #468139] (ColorDlgHookProc) Corrected ability to use unicode chars in tk_chooseColor -title.

* win/tkWinInt.h: * win/tkWinX.c: added TkWinProcs that represent a function table to switch between unicode and ansi procs on Windows. This is analogous to the TclWinProcs. Using Tcl_WinUtfToTChar, we can easily take advantage of using unicode functions where available without having to switch on the platform id each time.

* win/configure: regen'ed * win/tcl.m4: added shell32.lib to link libs, as these are necessary for new directory chooser (when enabled).

* library/text.tcl (tk::TextButton1): made text receive focus even in disabled state for Windows to show selection and allow mouse-wheel scrolling.

* win/tkWinInit.c (TkpDisplayWarning): Use MessageBoxW in case the error displayed has unicode chars. [Bug #485986]

* generic/tkButton.c (ButtonTextVarProc): guard against being called while the *button/label is being deleted. [Bug #490051]

* mac/mac/tkMacInit.c: * mac/mac/tkMacResource.r: synced up tkInit features to unix/win: use existing tkInit proc if defined. Added spinbox.tcl resource. Used TclGetEnv() instead of Tcl_GetVar2(interp, env) * mac/tkMacApplication.r: * mac/tkMacLibrary.r: minor version resources cleanup

* library/entry.tcl: * library/spinbox.tcl: * library/text.tcl: added extra checks against bug #220269 and made spinbox reuse more of the entry procedure code.

* unix/configure: Regen. * unix/tcl.m4: Update from Tcl.

* unix/configure: Regen. * unix/tcl.m4: Update from Tcl.

* unix/configure: Regen. * unix/configure.in: Move EXP file changes over from Tcl configure script to fix AIX build with gcc. [Bug 220955]

* unix/Makefile.in: * win/Makefile.in: Use $(MAKE) instead of make in the tcltest rule.

* Corrected test that failed on Solaris/CDE due to text scrolling. [Bug 413735]

* generic/tkText.c: * generic/tkText.h: changed TkTextEditType enums to be prefaced with TK_EDIT_ to prevent name collision.

* mac/tkMacWm.c: mac implementation of wm stackorder

Add TK patch 481148 to implement TIP 74, the wm stackorder command.

* doc/winfo.n: Update documentation for the winfo children command to indicate that top-level windows are not returned in stacking order. * doc/wm.n: Add documentation for wm stackorder. * generic/tkInt.decls (TkWmStackorderToplevel): Add decl for new function. * generic/tkIntDecls.h: Regen. * generic/tkStubInit.c: Regen. * tests/unixWm.test: Add stackorder command to test for wm command usage message. * tests/wm.test: Add new set of tests for generic window manager methods. * unix/tkUnixWm.c (Tk_WmCmd, TkWmStackorderToplevelWrapperMap, TkWmStackorderToplevel): Add unix implementation of new wm stackorder command. * win/tkWinWm.c (Tk_WmCmd, TkWmStackorderToplevelEnumProc, TkWmStackorderToplevelWrapperMap, TkWmStackorderToplevel): Add windows implementation of new wm stackorder command.

* unix/Makefile.in: Add comments to better describe TCL_EXE and when it should be available. Add rule that prints message about running `make genstubs` when tkStubInit.c is out of date. * win/Makefile.in: Add TCL_TOOL_DIR and TCL_EXE variables to better match the Tcl Makefile. Add genstubs rule so tkSTubInit.c can be regenerated.

* win/configure: Regen. * win/configure.in: Don't AC_SUBST CFLAGS_DEBUG, CFLAGS_OPTIMIZE, or CFLAGS_WARNING since it is now done in SC_CONFIG_CFLAGS. * win/tcl.m4 (SC_CONFIG_CFLAGS): AC_SUBST DL_LIBS, CFLAGS_DEBUG, CFLAGS_OPTIMIZE, and CFLAGS_WARNING.

** upport to 8.4 of mac code changes for 8.3.3 & various new ** changes for 8.4, some already backported to 8.3.4 (patch #435660)

see ChangeLog for details

(DestroyText): plugged mem leak when not clearing stack (callewaert) (TextGetText): more efficient string size calculation (darley)

* generic/tkText.c (TextGetText): reworked to use DString for improved speed. (callewaert, darley)

* win/tkWinButton.c (TkpComputeButtonGeometry): corrected the default size of Windows buttons to conform to the Windows style. This changes the default size of buttons on Windows. [Patch #463234] (nelson) **** POTENTIAL VISUAL INCOMPATABILITY ****

* library/menu.tcl: corrected menu traversal code on Unix to better handle entering cascades. [Patch #481219]

* win/mkd.bat: * win/rmd.bat: Removed -kb CVS attribute and added changes from Llyod Lim for better stability. [Patch #456761]

* win/rules.vc(new): * win/buildall.vc.bat(new): * win/makefile.vc: large rewrite following Tcl's makefile.vc as a guide and Patch #456761. Appears BugFree(tm).

* unix/Makefile.in: * win/Makefile.in: Add "make gdb" target. This target can run wish inside either gdb or insight.

* win/tkWinX.c (TkWinXInit): added InitCommonControlsEx call. * win/rc/tk.rc: * win/rc/wish.rc: * win/rc/wish.exe.manifest: added resources that specify using v6 of the MS Common Controls library when available (WinXP+). This enables use of the themeable widgets (like scrollbars) to be used in Tk. [Patch #478933]

* unix/configure: * unix/tcl.m4: Update from Tcl.

* unix/configure: * unix/tcl.m4: Update from Tcl.

* unix/Makefile.in: Avoid adding libc to the LIBS and WISH_LIBS variables since it is not needed when linking with CC. If required when linking with LD it should be done on a case by case basis in tcl.m4.

Dopey little bug in the dialog for tk_chooseDirectory. There is no file filter for the directory dialog... check-in: bac92019 user: wolfsuit tags: macosx-8-4-branch

* library/console.tcl: removed transpose ability until the console can get a proper rewrite of tag handling.

1) Use the Tcl_SetStartupScript API - a cleaner way than inserting the name into argv. 2) Can't rely on # of arguments from the Finder to see whether we should look for the AppMain. Now it inserts argv[1] = -psn_xxxxx, and who knows what it might do in the future. check-in: 99999907 user: wolfsuit tags: macosx-8-4-branch

* library/console.tcl (ConsoleOutput): fixed undefined widget argument.

* library/xmfbox.tcl: fixed filtering in motif file dialog. [Patch #469670] (nelson)

* generic/tkWindow.c (OpenIM): Added simple XIM patch to enable basic XIM input on Unix. [Patch #412727] (fabian)

* unix/configure: * unix/configure.in: * win/configure: * win/configure.in: * win/tkConfig.sh.in: reworked to be a little cleaner in comparison to each other, and to AC_SUBST even empty vars for win/tkConfig.sh

* library/console.tcl: added more smarts extracted from tkcon to the default console.

* win/tkWinWindow.c: made use of standard Tk_GetHWND instead of older, private TkWinGetHWND.

* Corrected definition of TkpScanWindowId to handle situation where types Window and int do not have the same number of bits. CONST-ified too.

Update to handle change in return type of Tcl_DStringAppend() from (char *) to (CONST char *). [TIP 27]

* win/tkWinWindow.c (TkpPrintWindowId, TkpScanWindowId): fixed to work on Win64 with 64bit XIDs.

* generic/tkWindow.c (Tk_CreateAnonymousWindow): * generic/tkEntry.c (GetSpinboxElement): fixed unreachable returns.

* unix/tkUnixPort.h: * mac/tkMacPort.h: add (int*) cast to TkpScanWindowId. These may need to be changed to Window* (ulong).

* win/tkWinWm.c (WinSetIcon): fixed SetClassLong for 64bit support.

improved use of test constraints

* tests/textDisp.test (textDisp-4.12): corrected test to work properly on Windows.

* tests/scrollbar.test (scrollbar-6.27): marked knownBug because it is skewed by bad dimensions returned by Windows.

* unix/configure: regen'ed * unix/tcl.m4: added --enable-64bit support for HP-11 with the 64-bit kernel.

* Corrected type definition of argument passed to Tcl_GetStringFromObj() from size_t to int. Incorrect type broke [pack] and [grid] on systems where sizeof(size_t) != sizeof(int). [Bugs 462375, 462342, 462338]

* unix/configure: * unix/tcl.m4: Update from Tcl.

* unix/configure: * unix/tcl.m4: Update from Tcl.

* win/Makefile.in: Fix Windows Makefile so that tcltest will automatically be compiled if the user tries to build tktest.

* win/Makefile.in: Use TKTEST variable directly instead of depending on the tktest alias.

* win/mkd.bat: * win/rmd.bat: Apply binary property (cvs admin -kb) to files and convert to CRLF linefeed format to fix the VC++ build. [Tcl Bug #219409]

* tests/unixSend.test: removed test file completely identical to send.test. Removed platform specific named file in case somebody gets send working on Win/Mac in the future.

* tests/config.test: added config-14.1 to test namespace import evaluation of widgets. * generic/tkButton.c (ButtonCreate): * generic/tkFrame.c (CreateFrame): * generic/tkMenubutton.c (Tk_MenubuttonObjCmd): * generic/tkPlace.c (Tk_PlaceObjCmd): * generic/tkScale.c (Tk_ScaleObjCmd): * generic/tkMessage.c (Tk_MessageObjCmd): * generic/tkEntry.c (Tk_EntryObjCmd, Tk_SpinboxObjCmd): * generic/tkSquare.c (SquareObjCmd): redid the handling of optionTables in widgets to allow them to be imported into other namespaces. [Bug #456632]

* win/tkWinDialog.c (ChooseDirectoryHookProc): work-around for MS bug that caused crashing in tk_chooseDirectory on Win95. [Bug #224936] (baker)

* unix/tkUnixWm.c (TkWmRestackToplevel): reworked how ConfigureNotify requests were handled in relation to the parent to avoid the problem with potential 'raise' delays on some wms. [Bug #220260] (baker) wms that were affected should notice the difference in tests unixWm-51.* not failing that failed before.

• Corrected TIP 44 typo that broke binding. Thanks to "Michal" for the fix. [Bug 455468]

* tests/dialog.test (HitReturn): fixed failing dialog-2.1 test because it wasn't always getting focus properly.

* tests/unixFont.test (unixFont-2.[234]): fixed to be more sensitive on systems that have more installed fonts.

* library/dialog.tcl (tk_dialog): changed dialog to show bar on Windows as well and added some y padding between the buttons and the bar. [Patch #442835] (harrismh)

* Labelled the TIP 44 changes as "POTENTIAL INCOMPATIBILITY". Although technically internal changes are not incompatible, they'll be perceived as such by those who get bitten, and this will help them find the cause of their trouble.