Tk Source Code

When posting menus near the bottom of the screen on Windows versions newer than XP the menu may be placed incorrectly. This is due to code in PostOverPoint that corrects an error in the XP window manager. This fix is no longer required for Vista and Windows7.

Reported-by: Harald Oehlmann <[email protected]> Signed-off-by: Pat Thoyts <[email protected]> check-in: 6db4a05c user: patthoyts tags: core-8-5-branch

Moving the pointer off a cascaded submenu over the application window and then back to the parent menu window on a non-cascade entry would leave the submenu displayed when it should be unposted. This patch solves this issue.

Suggested-by: Schelte Bron <[email protected]> Signed-off-by: Pat Thoyts <[email protected]> check-in: a337b2c4 user: patthoyts tags: core-8-5-branch

When the pointer moves to another entry from a cascade entry the sub-menu should popdown. This is how other menus on X11 work today. This effect will not be used if the user has configured ClickToFocus to maintain the previous Tk menu effects.

(backported from trunk)

Signed-off-by: Pat Thoyts <[email protected]> check-in: 27b9615d user: patthoyts tags: core-8-5-branch

Signed-off-by: Pat Thoyts <[email protected]> check-in: cf3a5e70 user: patthoyts tags: core-8-5-branch

Added additional flags to the vsapi element engine to enable specifying the system metrics to use when calculating the size of certain elements. This was being done already for the XP theme but the scripted definitions using the vsapi engine for vista/win7 could not use such flags. This fixes scrollbars not reflecting the users configured scrollbar size.

Reported-by: Mark Garvey <[email protected]> Signed-off-by: Pat Thoyts <[email protected]> check-in: 69d26c40 user: patthoyts tags: core-8-5-branch

If a button is disabled while the state is pressed, then the release event handler did not remove the pressed state. Modified the handler to always remove the pressed state while only calling invoke if !disabled.

Reported-by: Thomas MENEZ <[email protected]> Signed-off-by: Pat Thoyts <[email protected]> check-in: 3837f9f2 user: patthoyts tags: core-8-5-branch

The fix for [Bug 2009788] prevented a crash but causes windows to be lost if their parent is unmapped when [wm forget] is called. Added a test for this case and ensure that the parent window exists when we remap the child to its parent.

Reported-by: Koen Danckaert <[email protected]> Reported-by: Eric Boudaillier <[email protected]> Signed-off-by: Pat Thoyts <[email protected]> check-in: ecfa48e7 user: patthoyts tags: core-8-5-branch

Commit f59e9722e9 changed tearoff menu windows to be transient toolwindow toplevels. However the hidden menu hierarchy confuses the toplevel search when the menu being torn off is a submenu and not a direct child of the menubar. This patch fixes the search to exclude these hidden menu windows.

Signed-off-by: Pat Thoyts <[email protected]> check-in: 8c54d46c user: patthoyts tags: core-8-5-branch

The tkhtml widget doesn't set it's window class. The Windows implementation of the wm manage command checks to see if the contained window is actually a menu (looking for torn-off menus) by examining the class. This patch adds a check for a null class to avoid crashing as suggested.

Suggested-by: Eric Boudaillier <[email protected]> Signed-off-by: Pat Thoyts <[email protected]> check-in: 27afdfb6 user: patthoyts tags: core-8-5-branch

* win/Makefile.in (genstubs): [Tcl Bug 3082049]: Typo.

* changes: Updated for 8.5.9 release.

* doc/menu.n: Formatting error.

* generic/tkText.c (DumpLine): s/segPtr->size/currentSize/ throughout, but particularly in if lineChanged block where segPtr may no longer be valid. [Bug 3053347]

* win/Makefile.in (VC_MANIFEST_EMBED_DLL VC_MANIFEST_EMBED_EXE): * win/configure, win/configure.in, win/tcl.m4: SC_EMBED_MANIFEST macro and --enable-embedded-manifest configure arg added to support manifest embedding where we know the magic. Help prevents DLL hell with MSVC8+.

* unix/Makefile.in: add valgrind target * unix/configure, unix/tcl.m4: SHLIB_LD_LIBS='${LIBS}' for OSF1-V*. Add /usr/lib64 to set of auto-search dirs. [Bug 1230554] (SC_PATH_X): Correct syntax error when xincludes not found.

Major backport of 8.6 Ttk for 8.5.9. Most changes were only being committed to head (8.6), although they could apply for 8.5 as well. This re-sync makes future work easier to maintain and adds some useful work for 8.5 users. Notable changes: - Lots of code cleanup - Some bug fixes never backported - Addition of ttk::spinbox - minor color changes - Improved Vista/7 styling - Move to tile version 0.8.6 (pseudo-package) - ABI and API compatible (even $w identify) - minor new features (extended $w identify)

* changes: Updated for 8.5.9 release.

* doc/listbox.n (SEE ALSO): [Bug 3048809]: Corrected what other page was referred to (ttk::treeview can work as a listbox).

* library/text.tcl (TextCursorInSelection): [Patch 2585265]: Backport of factoring-out of decision logic for whether to delete the selected text.

* win/Makefile.in (%.${OBJEXT}): better implicit rules support

* unix/configure: regen with ac-2.59 * unix/configure.in, unix/Makefile.in: * unix/tcl.m4 (AIX): remove the need for ldAIX, replace with -bexpall/-brtl. Remove TK_EXP_FILE (export file) and other baggage that went with it. Remove pre-4 AIX build support.

* generic/tkCanvLine.c (LineDeleteCoords): [Bug 2900121]: Backport of fix to sense of test.

* library/msgs/pl.msg: Backport updates to pl.msg from HEAD

* generic/tk.h: Bump to 8.5.9 for release. * library/tk.tcl: * unix/configure.in: * unix/tk.spec: * win/configure.in: * README:

* unix/configure: autoconf-2.59 * win/configure:

* changes: Updated for 8.5.9 release.

* library/button.tcl (::tk::CheckEnter): use uplevel set instead of set :: to work with other var resolvers (itcl). [AS Bug#87409]

* changes: Updated for 8.5.9 release.

* win/tkWinX.c (HandleIMEComposition): [Bug 2992129]: Ensure that all places that generate key events zero them out first; Tk relies on that being true for the generic parts of the fix for Bug 1924761.

* library/button.tcl (CheckInvoke, CheckEnter): [Patch 1530276 redux]: Apply a bit more care to ensure that things continue to work correctly even when there is no -selectcolor defined.

* generic/tkText.c (DumpLine): [Bug 2968379]: When peers are about, there can be unnamed marks present during a dump. Ignore them as they will just be for the peers' insert and current marks, which aren't very important.

* changes: Updated for 8.5.8 release.

*** 8.5.8 TAGGED FOR RELEASE ***

* generic/tk.h: Bump to 8.5.8 for release. * library/tk.tcl: * unix/configure.in: * unix/tk.spec: * win/configure.in: * README:

* unix/configure: autoconf-2.59 * win/configure:

* changes: Updated for 8.5.8 release.

* generic/tkConsole.c: Relax the runtime version requirements on Tcl * generic/tkMain.c: so that Tk 8.5.8 can [load] into Tcl 8.6 (and * generic/tkWindow.c: later 8.*) interps. * library/tk.tcl * unix/Makefile.in: * win/Makefile.in: * win/makefile.vc:

* changes: Updated for 8.5.8 release.

* generic/tkMenuDraw.c (TkPostSubmenu): Fix reposting of submenu in * win/tkWinMenu.c (TkWinHandleMenuEvent): torn off Windows menu. [Bug 873613] (DrawMenuEntryArrow): Draw Win menu arrow after being torn off. [Bug 873608]

* macosx/tkMacOSXHLEvents.c (ScriptHandler): fix "do script" apple event handler issues on recent Mac OS X releases by using AE coercion to 'utf8' for text data and to 'fsrf' for alias data. (reported by Youness Alaoui on tcl-mac)

* unix/tcl.m4, unix/configure (SC_CONFIG_CFLAGS): harden the check to add _r to CC on AIX with threads.

* win/tkWinDialog.c (ChooseDirectoryValidateProc): no need to set cwd on selchange. Prevents delete of selected folder in dialog.

* win/tkWinDialog.c (Tk_ChooseDirectoryObjCmd): enable the new style choosedir that has a "New Folder" button, with ::tk::winChooseDirFlags override for new behavior. [Bug 2779910]

* changes: Updated for 8.5.7 release.

*** 8.5.7 TAGGED FOR RELEASE ***

* changes: Updated for 8.5.7 release.

* generic/tk.h: Bump to 8.5.6 for release. * library/tk.tcl: * unix/configure.in: * unix/tk.spec: * win/configure.in: * README:

* unix/configure: autoconf-2.59 * win/configure:

* unix/configure.in (Darwin): use Darwin SUSv3 extensions if available. * unix/configure: autoconf-2.59 * unix/tkConfig.h.in: autoheader-2.59

* library/msgbox.tcl: don't set msgbox bitmap background on TkAqua.

* library/demos/filebox.tcl: only show "Motif Style Dialog" checkbutton on X11 windowingsystem.

* library/demos/widget: GOOBE: use ttk::cursor

* library/ttk/cursors.tcl: backport ttk::cursor from HEAD

* library/demos/knightstour.tcl: fix knightstour demo not running from interactive wish.

* library/console.tcl (::tk::ConsoleInit): remove redundant TkAqua Quit menu item.

* generic/tkPointer.c (Tk_UpdatePointer): use all 5 buttons.

* generic/tkMenu.c (PostProcessEntry): delay call to TkpConfigureMenuEntry() until all menu entry attributes are setup.

* library/menu.tcl (::tk::MbPost): fix error thrown in y position computation with indicatoron.

* generic/tkMenubutton.c: s/DEF_BUTTON_JUSTIFY/DEF_MENUBUTTON_JUSTIFY/

* generic/tkBind.c (HandleEventGenerate): ensure window exists before generating an event for it (fixes testsuite crash).

* generic/tkTextBTree.c (TkBTreeDeleteIndexRange): add bounds check to startEnd array access (fixes testsuite crash).

* tests/unixFont.test: only use xlsfonts with X11 windowingsystem.

* win/tcl.m4, win/configure: Check if cl groks _WIN64 already to avoid CC manipulation that can screw up later configure checks. Use 'd'ebug runtime in 64-bit builds.

* win/configure.in, win/configure: align better with tcl version. Ensures finding correct CPP for Win64.

* generic/tkImgPhoto.c: fix numerous leaks discovered with the * generic/tkMenu.c: Mac OS X Instruments.app Leaks tool. * generic/tkText.c: * generic/tkTextImage.c: * generic/tkTextIndex.c: * generic/tkUndo.c: * generic/ttk/ttkFrame.c: * macosx/tkMacOSXWm.c:

* tests/embed.test: Eliminate duplicate test names.

* changes: Updates for 8.5.6 release.

* generic/tk.h: Bump to 8.5.6 for release. * library/tk.tcl: * unix/configure.in: * unix/tk.spec: * win/configure.in: * README:

* unix/configure: autoconf-2.59 * win/configure:

* changes: Updates for 8.5.6 release.

* generic/tk.h: Bump version number to 8.5.6b1 to distinguish * library/tk.tcl: CVS development snapshots from the 8.5.5 and * unix/configure.in: 8.5.6 releases. * unix/tk.spec: * win/configure.in: * README:

* unix/configure: autoconf (2.59) * win/configure:

* changes: Updates for 8.5.5 release.

* unix/Makefile.in: Relax constraints in index script so that * win/Makefile.in: each Tk 8.5.* release may be [package require]d * win/makefile.vc: into any Tcl 8.5.* interp. [Bug 1890438].

* generic/tk.h: Bump to 8.5.5 for release. * library/tk.tcl: * unix/configure.in: * unix/tk.spec: * win/configure.in:

* unix/configure: autoconf-2.59 * win/configure:

* tests/canvText.test: Backport test updates in light of the * tests/entry.test: 2008-10-05 commit. * tests/listbox.test: * tests/scrollbar.test: * tests/spinbox.test: * tests/textDisp.test:

* tests/canvText.test: Backport test updates in light of the * tests/entry.test: 2008-10-05 commit. * tests/listbox.test: * tests/scrollbar.test:

* generic/tkListbox.c: Make literal return values consistent with those generated by Tcl_PrintDouble().

* tests/canvText.test: Backport test updates in light of the * tests/entry.test: 2008-10-05 commit. * tests/listbox.test:

* tests/canvText.test: Backport test updates in light of the * tests/entry.test: 2008-10-05 commit.

* tests/canvText.test: Backport test updates in light of the 2008-10-05 commit.

* generic/tkEntry.c: Fix missing space constructing the scroll command.

* unix/tkConfig.sh.in: Added @XFT_LIBS@ to the definition of TK_LIBS to avoid link failures when a "big wish" program links against a --disable-shared build of libtk. (Discovered building expectTk).

* generic/tk.h: Bump version number to 8.5.5b1 to distinguish * library/tk.tcl: CVS development snapshots from the 8.5.4 and * unix/configure.in: 8.5.5 releases. * unix/tk.spec: * win/configure.in: * README:

* unix/configure: autoconf (2.59) * win/configure:

* macosx/tkMacOSXFont.c (SetFontFeatures): Disable antialiasing of fixed-width fonts with size <= 10.

* unix/tcl.m4 (SC_PATH_X): check for libX11.dylib in addition to libX11.so et al.

* generic/tk.h: Bump to 8.5.4 for release. * library/tk.tcl: * unix/configure.in: * unix/tk.spec: * win/configure.in: * README:

* unix/configure: autoconf-2.59 * win/configure:

* changes: Updates for 8.5.4 release.

This allows Tk to compile and run against newer X11 headers where the protocol constant LastEvent has changed. check-in: a4e64793 user: jenglish tags: core-8-5-branch

* generic/tk.h: Added missing EXTERN for the Tcl_PkgInitStubsCheck declaration to fix inability to embed non-stub-enabled Tk on Windows.

* library/ttk/aquaTheme.tcl: Use system color names and TIP145 named font instead of hardcoded color values and deprecated native font name.

* macosx/tkMacOSXHLEvents.c: sync with HEAD.

* generic/tk.h: Bump to 8.5.3 for release. * library/tk.tcl: * unix/configure.in: * unix/tk.spec: * win/configure.in: * README:

* unix/configure: autoconf-2.59 * win/configure:

* changes: Updates for 8.5.3 release.

* generic/tkPanedWindow.c (PanedWindowProxyCommand) (DisplayPanedWindow): Ensure that a zero width never gets fed to the underlying window system. [Bug 1639824] (Backport fix from dkf).

* changes: Updates for 8.5.3 release.

* macosx/tkMacOSXCarbonEvents.c: fix debug carbon event tracing; (InstallStandardApplicationEventHandler): replace needless use of TkMacOSXInitNamedDebugSymbol() by standard TkMacOSXInitNamedSymbol().

* macosx/tkMacOSXDebug.c: revert 2007-11-09 commit making * macosx/tkMacOSXDebug.h: TkMacOSXInitNamedDebugSymbol() available outside of debug builds.