Tk Source Code

* tests/safe.test (safe-1.3): Made test less sensitve to the full set of existing aliases in an interp, so the it only tests whether the tested ones are present.

* unix/Makefile.in: Copied LD_LIBRARY_PATH machinery from `make shell` target to other similar targets so that just built libraries are tested, rather than previous installations.

* win/tkWinWm.c (UpdateWrapper): pass SWP_NOOWNERZORDER to SetWindowPos when maintaining win Z order, to prevent parent from flashing (adjusting Z order).

Backport of 8.5 wm iconphoto that added support for Tk photo * generic/tkInt.h (TkDisplay): images as titlebar icons. TIP #159 * win/tkWinWm.c (WmIconphotoCmd): wm iconphoto ?-default? image1 ... * macosx/tkMacOSXWm.c (WmIconphotoCmd): Implemented for Win/Unix, * unix/tkUnixWm.c (WmIconphotoCmd): stubbed out for OS X. * tests/wm.test, tests/unixWm.test, tests/winWm.test: [Bug 815751]

* generic/tkCursor.c: Add missing initialization in debug routine.

* win/tkWinInt.h (TkWinDisplayChanged): added decl * win/tkWinX.c (TkWinDisplayChanged, TkpOpenDisplay): Correctly * win/tkWinWm.c (InvalidateSubTreeDepth, WmProc): handle color and screen resolution changes. Tested for 16/24/32 bpp changes on XP. May need more fixes for 8bpp switch, use of special colormaps, or other special palette handling cases. [Bug 223689]

* generic/tkInt.decls: Add decl for TkWinGetPlatformTheme. It is only defined under Win32. * generic/tkIntPlatDecls.h: Regen. * generic/tkStubInit.c: Regen. * win/tkWinInt.h: Define TK_THEME_WIN_CLASSIC and TK_THEME_WIN_XP. * win/tkWinMenu.c (DrawMenuEntryAccelerator, DrawMenuEntryLabel): Draw a disabled 3D text highlight for the accelerator only with the Win95/98 look. Same goes for the menu entry text. * win/tkWinX.c (TkWinGetPlatformId, TkWinGetPlatformTheme): Automatically detect the Windows theme in use and return either TK_THEME_WIN_CLASSIC or TK_THEME_WIN_XP when the TkWinGetPlatformTheme function is invoked. [Patch 866194]

* win/tkWinMenu.c: only provide a submenu handle when the MF_POPUP flag is given, fixing a recently-introduced crash when submenus are disabled. Also better error checking for this sort of situation in the future.

* win/tkWinMenu.c (ReconfigureWindowsMenu): Fix drawing of a disabled (TkWinHandleMenuEvent, DrawMenuEntryArrow): cascade menu arrow. Tk was displaying a disabled cascade menu arrow in black instead of gray. This was caused by a bug in the Win32 code for user drawn menu items. The fix is to avoid telling Windows that the menu item is a cascade type and then draw the gray arrow bitmap on our own. [Patch 865842]

* win/tkWinMenu.c (DrawWindowsSystemBitmap): Fix a strange Win32 bug where the logical coordinates returned by a call to DPtoLP are wrong the first time a menu is posted. This bug manifested itself by drawing the bitmap in the wrong place in a menu. The fix was to pass the newly created DC instead of the DC from the window.

* win/tkWinMenu.c (DrawMenuEntryAccelerator): (DrawMenuEntryLabel): When drawing the label text and accelerator text for a disabled menu entry be sure to draw a 3D highlight. The only exception to this is when a disabled menu entry is highlighted, in that case do not draw a 3D hightlight.

* win/tkWinMenu.c (DrawMenuEntryAccelerator, DrawMenuEntryArrow): Move the unused menu arrow drawing code in DrawMenuEntryAccelerator into a new function named DrawMenuEntryArrow. This makes no functional change but it will make it easier to fix things in the future.

* win/tkWinWm.c: Rework WS_EX_LAYERED and LWA_ALPHA defines so that compiling with mingw works again.

* win/tkWinWm.c (UpdateWrapper, WmAttributesCmd): handle attribute settings prior to window mapping and resort to more forceful wrapper update again for -toolwindow (to remove it from taskbar).

(UpdateWrapper): don't adjust Z order of TOPMOST window. (WmAttributesCmd): don't call UpdateWrapper for -disabled or -toolwindow attr changes.

* win/tkWinWm.c (WmAttributesCmd): correct -alpha 0.0/1.0 setting and round the value.

* macosx/README: typos * macosx/tkMacOSXDraw.c (TkMacOSXSetUpCGContext): performance improvements: removed slow & unnecessary calls.

* tests/winWm.test: Add 'wm attributes -alpha' to control toplevel * win/tkWinInt.h: alpha transparency on Win2K/XP+. * win/tkWinWm.c: TIP #222 [Patch 892194]

* win/tkWinWm.c (UpdateWrapper): Ensure that we maintain Z order * tests/winWm.test: and focus of preexisting window when replacing the wrapper window. * win/tkWinWm.c (WmIconwindowCmd): Replace bogus call to XWithdrawWindow with proper code. (mdejong)

* generic/tkMenu.c (MenuWorldChanged): ensure that we recompute the menu geometry on WorldChanged to handle font size changes. [Bug 607649]

* win/tkWinWm.c (ReadIconFromFile): fix mem alloc to get the right size for both icons ('?:' order of precedence mistake).

(UpdateWrapper): update to Kovalenko to account for whether the override window has a transient parent, and apply WS_POPUP in the correct case. The makes splash screens pop up as well as making dropdowns not grab focus away from the parent.

* win/tkWinWm.c (ActivateWindow): SetFocus to grab window when clicking outside the grab window hierarchy. [Bug 220908]

* win/tkWinWm.c: backport of several items from 8.5 head: (ReadIconFromFile): when using SHGetFileInfo to retrieve icon, get regular icon as well for correct Alt-Tab icon. (hobbs) Fix for #742882 "Potential division by zero in gridded wm geometry" (jenglish) (UpdateWrapper): Let overrideredirect'ed window's wrapper be the child of desktop window, thus making it to behave more similarly to X11 Override Redirect. Esp. useful for combobox-like megawidgets. (kovalenko) (InstallColormaps): Check for TK_ALREADY_DEAD to avoid handling of dead windows. (kovalenko) Change 'panic' to 'Tcl_Panic' (davygrvy)

* library/tkfbox.tcl (::tk::dialog::file::Create): use label instead of button for "File of type", as it properly handles -state disabled now.

* library/text.tcl (::tk::TextTranspose): Ensure that Transpose is an atomic op to undo. Replace 'string compare' with 'ne'.

* win/tkWinDialog.c (EatSpuriousMessageBugFix): Fix a problem with double clicks in file dialogs falling through to the window underneath in win32. [Patch #611615]

* win/tkWinDialog.c (Tk_MessageBoxObjCmd): Inherit the icon from * win/tkWinInt.h: the -parent window for * win/tkWinWm.c (TkWinGetIcon): the MessageBox.

* tests/canvText.test: * win/tkWinFont.c (Tk_MeasureChars): Fix for text wrapping problem that appeared using canvas text under Win32. A long wrapping string that had leading spaces was being incorrectly wrapped. This change makes the Win32 implementation behave the same as the Unix implementation. [Patch 100628

* unix/configure: * unix/tcl.m4 (SC_CONFIG_CFLAGS): Darwin: instead of setting PLAT_OBJS to explict object files in tcl.m4, refer to MAC_OSX_OBJS makefile var.

* changes: * generic/tkEvent.c (Tk_HandleEvent): revert the 2004-07-20 commit. That commit created a new Bug 1000051 - a broken Compose Key. This revert restores Bug 905830 until a cleaner fix can be provided.

* generic/tkImgGIF.c (FileReadGIF): fix crash reported by Reinhard Max: in case of premature end of image data, return error instead of passing nil buffer to Tk_PhotoPutBlock().

* generic/tkRectOval.c (ComputeRectOvalBbox): Mac OS X specific fix to rounding in bounding box 'bloat' calculation to avoid drawing outside of bounding box when CG drawing enabled. Fix probably correct on other platforms as well?

* macosx/tkMacOSXDraw.c (TkMacOSXInitCGDrawing): fixed LinkVar type for tkMacOSXCGAntiAliasLimit.

Mac OS X: Fix several problems with Icelandic (and Faroese) keyboards reported by J�r�me Gagnon-Voyer <gagnonje5000<at>mac<dot>com> on tcl-mac on 2004-03-22.

* macosx/tkMacOSXKeyEvent.c (KLSInit): Add. (GetKeyboardLayout): Add calls to Keyboard Layout Services, if present. Rework classic handling. Use GetKCHREncoding(). Add parameter encodingPtr. (GetKCHREncoding): Add. check-in: ffa0483c user: cc_benny tags: core-8-4-branch

Fix several problems with Icelandic (and Faroese) keyboards reported by J�r�me Gagnon-Voyer <gagnonje5000<at>mac<dot>com> on tcl-mac on 2004-03-22.

(KLSInit): Add. (GetKCHREncoding): Add. (GetKeyboardLayout): Add calls to Keyboard Layout Services, if present. Rework classic handling. Use GetKCHREncoding(). Add parameter encodingPtr. check-in: 0cfc1fc7 user: cc_benny tags: core-8-4-branch

* library/tkfbox.tcl (::tk::dialog::file::Update): use -directory [pwd] (instead of .) to get around some VFS edge case bugs. Use [bind $w], not [$w configure] to modify bindings.

* generic/tkEvent.c (Tk_HandleEvent): ensure IC focus is set after creation. [Bug #905830]

* unix/tcl.m4: fixed Darwin autoconf breakage caused by recent CFLAGS reordering. * unix/configure: regen

* macosx/Makefile: added support to tk framework build to optionally install tk manpages in addition to html help, similarly to tcl/macosx/Makefile.

* macosx/Wish.pbproj/project.pbxproj: fixes for building with non-default SYMROOT/OBJROOT/SRCROOT, added support for using a Tcl.framework in DYLIB_INSTALL_PATH != /Library/Frameworks, added optional support for building html help without tcl sources present by giving explicit location of tcltk-man2html script.

* macosx/tkMacOSXMenu.c: fixed #include case sensitivity bug.

* macosx/Makefile: added support to tk framework build to optionally install tk manpages in addition to html help, similarly to tcl/macosx/Makefile.

* macosx/Wish.pbproj/project.pbxproj: fixes for building with non-default SYMROOT/OBJROOT/SRCROOT, added support for using a Tcl.framework in DYLIB_INSTALL_PATH != /Library/Frameworks, added optional support for building html help without tcl sources present by giving explicit location of tcltk-man2html script.

* macosx/tkMacOSXMenu.c: fixed #include case sensitivity bug.

* unix/Makefile.in, unix/tcl.m4: move (C|LD)FLAGS after their * unix/configure.in, unix/configure: _DEFAULT to allow for env setting to override m4 switches. Consolidate header checks to limit redundancy in configure. (CFLAGS_WARNING): Remove -Wconversion, add -fno-strict-aliasing for gcc builds (need to suppress 3.x type puning warnings). (SC_ENABLE_THREADS): Set m4 to force threaded build when built against a threaded Tcl core. Reorder configure.in for better 64-bit build configuration, replacing EXTRA_CFLAGS with CFLAGS. [Bug #874058]

* macosx/tkMacOSXCursor.c (TkpSetCursor): The code to not reset the cursor more often than necessary was getting fooled when the current cursor was nulled out when the current cursor gets freed. So in the case where the input cursor was NULL, we have to just always set it. [Bug #894550]

* generic/tkUndo.c (TkUndoSetDepth): correct -maxundo segfault. [Bug #969358] (jiangwu)

* README, macosx/Wish.pbproj/project.pbxproj: bumped to * unix/configure, unix/configure.in, unix/tk.spec: patchlevel 8.4.7 * win/configure, win/configure.in:

* generic/tkCmds.c (Tk_WinfoObjCmd): refetch interp result obj for 'winfo id' as it can change when making the window exist.

* generic/tkCanvText.c (DisplayCanvText): Fix text rendering problem with canvas text items that have a selected region. The previous implementation would render the whole line and then redraw the selected text if it was a different color. This caused problems when the selected text foreground differs from the normal text foreground, the anti-aliasing alpha pixels for the two text strings would blend together resulting in strange looking text. The fix is to draw the normal text and the selected text separately. This problem has only been observed under Windows, with anti-aliased text. [Patch 968725]

* generic/tkBind.c <HandleEventGenerate>: Modified to fix wish crach due to incorrectly generate <Destroy> event. This bug was reported in comp.lang.tcl but not logged.

* win/tkWinFont.c (Tk_MeasureChars,Tk_DrawChars,etc): Make sure that the lastSubFontPtr remains valid even when the subfont array is reallocated. [Bug #618872] (dkf, hobbs)

* win/tkWinMenu.c, unix/tkUnixMenu.c (DrawMenuEntryLabel): place images of compound menu entries in indicator space if not a radio of checkbutton. [Bug #756952] (eserte)

* win/tkWinX.c: fix drawing of unicode chars in menu * win/tkWinInt.h (TkWinProcs): titles. [Bug #904371] (riefenstahl) * win/tkWinMenu.c (ReconfigureWindowsMenu):

* generic/tkClipboard.c: Move TkClipCleanup from tkClipboard.c * mac/tkMacXStubs.c: to being implemented in a platform * macosx/tkMacOSXXStubs.c: specific manner. The cleanup order was * unix/tkUnixEvent.c: bad at least on Windows, where we * win/tkWinX.c: reset/cleared display info that was still needed for the clipboard to render. [Bug #939389, #822002, #732662]

* library/panedwindow.tcl (MarkSash): call DragSash to stop sash jump when B1 is pressed and released without moving. [Bug #932155] Make the panedwindow -opaqueresize option work as per the docs. [Bug #778893]

* tests/panedwindow.test: panedwindow-25.1 * generic/tkPanedWindow.c (Unlink): clean up -before/-after refs to a slave when removing it. [Bug #928413] (griffin)

* generic/tkImgPhoto.c (ImgPhotoConfigureMaster): force -data into ByteArray and -format into String to correctly handle them if they have been shimmered or created as some other object type. (ImgPhotoCmd): correctly init matched to 0.

* library/bgerror.tcl (bgerror): rework to only set -topmost bit on Windows if necessary. Also use existing ::tk functions for placing dialog and managing focus/grab.

* unix/tcl.m4 (SC_CONFIG_CFLAGS): Allow 64-bit enabling on IRIX64-6.5* systems. [Bug 218561] * unix/configure: autoconf-2.13

* macosx/tkMacOSXDraw.c: * macosx/tkMacOSXXStubs.c: * xlib/ximage.c: fixed MacOSX XGetImage/XPutImage and related functions to deal properly with XImages copied from screen. * generic/tkCanvPs.c (TkImageGetColor): MacOSX fix. * generic/tkImgPhoto.c (ImgPhotoDisplay): enabled alpha blending for images with partial transparency on MacOSX. [Bug 809157]

* generic/tkBind.c (HandleEventGenerate): only modify root[xy] with [xy] when they haven't been otherwise set.

* tests/imgPhoto.test (imgPhoto-16.1): Corrected incorrect variable name [Bug 899010].

* macosx/tkMacOSXMouseEvent.c: fixed modifiers for MouseWheel events.

* library/listbox.tcl: * library/text.tcl: * library/scrlbar.tcl: on Mac OS, add bindings for MouseWheel with modifiers, according to platform convention: Option increases scrolling speed 10 fold; Space scrolls horizontally.

* macosx/Wish.pbproj/project.pbxproj: * macosx/tkAboutDlg.r: changed year in copyright strings to 2004.

In tk_getOpenFile filters, handle the case where you have a Macintosh file type and the files have no filetype.

Fix various formatting nits. check-in: 834854db user: wolfsuit tags: core-8-4-branch

* win/tkWinFont.c (Tk_MeasureChars): backport fixes to bold/italic font handling. [Patch 852669] [Bug 478568] * tests/textDisp.test: added test for the font measurement problem.

* win/tkWinDialog.c (ChooseDirectoryValidateProc): create a pidl for -initialdir if we have a UNC path because BFFM_SETSELECTION doesn't support UNC paths in strings.

* library/menu.tcl (::tk::MbPost): make menubuttons that post above or below reverse direction when not enough space is available.

* macosx/Wish.pbproj/project.pbxproj: removed erroneous reference to mkpsenc.tcl in bundle resources phase (mkpsenc.tcl is already part of the copy files phase to Resources/Scripts).

* macosx/Makefile: added support for 'xcodebuild' on Mac OS X 10.3.

* macosx/Wish.pbproj/project.pbxproj: added missing private headers to installed Tk.framework, so that tkInt.h can be included sucessfully from Tk.framework/PrivateHeaders. * generic/tkPort.h: corrected include of tkMacOSXPort.h

* win/rc/wish.exe.manifest: It seems that Windows XP insists on a strict format for the version value. 8.5.a0 or 8.5.0 results in an unloadable executable -- must be 4 numbers.

* win/tkWinSend.c: Removed some misleading comments (bug #846134) and disabled the send package until bug #858822 is resolved.

* win/tkWinWm.c (UpdateGeometryInfo) : wmPtr->wrapper might be NULL. No exception is thrown, but it isn't correct to ignore. discovered with NuMega's BoundsChecker.

* win/tkWinMenu.c (ReconfigureWindowsMenu) : Only redraw the menubar when a menubar exists. Although the invalid handle doesn't cause an exception, it was discovered with NuMega's BoundsChecker.

Removed the #ifdef _MSC_VER around DebugBreak as that function exists in kernel32.dll and is not compiler dependent. I'd prefer to use if (IsDebuggerPresent()) DebugBreak(); but IsDebuggerPresent() isn't available in all kernel32.dll modules for all versions of windows. check-in: fba3b025 user: davygrvy tags: core-8-4-branch

* unix/configure: * unix/tcl.m4: updated OpenBSD build configuration based on [Patch #775246] (cassoff)

* generic/tk.h: Bumped patch level to 8.4.5.1 to distinguish * unix/configure.in: CVS snapshots from the 8.4.5 release. * unix/tk.spec: * win/configure.in:

* unix/configure: autoconf (2.13) * win/configure:

* README: Bumped patch level to 8.4.6 to distinguish * generic/tk.h: CVS snapshots from the 8.4.5 release. * unix/configure.in: * unix/tk.spec: * win/configure.in: * macosx/Wish.pbproj/project.pbxproj:

* unix/configure: autoconf (2.13) * win/configure:

* generic/tkMenu.c (MenuVarProc): prevent this from triggering while interp is being destroyed.

* generic/tkMenu.c (MenuVarProc): prevent this from triggering while interp is being destroyed.

* macosx/tkMacOSXScrlbr.c: Reworking Vince's fix to [Bug 842952]. This version is clearer, and works helps keep the mouse better pinned to the scrollbar. I also removed the glitch where the scrollbar would jump get its middle over the mouse when you first moved it.

* tests/constraints.tcl:When running the test suite in a process * tests/image.test: where Tk has been [load]ed, there's no * tests/select.test: guarantee that child processes created by * tests/unixWm.test: [exec [interpreter]] will have Tk in them. * tests/window.test: Made modifications to force a [load] of Tk in those situations.

* generic/tkMenubutton.h: fixed compound menubutton handling like * generic/tkMenubutton.c: *button corrections of 2003-04-25. * mac/tkMacMenubutton.c (TkpDisplayMenuButton): * unix/tkUnixMenubu.c (TkpDisplayMenuButton):

* generic/tkMenubutton.h: fixed compound menubutton handling like * generic/tkMenubutton.c: *button corrections of 2003-04-25. * mac/tkMacMenubutton.c (TkpDisplayMenuButton): * unix/tkUnixMenubu.c (TkpDisplayMenuButton):

* win/makefile.vc: Restored consistency of pkgIndex.tcl file with that generated by Makefile.

* win/makefile.vc: Restored consistency of pkgIndex.tcl file with that generated by Makefile.

Let's discuss whether there's really need for a change, and if so, let's make it consistently in all Makefiles.

* unix/configure: * unix/configure.in: use xft-config instead of pkg-config to determine xft info. * unix/tcl.m4: improve AIX --enable-64bit handling remove -D__NO_STRING_INLINES -D__NO_MATH_INLINES from CFLAGS_OPTIMIZE on Linux. Make default opt -O2 (was -O).

* generic/tkButton.c (ConfigureButton): abort option processing if the button was deleted. [Bug #824479]

* generic/tkMenuDraw.c (TkPostSubmenu): add {} around menu name in case it has spaces when calling Tcl_VarEval. This is a hack until this is rewritten for proper Tcl_Obj handling. [Bug #723856]

(::tk::dialog::file::ActivateEnt): allow typing filename into entry when tk_getOpenFile -multiple 1 is specified. [Bug #788069]

* generic/tkButton.c (ConfigureButton): abort option processing if the button was deleted. [Bug #824479]

* generic/tkMenuDraw.c (TkPostSubmenu): add {} around menu name in case it has spaces when calling Tcl_VarEval. This is a hack until this is rewritten for proper Tcl_Obj handling. [Bug #723856]

(::tk::dialog::file::ActivateEnt): allow typing filename into entry when tk_getOpenFile -multiple 1 is specified. [Bug #788069]

* library/tkfbox.tcl (::tk::dialog::file::Update): optimize the dir/files list separation by using the -tails, -directory and -type option of 'glob'. Also passes the glob the -filetypes filters instead of calling string match over each file. [Patch #833819]

* library/tkfbox.tcl (::tk::dialog::file::Update): optimize the dir/files list separation by using the -tails, -directory and -type option of 'glob'. Also passes the glob the -filetypes filters instead of calling string match over each file. [Patch #833819]

* generic/tkListbox.c (ListboxDeleteSubCmd, ListboxListVarProc): free itemconfig data when removing it from table. [Bug #836483]

* generic/tkListbox.c (ListboxDeleteSubCmd, ListboxListVarProc): free itemconfig data when removing it from table. [Bug #836483]

* macosx/tkMacOSXClipboard.c (TkSuspendClipboard, TkSelGetSelection): add unicode clipboard support. [Patch #840107] (senn)

* macosx/tkMacOSXClipboard.c (TkSuspendClipboard, TkSelGetSelection): add unicode clipboard support. [Patch #840107] (senn)

* win/configure: * win/tcl.m4: add necessary ole libs to VC LIBS_GUI line.

* win/tkWinDraw.c (XFillRectangles): correctly handle the XGCValues.function parameter when filling rectangles. [Bug #820278] [Patch #820282]

* win/tkWinDraw.c (XFillRectangles): correctly handle the XGCValues.function parameter when filling rectangles. [Bug #820278] [Patch #820282]

* win/configure: * win/configure.in: define TK_LIB_FLAG, TK_LIB_SPEC, TK_BUILD_LIB_SPEC, TK_STUB_LIB_SPEC, TK_STUB_LIB_PATH, and TK_BUILD_STUB_LIB_PATH for tkConfig.sh [Bug #826614]

* unix/Makefile.in (SHLIB_LD_FLAGS): include in Makefile as it is used in MAKE_LIB sometimes (ie: AIX-64) [Bug #829686] (jimix)

* win/configure: * win/configure.in: define TK_LIB_FLAG, TK_LIB_SPEC, TK_BUILD_LIB_SPEC, TK_STUB_LIB_SPEC, TK_STUB_LIB_PATH, and TK_BUILD_STUB_LIB_PATH for tkConfig.sh [Bug #826614]

* unix/Makefile.in (SHLIB_LD_FLAGS): include in Makefile as it is used in MAKE_LIB sometimes (ie: AIX-64) [Bug #829686] (jimix)

* generic/tkImgPhoto.c (ImgPhotoBlendComplexAlpha): add alpha blending for images with partial transparency. Only operates for 15bpp+ display, and not on Mac at all. [Bug 809157]

* generic/tkImgPhoto.c (ImgPhotoBlendComplexAlpha): OS X uses 32bpp images internally always, so make use of the assumption.

* generic/tkImgPhoto.c (ImgPhotoBlendComplexAlpha): add alpha blending for images with partial transparency. Only operates for 15bpp+ display. [Bug 809157]

* library/tkfbox.tcl (IconList_Create,IconList_Add): Added option munging to allow some control of foreground colours on Unix in the same way that you can influence the background. [Bug 795717]

* library/tkfbox.tcl (IconList_Create,IconList_Add): Added option munging to allow some control of foreground colours on Unix in the same way that you can influence the background. [Bug 795717]

* tests/focusTcl.test (setup1): expand frame size to allow for correct visibility of windows that use larger default fonts.

* win/tkWinImage.c (XGetImageZPixmap): add separate 16bpp XGetImage code to correctly handle 16bpp requests. This appears to never have worked correctly.

* unix/tkUnixFont.c (GetFontAttributes): place extra check for NULL family against bad X servers.

* tests/focusTcl.test (setup1): expand frame size to allow for correct visibility of windows that use larger default fonts.

* win/tkWinImage.c (XGetImageZPixmap): add separate 16bpp XGetImage code to correctly handle 16bpp requests. This appears to never have worked correctly.

* unix/tkUnixFont.c (GetFontAttributes): place extra check for NULL family against bad X servers.

2003-10-23 Jim Ingham <[email protected]>

* macosx/tkMacOSXDialog.c (NavServicesGetFile): Minor cleanups. (OpenFileFilterProc): Handle FSRef's as well as FSSpec's in the input file. Also convert the FSSpec filename to an C-string before passing to MatchOneFile. [bug 517600] (MatchOneFile): Require the input filename to be a C-string, not a pascal string.

* win/makefile.vc: Applied patches from tcl bug #801467 from * win/winMain.c: Joe Mistachkin

* generic/tkInt.h: move TkGetOptionSpec to stubs intDecls * generic/tkIntDecls.h: * generic/tkInt.decls: * generic/tkStubInit.c: * tkDecls.h: updated with latest genstubs * tkIntPlatDecls.h: * tkIntXlibDecls.h: * tkPlatDecls.h:

* generic/tkInt.h: move TkGetOptionSpec to stubs intDecls * generic/tkIntDecls.h: * generic/tkInt.decls: * generic/tkStubInit.c:

* unix/mkLinks: * doc/GetHWND.3: add Tk_AttachHWND docs [Bug #220803]

* tests/listbox.test (13.3): correct result size (4.7): correct test for possible window drift [Bug #701931] (dgp)

* unix/mkLinks: * doc/GetHWND.3: add Tk_AttachHWND docs [Bug #220803]

* mac/tkMacButton.c (TkpDisplayButton): * macosx/tkMacOSXButton.c (TkpDisplayButton): * unix/tkUnixButton.c (TkpDisplayButton): correct imageYOffset for buttons with just images.

* mac/tkMacButton.c (TkpDisplayButton): * macosx/tkMacOSXButton.c (TkpDisplayButton): * unix/tkUnixButton.c (TkpDisplayButton): correct imageYOffset for buttons with just images.

* win/tcl.m4: Add TIP #150 items to the TEA makefiles. * win/configure: * win/Makefile.in:

* win/tkWinSend.c: Clean up some warnings from gcc -Wall. * win/tkWinSendCom.c:

* doc/ConfigWidg.3: Removed reference to Tk_Offset from the NAME section to resolve mkLinks conflict with SetOptions.3 [Bug 404197] * unix/mkLinks: make mklinks

* unix/mkLinks: make mklinks

* doc/ConfigWidg.3: Removed reference to Tk_Offset from the NAME section to resolve mkLinks conflict with SetOptions.3 [Bug 404197]

* win/configure: * win/tcl.m4: removed incorrect checks for existence of optimization. TCL_CFG_OPTIMIZED is now defined whenever the user does not build with --enable-symbols.

*unix/configure.in: Reconfigured to use $TCL_PREFIX as the default value of --prefix, and also added warning when a TK_PREFIX value different from TCL_PREFIX is selected, since [package require Tk] fails in that configuration. [Bugs 428627,765642]

* unix/configure: autoconf (2.57)

*unix/configure.in: Reconfigured to use $TCL_PREFIX as the default value of --prefix, and also added warning when a TK_PREFIX value different from TCL_PREFIX is selected, since [package require Tk] fails in that configuration. [Bug 765642]

* unix/configure: autoconf (2.13)

* unix/tcl.m4 (SC_PATH_TCLCONFIG): Corrected search path so that alpha and beta releases of Tcl are not favored. [Bug 608698]

* unix/configure: autoconf (2.57)

* unix/tcl.m4 (SC_PATH_TCLCONFIG): Corrected search path so that alpha and beta releases of Tcl are not favored. [Bug 608698]

* unix/configure: autoconf (2.13)

* unix/configure.in: Added check that version of Tcl header found by configure matches that of the Tk we wish to build. As long as the Tk sources insist on lockstep releases, Tk's configuration should verify that's what we have. [Bug 749088]

* unix/configure: autoconf (2.57)

* unix/configure.in: Added check that version of Tcl header found by configure matches that of the Tk we wish to build. As long as the Tk sources insist on lockstep releases, Tk's configuration should verify that's what we have. [Bug 749088]

* unix/configure: autoconf (2.13)

* README: Bumped to patch level 8.4.5 * generic/tk.h: to prepare for next patch * macosx/Wish.pbproj/project.pbxproj: release. * unix/configure.in: * unix/tk.spec: * win/configure.in:

* unix/configure: autoconf (2.13) * win/configure:

* library/scale.tcl: Clear bug with chording mouse buttons.

* library/scale.tcl: Clear bug with chording mouse buttons.

* library/console.tcl: Avoid including the console in the list of interpreters exposed by [winfo interps].

* macosx/Wish.pbproj/project.pbxproj: * macosx/Makefile: fixed redo prebinding bug when DESTDIR="". Added support for all applicable customizable makefile variables from tcl/macosx/Makefile.

* macosx/README: * macosx/Wish.pbproj/project.pbxproj: ensure that the versioned wishX.X script works correctly when Tk.framework with multiple versions is present by referring to a copy of 'Wish Shell.app' located in Tk.framework/Versions/X.X/Resources.

* macosx/Wish.pbproj/project.pbxproj: * macosx/Makefile: fixed redo prebinding bug when DESTDIR="". Added support for all applicable customizable makefile variables from tcl/macosx/Makefile.

* macosx/README: * macosx/Wish.pbproj/project.pbxproj: ensure that the versioned wishX.X script works correctly when Tk.framework with multiple versions is present by referring to a copy of 'Wish Shell.app' located in Tk.framework/Versions/X.X/Resources.

* win/makefile.vc: Implementation of TIP #150, "Provide * win/tkWinSend.c: 'send' command for Windows" * win/tkWinSendCom.h: * win/tkWinSendCom.c:

* library/demos/widget: don't create iconwindow on aqua, but add about menu like on classic. * macosx/Makefile: pass MAKEOVERRIDES to pxbuild. * macosx/tkMacOSXButton.c: added -compound support for bevel buttons.

* library/demos/widget: don't create iconwindow on aqua, but add about menu like on classic. * macosx/Makefile: pass MAKEOVERRIDES to pxbuild. * macosx/tkMacOSXButton.c: added -compound support for bevel buttons.

* unix/configure: * unix/configure.in: * unix/tkConfig.sh.in: added TK_INCLUDE_SPEC to allow extensions to find installed Tk headers, parallel to TCL_INCLUDE_SPEC. [Bug 777203]

* generic/tkImage.c: Stopped [image create] from generating an * tests/image.test: image command name that would overwrite an existing command name. Thanks to Michael Schlenker. [Bug 808039].

* generic/tkImage.c: Stopped [image create] from generating an * tests/image.test: image command name that would overwrite an existing command name. Thanks to Michael Schlenker. [Bug 808039].

* doc/wish.1: Implementation of TIPs 137/151. * generic/tkMain.c (Tk_MainEx): Added recognition of the -encoding * tests/main.test: command line option by Tk_MainEx() and thus by wish, and any other program built on Tk_MainEx(). [Patch 800139]. This is a ***POTENTIAL INCOMPATIBILITY*** only for those C programs that embed Tcl and Tk, build on Tk_MainEx(), and make use of Tk_MainEx's former ability to pass a leading "-encoding" option to interactive shell operations.

* win/tkWin3d.c: Applied Tk patch 791273 from Jeremy Collins which improves the 3d lines for sunken widgets under windows.

* library/demos/widget: Redo code view dialog, use named fonts, * library/demos/arrow.tcl: add basic see/dismiss routine with * library/demos/bind.tcl: images for better look & feel * library/demos/bitmap.tcl: * library/demos/button.tcl: * library/demos/check.tcl: * library/demos/clrpick.tcl: * library/demos/colors.tcl: * library/demos/cscroll.tcl: * library/demos/ctext.tcl: * library/demos/entry1.tcl: * library/demos/entry2.tcl: * library/demos/entry3.tcl: * library/demos/filebox.tcl: * library/demos/floor.tcl: * library/demos/form.tcl: * library/demos/hscale.tcl: * library/demos/icon.tcl: * library/demos/image1.tcl: * library/demos/image2.tcl: * library/demos/items.tcl: * library/demos/label.tcl: * library/demos/labelframe.tcl: * library/demos/menu.tcl: * library/demos/menubu.tcl: * library/demos/paned1.tcl: * library/demos/paned2.tcl: * library/demos/plot.tcl: * library/demos/puzzle.tcl: * library/demos/radio.tcl: * library/demos/ruler.tcl: * library/demos/sayings.tcl: * library/demos/search.tcl: * library/demos/spin.tcl: * library/demos/states.tcl: * library/demos/style.tcl: * library/demos/text.tcl: * library/demos/twind.tcl: * library/demos/unicodeout.tcl: * library/demos/vscale.tcl:

* win/configure: Regen. * win/tcl.m4: Update from Tcl to fix Tcl bug 781109.

* library/scale.tcl: Fix for bug #787065 for Button-2 press. * tests/scale.test: Added test for this bug.

* library/scale.tcl: Fix for bug #787065 for Button-2 press. * tests/scale.test: Added test for this bug.

* macosx/tkMacOSXMenu.c: fixed C99'ism that breaks gcc 2.95.

* macosx/tkMacOSXMenu.c: fixed C99'ism that breaks gcc 2.95.

* win/tkWinDialog.c: Applied patch from bug #611615 which fixes a problem with double clicks in file dialogs falling through to the window underneath in win32.

* library/panedwindow.tcl: Apply patch from bug #778893 to make the panedwindow -opaqueresize option work as per the docs.

* library/tk.tcl: Apply fix for bug #778840 for window placement when using multiple desktops on windows.

* macosx/buildTkConfig.tcl: fix to TK_BUILD_* ref generation broken by changes to tcl buildsystem.

* macosx/buildTkConfig.tcl: fix to TK_BUILD_* ref generation broken by changes to tcl buildsystem.

* unix/tkUnixFont.c (Tk_DrawChars): do not make XGetGeometry call that prevents overwidth lines as it requires a roundtrip call to the X server for every string drawn. Hard-code max width to 32768 until a beter solution to get max width is made.

* unix/tkUnixFont.c (Tk_DrawChars): do not make XGetGeometry call that prevents overwidth lines as it requires a roundtrip call to the X server for every string drawn. Hard-code max width to 32768 until a beter solution to get max width is made.

* library/panedwindow.tcl: use widget-specific Priv slots for pwAfterId and panecursor items to correctly handle cursor changes with adjacant panedwindows.

* library/panedwindow.tcl: use widget-specific Priv slots for pwAfterId and panecursor items to correctly handle cursor changes with adjacant panedwindows.

* win/tkWinCursor.c: Applied misplaced Tcl RFE 700799 to provide the windows hand cursor where available.

* win/tkWinCursor.c (TkGetCursorByName): Fix bug 420510 to provide consistency between unix and windows -cursor option.

* generic/tkEvent.c (Tk_HandleEvent): correct XCreateIC call for TK_XIM_SPOT usage. [Bug 742660] (takahashi)

* win/tkWinCursor.c (TkGetCursorByName): Fix bug 420510 to provide consistency between unix and windows -cursor option. (thoyts)

* generic/tkEvent.c (Tk_HandleEvent): correct XCreateIC call for TK_XIM_SPOT usage. [Bug 742660] (takahashi)

* win/tkWinDialog.c: doubled the TK_MULTI_MAX_PATH value to ~10K. This is a short-term solution until the -multiple option is extended. [Bug 641261]

* win/tkWinDialog.c: doubled the TK_MULTI_MAX_PATH value to ~10K. This is a short-term solution until the -multiple option is extended. [Bug 641261]

* macosx/Makefile: Changes for new tcl buildsystem.

* macosx/Wish.pbproj/jingham.pbxuser: * macosx/Wish.pbproj/project.pbxproj: Changes for new tcl buildsystem. Changed build to include tk specific html help in Tk.framework instead of Tcl.framework. Set default SYMROOT in target options to simplify setting up PB (manually setting common build folder for tcl & tk no longer needed).

* macosx/README: Updated info for changes to buildsystem, html help location and PB setup.

* macosx/Makefile: Changes for new tcl buildsystem.

* macosx/Wish.pbproj/jingham.pbxuser: * macosx/Wish.pbproj/project.pbxproj: Changes for new tcl buildsystem. Changed build to include tk specific html help in Tk.framework instead of Tcl.framework. Set default SYMROOT in target options to simplify setting up PB (manually setting common build folder for tcl & tk no longer needed).

* macosx/README: Updated info for changes to buildsystem, html help location and PB setup.

* generic/tkPack.c (ConfigureSlaves): silence compiler warning [Bug 771982]

* generic/tkPack.c (ConfigureSlaves): silence compiler warning [Bug 771982]

* win/tkWinImage.c (XGetImage): correct init of biSizeImage in bitmap header. [Bug 703697] (cap)

* win/tkWinImage.c (XGetImage): correct init of biSizeImage in bitmap header. [Bug 703697] (cap)

* generic/tkPanedWindow.c (ArrangePanes): Ensure that the last pane * tests/panedwindow.test: shrinks instead of being clipped when resized below the reqsize. [Bug 748277] (spjuth)

* generic/tkPanedWindow.c (ArrangePanes): Ensure that the last pane * tests/panedwindow.test: shrinks instead of being clipped when resized below the reqsize. [Bug 748277] (spjuth)

* generic/tkWindow.c (Initialize): do not free uninit'ed dstring. [Bug 755906] (mistachkin)

* generic/tkWindow.c (Initialize): do not free uninit'ed dstring. [Bug 755906] (mistachkin)

* unix/tkUnixEvent.c (TkpCloseDisplay): Don't test for XCloseIM bug when the XFree86 version is newer than 4.0 since the layout of the XIM structure has changed. The check is not needed for newer XFree86 releases since the bug we are checking for was fixed in the 4.2.99.2 release. [Bug 755530]

* README: Bumped patchlevel to 8.4.4 in preparation * generic/tk.h: for the Tk 8.4.4 release. * macosx/Wish.pbproj/project.pbxproj: * unix/configure.in: * unix/tk.spec: * win/configure.in:

* unix/configure: autoconf (2.13) * win/configure:

* generic/tkTextDisp.c (DisplayText): correct use of textPtr data with respect to Tcl_Release time. [Bug #767009]

* unix/tkUnixEvent.c (TkpCloseDisplay): Don't test for XCloseIM bug when the XFree86 version is newer than 4.0 since the layout of the XIM structure has changed. The check is not needed for newer XFree86 releases since the bug we are checking for was fixed in the 4.2.99.2 release. [Bug 755530]

* unix/mkLinks: Set the var S to "" at the top of the file to avoid error when user has set S to something. [Tk Bug #739833]

* unix/Makefile.in: do not run autoconf during 'make dist' as the configure is now a CVS-maintained file and should be up-to-date.

* macosx/Wish.pbproj/project.pbxproj: changed tkConfig.sh location in versioned framework subdirectories to be identical to location in framework toplevel; fixed stub library symbolic links to be tk version specific.

* macosx/Wish.pbproj/project.pbxproj: changed tkConfig.sh location in versioned framework subdirectories to be identical to location in framework toplevel; fixed stub library symbolic links to be tk version specific.

* unix/tkUnixFont.c: use gb2312-raw as the alias for gb2312* charset fonts. gb2312.enc was made to be euc-cn for Tcl because that is what is most often meant, but X really wants the original (-raw) gb2312 encoding. [Bug 557030]

* unix/tkUnixFont.c: use gb2312-raw as the alias for gb2312* charset fonts. gb2312.enc was made to be euc-cn for Tcl because that is what is most often meant, but X really wants the original (-raw) gb2312 encoding. [Bug 557030]

* library/msgs/fr.msg: updated msg catalog. [Bug #737790] (zolli)

* library/msgs/fr.msg: updated msg catalog. [Bug #737790] (zolli)

* macosx/tkMacOSXInit.c (TkpInit): use new versioned bundle resource API to get tk runtime library for TK_VERSION. [Bug 736774]

* macosx/tkMacOSXInit.c (TkpInit): use new versioned bundle resource API to get tk runtime library for TK_VERSION. [Bug 736774]

backport of Mac OS X specific changes on trunk since 8.4.2:

* macosx/tkMacOSXClipboard.c (TkSelGetSelection): Convert '\r' to '\n' on the way into Tcl. (ingham)

* macosx/tkMacOSXMenu.c (EventuallyInvokeMenu): New function, used to invoke menu commands at idle time. (TkMacOSXDispatchMenuEvent): Don't immediately dispatch menu commands, wait till the idle loop to do so. This is more like what is done on Windows, and avoids the crash from destroying a menu in it's command. (ingham)

* macosx/tkMacOSXHLEvents.c (ReallyKillMe): Don't force the shell to exit. According to the OS X HI guidelines, it should be possible to cancel an attempt to quit, and if we force the kill, here, it would not be possible to implement this. (ingham)

* macosx/tkMacOSXApplication.r (removed): * macosx/tkMacOSXLibrary.r (removed): * macosx/tkMacOSXResource.r (removed): * macosx/Wish.pbproj/project.pbxproj: * macosx/tkAboutDlg.r: updated copyrights, cleaned up about box, removed obsolete unused resource files. (steffen)

* generic/tkCanvPoly.c (PolygonToPostscript): * tests/canvPs.test: correct crash when generating postscript for a single-line polygon (point) with no color. [Bug #734498] (wilm)

* generic/tkCanvPoly.c (PolygonToPostscript): * tests/canvPs.test: correct crash when generating postscript for a single-line polygon (point) with no color. [Bug #734498] (wilm)

* macosx/tkMacOSXButton.c (TkpDisplayButton): correct typo for stippleGC [Bug #730124].

* macosx/tkMacOSXButton.c (TkpDisplayButton): correct typo for stippleGC [Bug #730124].

* generic/tkButton.h: Rewrote the handling * generic/tkButton.c (TkButtonWorldChanged): of compound *buttons * mac/tkMacButton.c (TkpDisplayButton): to correctly display * macosx/tkMacOSXButton.c (TkpDisplayButton): mixture of disabledfg, * unix/tkUnixButton.c (TkpDisplayButton): selectcolor, indicator, * win/tkWinButton.c (TkpDisplayButton): etc. *buttons will now only stipple the image, unless no disabledfg is given, in which case it will stipple the whole button.

* generic/tkButton.h: Rewrote the handling * generic/tkButton.c (TkButtonWorldChanged): of compound *buttons * mac/tkMacButton.c (TkpDisplayButton): to correctly display * macosx/tkMacOSXButton.c (TkpDisplayButton): mixture of disabledfg, * unix/tkUnixButton.c (TkpDisplayButton): selectcolor, indicator, * win/tkWinButton.c (TkpDisplayButton): etc. *buttons will now only stipple the image, unless no disabledfg is given, in which case it will stipple the whole button.

* unix/tkUnixButton.c (TkpDisplayButton): Use the normalTextGc when * win/tkWinButton.c (TkpDisplayButton): displaying disabled text that have images, as they get a gray50 stipple as well and the disabledGc is not set up correctly for font drawing. [Bug #477740]

* library/bgerror.tcl: make bgerror dialog topmost on Windows to prevent it being covered by other windows.

* unix/tkUnixButton.c (TkpDisplayButton): Use the normalTextGc when * win/tkWinButton.c (TkpDisplayButton): displaying disabled text that have images, as they get a gray50 stipple as well and the disabledGc is not set up correctly for font drawing. [Bug #477740]

* library/bgerror.tcl: make bgerror dialog topmost on Windows to prevent it being covered by other windows.

* generic/tkCursor.c: s/GetCursor/TkcGetCursor as Windows has a GetCursor func already, which causes compiler warnings.

* generic/tkCanvBmap.c: s/CreateBitmap/TkcCreateBitmap as Windows has a CreateBitmap function already.

* win/configure: regen * win/configure.in (SHELL): force it to /bin/sh as autoconf 2.5x uses /bin/bash, which can fail to find exes in the path (ie: lib).

* generic/tkCanvBmap.c: s/CreateBitmap/TkcCreateBitmap as Windows has a CreateBitmap function already.

* generic/tkCursor.c: s/GetCursor/TkcGetCursor as Windows has a GetCursor func already, which causes compiler warnings.

* win/tkWinMenu.c (TkpInitializeMenuBindings): Rename the private menu helper cmd from tk::tkWinMenuKey to tk::WinMenuKey. [Bug 721514]

* generic/tkBind.c (TkpGetBindingXEvent): Add helper method that can be used to query the XEvent* for the currently executing binding. * generic/tkInt.h: Declare TkpGetBindingXEvent. * win/tkWinMenu.c (MenuKeyBindProc, TkWinMenuKeyObjCmd, TkpInitializeMenuBindings): Rename MenuKeyBindProc to TkWinMenuKeyObjCmd and convert it into a Tcl command named tk::tkWinMenuKey. Bind keyboard accelerator actions to this Tcl command instead of using a native C binding. This makes it possible to extend the existing binding with Tcl code and makes the Windows version work just like the unix version.

* unix/Makefile.in: Subst TCL_LIBS instead of DL_LIBS and MATH_LIBS. * unix/configure: Regen. * unix/configure.in: Remove SC_ENABLE_THREADS invocation. Thread support in an extension should be automatic when Tcl is compiled with thread support. Add AC_DEFINE calls to set TCL_THREADS, _REENTRANT, and _THREAD_SAFE since this was done in SC_ENABLE_THREADS. Remove socket and math lib checks since these are already done in the Tcl configure script. * unix/tcl.m4: Update from Tcl to get TCL_LIBS fix. This fixes bug 597847 which was caused by improper linking. * unix/tkConfig.sh.in: Subst TCL_LIBS instead of MATH_LIBS and DL_LIBS. [Bug 597847]

* win/configure: Regen. * win/configure.in: Set stub lib flag based on new LIBFLAGSUFFIX variable. * win/tcl.m4: Update from Tcl to get new LIBFLAGSUFFIX variable.

* win/configure: Regen. * win/configure.in: Set stub lib flag based on new LIBFLAGSUFFIX variable. * win/tcl.m4: Update from Tcl to get new LIBFLAGSUFFIX variable.

* win/configure: Regen. * win/configure.in: Don't set TCL_DLL_FILE, TCL_LIB_FILE, TCL_STUB_LIB_FILE, TCL_STUB_LIB_FLAG, and TCL_BUILD_STUB_LIB_SPEC. These variables are already set in tclConfig.sh. [Bug 691908]

* win/configure: Regen. * win/configure.in: Don't set TCL_DLL_FILE, TCL_LIB_FILE, TCL_STUB_LIB_FILE, TCL_STUB_LIB_FLAG, and TCL_BUILD_STUB_LIB_SPEC. These variables are already set in tclConfig.sh. Don't subst vars that are either not used, or already covered by a subst in SC_LOAD_TCLCONFIG. [Bug 691908]

* unix/configure: Regen. * unix/tcl.m4: Update from Tcl.

* tests/all.tcl: Made better use of a common * tests/constraints.tcl: -loadfile to hold definitions * tests/*.test: common to all test files.

* unix/configure: Regen. * unix/tcl.m4: Update from Tcl.

* unix/configure: Regen. * unix/tcl.m4: Update from Tcl to get BeOS changes.

* macosx/tkMacOSXApplication.r (removed): * macosx/tkMacOSXLibrary.r (removed): * macosx/tkMacOSXResource.r (removed): * macosx/Wish.pbproj/project.pbxproj: * macosx/tkAboutDlg.r: updated copyrights, cleaned up about box, removed obsolete unused resource files.

* macosx/buildTkConfig.tcl: TK_DEFS space fix.

* win/tkConfig.sh.in: Add TK_DLL_FILE entry to mirror the TCL_DLL_FILE entry in tclConfig.sh. [Patch 694271]

* win/configure: Regen. * win/configure.in: Don't run the AC_CYGWIN macro since it uses AC_CANONICAL_HOST under autoconf 2.5X. Just check to see if __CYGWIN__ is defined by the compiler and set the ac_cv_cygwin variable based on that. [Tcl Bug 705912]

* tests/unixWm.test (unixWm-41.2): Corrected typo in 2003-03-13 commit. Thanks Larry Virden. [Bug 705567]

* tests/unixWm.test (unixWm-41.2): Corrected typo in 2003-03-13 commit. Thanks Larry Virden. [Bug 705567]

* macosx/Wish.pbproj/project.pbxproj: * macosx/Makefile: * macosx/README: added support for giving 'make' the location of Tcl.framework and tclsh to build and link against.

* macosx/tkMacOSXXStubs.c: fixed crash in [winfo server].

* macosx/Wish.pbproj/project.pbxproj: * macosx/Makefile: * macosx/README: added support for giving 'make' the location of Tcl.framework and tclsh to build and link against.

* macosx/tkMacOSXXStubs.c: fixed crash in [winfo server].

* tests/unixWm.test: Constrained all tests older than revision 1.21 to run only on Unix. Alternative approach did not match maintainer habits. * tests/spinbox.test (spinbox-17.4): Avoid long failure message.

* tests/unixWm.test: Constrained all tests older than revision 1.21 to run only on Unix. Alternative approach did not match maintainer habits. * tests/spinbox.test (spinbox-17.4): Avoid long failure message.

Require autoconf 2.57 or newer, see TIP 34 for a detailed explanation of why this is good. This will no doubt break the build on some platforms, let the flaming begin.

* unix/configure: Regen with autoconf 2.57. * unix/configure.in: Require autoconf 2.57. * unix/tcl.m4: Update from Tcl. * win/configure: Regen with autoconf 2.57. * win/configure.in: Require autoconf 2.57. * win/tcl.m4: Update from Tcl.

* macosx/tkMacOSXMenu.c (EventuallyInvokeMenu): New function, used to invoke menu commands at idle time. (TkMacOSXDispatchMenuEvent): Don't immediately dispatch menu commands, wait till the idle loop to do so. This is more like what is done on Windows, and avoids the crash from destroying a menu in it's command.

* macosx/tkMacOSXHLEvents.c (ReallyKillMe): Don't force the shell to exit. According to the OS X HI guidelines, it should be possible to cancel an attempt to quit, and if we force the kill, here, it would not be possible to implement this.

* tests/unixWm.test: Add the testwrapper constraint to tests that depend on the testwrapper command. These tests should not be run under Windows for example.

* doc/wm.n (minimize, maximize): Remove claim that the resizable command keeps scripts from changing the size of windows since it is not true. The resizable command only applies to user sizing via user interaction. * tests/unixWm.test: Replace broken tests with the nonPortable constraint with new tests for maxsize and minsize options. These tests verify that setting the minsize and maxsize will resize the window if needed, and that the wm hints will be updated with the new sizes. * tests/wm.test: Add an exhaustive set of tests for the wm maxsize and wm minsize commands. These tests verify that setting the minsize and maxsize will resize the window if needed. These tests have only been run under Win98 and Window Maker under Linux, so further tweaking may be needed for other systems. * unix/tkUnixWm.c (UpdateGeometryInfo, UpdateSizeHints): Fixup comments and initialization for the minWidth, minHeight, maxWidth, maxHeight, width, and height members of the WmInfo struct. Check to ensure that a new toplevel window size is not larger than the maxsize or smaller than the minsize when updating the geometry at idle time. Pass new width and height values to the UpdateSizeHints method so that it can properly set the window min and max sizes for a window that cannot be resized by the user. This fixes a bug where the window resizes back to the original size when the user clicks on the window border. * win/tkWinWm.c (UpdateGeometryInfo): Fixup comments and initialization for the minWidth, minHeight, maxWidth, maxHeight, width, and height members of the WmInfo struct. Check to ensure that a new toplevel window size is not larger than the maxsize or smaller than the minsize when updating the geometry at idle time. [Patch 568861]

* generic/tkGrid.c (GridStructureProc, ConfigureSlaves): Check for a NULL masterPtr and slavePtr in the GridStructureProc code to ensure that a Gridder created before some error condition is ignored when it comes to geometry calculations. This approach closely matches the pack implementation. Keep track of a -in argument to a grid command in order to detect the case of an already gridded widget that wants to change some options. The previous implementation could make repeated and unnecessary calls to Tk_ManageGeometry. Replace use of "parent" with "master" in comments throughout the file. * generic/tkPack.c (PackStructureProc): Check for a NULL masterPtr before other checks so that a slave created under certain error conditions is cleaned up properly. Replace use of "parent" with "master" in comments throughout the file. * generic/tkPlace.c (CreateSlave, ConfigureSlave, SlaveStructureProc): Don't call Tk_ManageGeometry in CreateSlave since this was causing incorrect results in some error cases. Rework the ConfigureSlave method so that slave setup is done in one place. The call to Tk_ManageGeometry was added to the one place where a slave is setup. When a slave is configured but the master is not changed, simply goto the scheduleLayout label. Check for a NULL master in SlaveStructureProc for the sake of readability. * tests/grid.test: * tests/pack.test: * tests/place.test: Add test to check that a winfo manager call does not return incorrect results after an error condition is hit. [Patch 693063]

* README: Bumped version number of * generic/tk.h: Tk to 8.5a0. * library/tk.tcl: * mac/README: * macosx/Wish.pbproj/project.pbxproj: * unix/README: * unix/configure.in: * unix/tk.spec: * win/README: * win/configure.in: * win/makefile.vc: * win/tcl.m4:

* unix/configure: autoconf * win/configure:

* win/tkWinInt.h: * win/tkWinDraw.c: * win/tkWinFont.c (Tk_DrawChars): add support for simple XOR text drawing on Windows. [Patch #685388] (martin)

* generic/tkMenu.c (TkMenuCleanup): make sure to reset static menusInitialized on finalize. [Bug #548729]

* macosx/tkMacOSXHLEvents.c: fixed conversion of apple event parameters to posix style path names. [Bug #621672] (steffen, Benjamin Riefenstahl)

* macosx/tkMacOSXHLEvents.c: fixed conversion of apple event parameters to posix style path names. [Bug #621672] (steffen, Benjamin Riefenstahl)

* macosx/tkMacOSXDialog.c: * macosx/tkMacOSXWm.c: * macosx/Wish.pbproj/project.pbxproj: * macosx/tkMacOSXUtil.c (removed): * macosx/tkMacOSXUtil.h (removed): removed all references to tkMacOSXUtil.{c,h}, made obsolete by the patch above. [Bug #621672]

* unix/tkUnixFont.c (CreateClosestFont, CanUseFallback): use the first best font match in user font path. [Bug #647497] (dal zotto)

* generic/tkListbox.c (ListboxSelectionSubCmd): * tests/listbox.test: Allow 'selection includes' to respond when disabled (but only 'includes'). [Bug #632514]

* unix/tkUnixButton.c (TkpDisplayButton): Correct visual display of disabled check/radiobutton to be more distinctive on unix. * tests/unixButton.test: [Bug #669595] (hintermayer)

* doc/panedwindow.n: clarified the need to use 'update idle' when adding unmapped windows. Needs further examination. [Bug #605105]

* generic/tkEntry.c (SpinboxWidgetObjCmd, EntryWidgetObjCmd): * tests/entry.test: return 1 if selection is present even if * tests/spinbox.test: entry/spinbox is disabled, as selection get will still return the selection (although selection still ignore modify requests when entry/spinbox is disabled). [Bug #637828]

* tkMacOSXDialog.c (NavServicesGetFile): Fix bug with kNavCtlSetSelection - control data should be a pointer not a handle.

* library/clrpick.tcl (color::BuildDialog): * library/msgbox.tcl (MessageBox): Yet more places that did complex and fragile width calculations instead of using grid, though with these it is the -uniform option that saves the day.

* library/comdlg.tcl (FDGetFileTypes): Set an upper limit on how long a file type item description string can get due to appending of types. [Bug #617392]

* library/console.tcl: (aqua & macintosh) added missing <Cmd-q> binding for corresponding Quit menu item shortcut.

* macosx/README: updated instructions for embedded build, added various improvements by Russell Owen.

* unix/tcl.m4: update from Tcl. * unix/configure: regen.

* win/tkWinScrlbr.c (UpdateScrollbar): use SIF_DISABLENOSCROLL to "disable" scrollbar when on Windows when there is nothing to scroll. This is Windows style, and fixes [Bug #624116].

* tests/panedwindow.test: * generic/tkPanedWindow.c (ValidSashIndex): corrected to note that 2 panes must exist before any one sash does. [tcllib Bug #689258]

* macosx/tkMacOSXKeyEvent.c: fix for uninitialized var warning.

* tkMacOSXMouseEvents.c (GeneratePollingEvents): In the case where there was a capture window, we were sending the events to the capture window. But the capture window (return value or TkMacOSXGetCapture) is always a toplevel. So this is wrong in the case that the Event's toplevel IS the capture window - in which case the event should go to the subwindow most closely containing the event.

Fixes bug #688188 check-in: 5d2aee48 user: wolfsuit tags: trunk

* doc/entry.n: * doc/text.n: Update double and triple click docs to match implementation changes made on 2002-02-14.

* macosx/Wish.pbproj/project.pbxproj: * macosx/Makefile: reworked embedded build to no longer require relinking but to use install_name_tool instead to change the install_names for embedded frameworks.

* unix/configure: Regen. * unix/tcl.m4: Update from Tcl.

* library/tk.tcl (::tk::TabToWindow): auto-highlight spinboxes as well as entries when tabbing in. [Patch #683813] (bron)

* library/xmfbox.tcl (::tk::MotifFDialog_ActivateSEnt): correct sub on embedded newlines. [Patch #688572] (bonfield)

* win/tkWinInit.c (TkpDisplayWarning): truncate MessageBox string to 1024 chars to prevent possible oversized window errors. May be necessary in other MB uses (ie Tcl_AppInit). [Tcl Bug #608559]

* generic/tkImgGIF.c (FileReadGIF): Ensure that the trashBuffer is always deallocated on function exit to stop a potential memory leak.

* generic/tkEvent.c (Tk_HandleEvent): Fixup button press state saving code, it was incorrectly converting normal motion events into button press and motion events in some cases. * generic/tkInt.h: Add mouseButtonWindow member to the TkDisplay structure. * tests/event.test: Add test case for faulty button motion logic.

* README: Bumped to 8.4.2. * generic/tk.h: * macosx/Wish.pbproj/project.pbxproj: * unix/configure: * unix/configure.in: * unix/tcl.m4: * unix/tk.spec: * win/configure: * win/configure.in:

* macosx/tkMacOSXCursor.c (TkMacOSXInstallCursor): Set all theme cursors using SetThemeCursor or SetAnimatedThemeCursors. (TkGetCursorByName): Use the theme cursors for arrow, ibeam, etc. Allow animatedCursor{NUM} form for an animated cursor with count. (TkpSetCursor): Don't reset the cursor if there is no change. * macosx/tkMacOSXMouseEvent.c (GeneratePollingEvents): Don't directly call TkMacOSXInstallCursor, it gets called by the call to Tk_UpdatePointer immediately above.

* macosx/tkMacOSXCursor.c (TkMacOSXInstallCursor): Set all theme cursors using SetThemeCursor or SetAnimatedThemeCursors. (TkGetCursorByName): Use the theme cursors for arrow, ibeam, etc.

* macosx/tkMacOSXWm.c (Tk_SetGrid): Fix precedence problem with * mac/tkMacWm.c (Tk_SetGrid): '==' and '|'.

* generic/tkCanvArc.c (CreateArc): Rework canvas create item * generic/tkCanvBmap.c (CreateBitmap): type coords handling to be * generic/tkCanvImg.c (CreateImage): consistent across types * generic/tkCanvPoly.c (CreatePolygon): and not pass empty coords * generic/tkCanvLine.c (CreateLine): to item creation procs. * generic/tkCanvText.c (CreateText): * generic/tkCanvWind.c (CreateWinItem): * generic/tkCanvas.c (CanvasWidgetCmd CANV_CREATE): * generic/tkRectOval.c (CreateRectOval): * tests/canvRect.test: * tests/canvText.test: * tests/canvas.test:

* generic/tkImage.c (Tk_ImageObjCmd): Added check to make sure that you're not creating an image named the same as .'s command, which refixes 220891, even when the name of the command has been changed with 'rename'. The error message is better too. * generic/tkFrame.c (TkToplevelWindowForCommand): Added way of mapping from command names to tkwins-for-toplevels. * tests/image.test (image-1.10,image-1.11): Updated to match new error message and added test for the rename case. * generic/tclInt.decls: Made TkToplevelWindowForCommand exported privately.

* generic/tkImage.c (DeleteImage): delete the image's entry in the image table correctly when there are no more instances. This reopens bug 220891. [Bug #669759]

* doc/loadTk.n: note that ::safe::loadTk has a prereq on ::safe::interpCreate or ::safe::interpInit. [Bug #669159]

* doc/photo.n: $image put only accepts -format and -to, and note extended use of -to.

* win/tkWinDialog.c (Tk_ChooseDirectoryObjCmd, ChooseDirectoryValidateProc, Tk_MessageBoxObjCmd): Remove unused tsdPtr variable. Use TEXT macro instead of _T macro since _T does not work under Cygwin. Declare flags as UINT to avoid compiler warning when compiling with mingw.

* win/Makefile.in: Add TCL_DEFS to AC_FLAGS so that compiler flags defined by Tcl get passed to the compiler. Add empty rule for cat.c so that Tk compiles under msys. * win/configure: Regen. * win/tcl.m4: Update from Tcl, this pulls in a subst of TCL_DEFS, it also defines USE_THREAD_ALLOC when threads are used and it updates the SC_ENABLE_SYMBOLS and SC_PROG_TCLSH macros to match the ones used in Tcl.

* generic/tkFrame.c (CreateFrame): throw a Tcl error instead of a panic when we cannot get a main window and appname is NULL. This can indicate that a user tried to create a frame/toplevel while Tk was dying. [Bug #661792]

* generic/tkMain.c (Tk_Main): Call on Tcl*StartupScript*() routines to store the startup script, if any. [Bug 616245].

* generic/tkEntry.c (ConfigureEntry): keep a flag to indicate when a var is traced to prevent double-traces caused by configuring the widget in traces with validation on. (dejong)

* generic/tkInt.decls: add TkWinSetHINSTANCE decl * generic/tkIntPlatDecls.h: regen * generic/tkStubInit.c: regen * win/tkWinInit.c (TkpInit): While init and cleanup aren't correct * win/tkWinX.c (TkWinXInit): in DllMain, we had to specify the * win/tkWin32Dll.c (DllMain): true HINSTANCE or the resources of a dynamic Tk weren't being loaded correctly. Created a new function TkWinSetHINSTANCE for this purpose.