Tk Source Code

The native implementation in the file library/msgbox of the tk_messageBox is used on Linux and Androwish (https://core.tcl-lang.org/tk/file?name=library/msgbox.tcl&ln=313-314).

The wraplength of the contained ttk label widget is hard coded to "3i" and may be changed using the option data base (https://core.tcl-lang.org/tk/file?name=library/msgbox.tcl&ln=313-314).

The default of 3 inches is 76.2mm.

My Androwish device has a screen width of 65mm. Unfortunately, the message box does not fit, as borders and icon are also displayed.

This ticket proposes to limit the width of the message box to the physical screen width.

The branch [e19f1d891-messagebox-screensize] starting with commit [5a2361cd] has a proposed implementation.

A typical test message wraps at each 2nd character:

tk_messageBox -message [string repeat "1 " 100]

For me, this fits nearly exactly to the screen.

The related Androwish ticket is here: https://androwish.org/home/info/6cd64e3eeddaf1fd

Virtual Screen is left out. IMHO, this is outdated technology. But the implementation may easily be changed to use the virtual screen.

Any comment welcome !

Thanks, Harald

CI run is ok.

To test this, one may manually set the wrap length of the message box label above the screen width.

Here is my test script:

% winfo screenwidth .
1920
% option add *Dialog.msg.wrapLength [expr {[winfo screenwidth .]+100}]
% ::tk::MessageBox -message [string repeat "A123456789B123456789C123456789" 10]

The attached screenshot "messagebox_full_screen_with_without_patch.png" shows the patched version above, without patch below. This is on Windows. Of cause, this code is never active on Windows, as the native message box is used.

You may see, that the message is clipped without the patch, e.g. a part of the message is missing without the patch.

It may also be observed, that the placement is not exactly at the left border by tk::PlaceWindow. This is probably due to a windows manager border, not taken into account by the tk::PlaceWindow function.

The patch is clearly an improvement.

I will wait for Francois and merge, if it is ok for him.

Thanks for all, Harald

Sorry, forget everything starting with "BTW: ..."!

Thanks for the comment. I have taken this from Androwish: https://androwish.org/home/info/c2b6b889c539e9f7

I suppose, the Title bar height includes the frame...

Or am I missing something stupid?

Thanks for all, Harald

IMHO, that is a good idea.

BTW: In ::tk::PlaceWindow you have replaced

    incr y -[WMFrameWidth]

with

    incr y -[WMTitleHeight]

This is not quite correct!  It would be more accurate to restore the first statement and then add the second one:

    incr y -[WMFrameWidth]
    incr y -[WMTitleHeight]

Thanks for the great improvement. The message box now is exactly from one border to the next. That is neat, thanks for all.

As accorded (and a bit forced) with Christian and Csaba, I will merge to main when the CI is ok.

Thanks for all, Harald

The commit [1153477b] eliminates that open point, too.

Christian, Csaba,
thanks a lot for caring !
I really appreciate!

Open point for me:

   *   really place the window at "wm geometry +0".

Thanks for all,
Harald