|
2026-11-13
| ||
| 16:25 | • Ticket [b17dcd71] Windows: imgPhInstance-7.* test failures (wayland branch) status still Open with 3 other changes artifact: c63c6560 user: serhiy.storchaka | |
|
2026-10-29
| ||
| 15:33 | • Ticket [4af5ca19] XCopyArea is very (very) slow on macOS with version 9 status still Open with 3 other changes artifact: e1cbc4ab user: chrstphrchvz | |
|
2026-10-20
| ||
| 03:10 | • Ticket [32f2e19d] Windows: photo -gamma and -palette are ignored since RGBA rendering status still Closed with 5 other changes artifact: 00531299 user: chrstphrchvz | |
| 01:36 | • Closed ticket [32f2e19d]. artifact: 66ba28f9 user: marc_culler | |
| 01:35 | • Ticket [32f2e19d]: 4 changes artifact: b5d5221f user: marc_culler | |
|
2026-10-19
| ||
| 09:22 | • Ticket [8beb2a08] photo -gamma and -palette: apply them in software on platforms which render RGBA images status still Open with 6 other changes artifact: ca558b91 user: chrstphrchvz | |
| 04:18 | • Ticket [32f2e19d] Windows: photo -gamma and -palette are ignored since RGBA rendering status still Open with 3 other changes artifact: 5df6b812 user: chrstphrchvz | |
| 03:11 | • Ticket [32f2e19d]: 4 changes artifact: 36c32871 user: marc_culler | |
| 03:10 | • Add attachment DigitalColorMeter.png to ticket [32f2e19d] artifact: 5c0ef074 user: marc_culler | |
| 02:57 | • Open ticket [32f2e19d]: Windows: photo -gamma and -palette are ignored since RGBA rendering plus 5 other changes artifact: 3d6d6a34 user: marc_culler | |
|
2026-10-18
| ||
| 20:06 | • Ticket [de6ef827] imageName configure -gamma - has no effect on macOS status still Open with 3 other changes artifact: 130b2c98 user: serhiy.storchaka | |
| 07:17 | • Ticket [de6ef827]: 3 changes artifact: ded017d7 user: serhiy.storchaka | |
| 05:41 | Fix [de6ef8276c]: photo -gamma and -palette had no effect on macOS. Apply the fix for [32f2e19de8] to all platforms which render RGBA images, not only Windows: images without partial transparency and with a non-default -gamma or -palette are drawn from the pixmap of the instance. Run tests imgPhInstance-7.1 and 7.2 on Aqua too. closed check-in: 8316cf93 user: serhiy.storchaka tags: aqua-photo-gamma-palette | |
|
2026-10-17
| ||
| 10:14 | • Ticket [32f2e19d] Windows: photo -gamma and -palette are ignored since RGBA rendering status still Closed with 4 other changes artifact: 1aebf554 user: chrstphrchvz | |
| 10:13 | • New ticket [ff3965a5] Photo gamma and palette options ignored in some cases on X11. artifact: 677a11b2 user: chrstphrchvz | |
| 10:12 | • Ticket [de6ef827] imageName configure -gamma - has no effect on macOS status still Open with 3 other changes artifact: c7e29925 user: chrstphrchvz | |
|
2026-10-14
| ||
| 02:33 | • Ticket [32f2e19d] Windows: photo -gamma and -palette are ignored since RGBA rendering status still Closed with 5 other changes artifact: 1aa3ad4a user: chrstphrchvz | |
|
2026-09-29
| ||
| 19:32 | • Closed ticket [32f2e19d]. artifact: 53048d6f user: oehhar | |
| 19:29 | [32f2e1] MS-Win: photo -gamma and -palette are ignored check-in: 05a0704a user: oehhar tags: trunk, main | |
|
2026-09-28
| ||
| 15:21 | • Ticket [481255ff] palette 2 doesn't work for windows status still Open with 3 other changes artifact: 2a55f363 user: serhiy.storchaka | |
|
2026-09-24
| ||
| 20:45 | Add tests imgPhInstance-7.1 and 7.2 for -gamma and -palette [32f2e19de8]. closed check-in: b7178d60 user: serhiy.storchaka tags: win-photo-gamma-palette | |
| 19:20 | • Ticket [32f2e19d] Windows: photo -gamma and -palette are ignored since RGBA rendering status still Open with 3 other changes artifact: 86fcce64 user: serhiy.storchaka | |
| 13:55 | • Ticket [32f2e19d]: 3 changes artifact: e909aae0 user: serhiy.storchaka | |
| 13:53 |
Fix [32f2e19de8]: Windows: photo -gamma and -palette are ignored since RGBA rendering.
Draw the photo instance pixmap, where gamma correction and palette reduction are applied, when the instance has a non-default gamma or palette and the image has no partial transparency. check-in: c892f772 user: serhiy.storchaka tags: win-photo-gamma-palette | |
| 13:53 | • New ticket [32f2e19d] Windows: photo -gamma and -palette are ignored since RGBA rendering. artifact: dc4cfcbe user: serhiy.storchaka | |
| Ticket UUID: | 32f2e19de82946d0277b72dcb840b4753d6e643e | |||
| Title: | Windows: photo -gamma and -palette are ignored since RGBA rendering | |||
| Type: | Bug | Version: | 9.1b1 | |
| Submitter: | serhiy.storchaka | Created on: | 2026-09-24 13:53:02 | |
| Subsystem: | 41. Photo Images | Assigned To: | aku | |
| Priority: | 5 Medium | Severity: | Minor | |
| Status: | Closed | Last Modified: | 2026-10-20 03:10:58 | |
| Resolution: | Fixed | Closed By: | chrstphrchvz | |
| Closed on: | 2026-10-20 03:10:58 | |||
| Description: |
Since [3bbe54bc74] (merge of [7caf9e9e])
foreach {img opts} {plain {} gamma {-gamma 2}} {
image create photo $img -width 60 -height 60 {*}$opts
$img put #ffa500 -to 0 0 60 60
pack [label .$img -image $img] -side left
}
In 8.6 and 9.0 the right image is lighter than the left one, (255,205,0) instead of (255,165,0); in 9.1b1 both are the same orange.
foreach {img opts} {plain {} gray2 {-palette 2} rgb3 {-palette 3/3/3}} {
image create photo $img -width 120 -height 120 {*}$opts
for {set x 0} {$x < 120} {incr x} {
$img put [format #%02x%02x00 [expr {$x * 255 / 119}] [expr {$x * 165 / 119}]] \
-to $x 0 [expr {$x + 1}] 120
}
pack [label .$img -image $img] -side left
}
In 8.6 and 9.0 the second and third images are dithered with 2 shades of gray and 3 levels per color; in 9.1b1 all three show the same smooth gradient. (The black and white dither of On X11 both options work as expected in 8.6, 9.0 and 9.1. macOS has always ignored them ([de6ef8276c]). | |||
| User Comments: |
chrstphrchvz added on 2026-10-20 03:10:58:
Glad to hear that fix worked. Could it please be backported to 9.0, even though 9.0 does not have the tests added for this ticket? Thanks marc_culler (claiming to be Marc Culler) added on 2026-10-20 01:35:23: That worked for me. I pushed the fix to main and will close this ticket again. chrstphrchvz added on 2026-10-19 04:18:40: Marc, I have reproduced that test failure, and for me it is fixed by the following change:
I think your explanation is mostly correct that the cause is unwanted interpolation. However, Tk is currently only requesting no interpolation for the CGBitmapContext being created in marc_culler (claiming to be Marc Culler) added on 2026-10-19 03:11:32: The checkerboard pattern is visible with "Digital Color Meter".app. See the image attachment. marc_culler added on 2026-10-19 02:57:40: I am reopening the ticket because I am seeing a test failure when running
the new imgPhInstance tests on macOS with a Retina display:
==== imgPhInstance-7.2 -palette is applied FAILED
==== Contents of test case:
.c create image 10 10 -anchor nw -image photo.palette
update
set colors {}
for {set y 14} {$y < 18} {incr y} {
for {set x 14} {$x < 18} {incr x} {
lappend colors [testpixel .c $x $y]
}
}
join [lsort -unique $colors]
---- Result was:
#383838 #c7c7c7
---- Result should have been (exact matching):
#000000 #ffffff
==== imgPhInstance-7.2 FAILED
Here is my explanation. The palette consists of black and white only.
The test draws a square containing #808080. Tk dithers that square,
producing a square where the pixels alternate between black and white
in a checkerboard pattern. When that image gets drawn on a Retina display,
it must be resampled at twice the size. We are only allowed to provide
hints about how to interpolate when resampling - Apple makes the final
decision. The Tk code says it prefers no interpolation. But that hint
is rejected by Apple, and they decide to do bilinear interpolation.
Bilinear interpolation when resampling that checkerboard produces
an image where the 2x2 Retina logical pixels contain 4 display pixels
with colors #383838 and #c7c7c7 in a checkerboard pattern. So when
the test samples the pixels on the screen it sees only those two colors
and does not see any black or white pixels.
The test passes on a non-retina screen.
chrstphrchvz added on 2026-10-17 10:14:11: Also, for similar reasons as this ticket, -gamma and -palette are now ignored in some cases on X11: see [ff3965a5]. chrstphrchvz added on 2026-10-14 02:33:04: It is not true that -gamma and -palette have always been ignored on macOS. In [de6ef8276c], both the reporter's description and my comments indicate that -gamma (and also -palette, it turns out) used to work before 8.6.9. oehhar added on 2026-09-29 19:32:13: Thanks ! Fix is effective. Merged to main by [05a0704a]. Mason, could you comment on this fix? Bug closed. Thanks for all, Harald serhiy.storchaka added on 2026-09-24 19:20:11:
Correction: this can be tested. serhiy.storchaka added on 2026-09-24 13:55:27:
Fixed in branch win-photo-gamma-palette ([c892f77266]). When the instance has a non-default Images with partially transparent pixels are still drawn from the model's RGBA data, so these options still have no effect on them, as on macOS. There is no automatic test: Tk cannot read pixels back from the screen, so the examples above have to be checked visually. | |||
Attachments:
- DigitalColorMeter.png [download] added by marc_culler on 2026-10-19 03:10:26. [details]
