Tk Source Code

Check-in [18d8a385]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Fix [3464070fff]: when a menu entry could not be created, MenuNewEntry() freed it but left it in the entries array, and on Windows no error message was set. The slot is now removed again, and on Windows running out of menu command IDs gives "No more menu entries can be allocated." with error code TK MENU SYSTEM_RESOURCES. GetNewID() also tries the last allocated ID before giving up. New test winMenu-36.1.
Downloads: See separate download page
Timelines: family | ancestors | descendants | both | menu-new-entry-error
Files: files | file ages | folders
SHA3-256: 18d8a385e1a55e703213e17326cc03b62849febf91eaa4d6bcf33e3b5d8b659b
User & Date: serhiy.storchaka 2026-10-25 07:57:30.277
References
2026-10-25
07:57 • Ticket [3464070f] MenuNewEntry() return NULL -> no error msg status still Open with 4 other changes artifact: 01401f9c user: serhiy.storchaka
Context
2026-10-26
21:19
Fix [346407]: Missing error-handling when MenuNewEntry() returns NULL check-in: 7fef988d user: jan.nijtmans tags: core-9-0-branch
21:10
Fix [346407]: Missing error-handling when MenuNewEntry() returns NULL check-in: 1512c574 user: jan.nijtmans tags: trunk, main
2026-10-25
07:57
Fix [3464070fff]: when a menu entry could not be created, MenuNewEntry() freed it but left it in the entries array, and on Windows no error message was set. The slot is now removed again, and on Windows running out of menu command IDs gives "No more menu entries can be allocated." with error code TK MENU SYSTEM_RESOURCES. GetNewID() also tries the last allocated ID before giving up. New test winMenu-36.1. closed check-in: 18d8a385 user: serhiy.storchaka tags: menu-new-entry-error
2026-10-24
17:10
Fix for [562c3a3da5]: transient windows don't appear on Windows check-in: b56b1a05 user: csaba tags: trunk, main
Changes
Unified Diff Side-by-Side Diff Patch
Changes to generic/tkMenu.c.
Changes to tests/winMenu.test.
Changes to win/tkWinMenu.c.