Tk Source Code

Check-in [1512c574]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Fix [346407]: Missing error-handling when MenuNewEntry() returns NULL
Downloads: See separate download page
Timelines: family | ancestors | descendants | both | trunk | main
Files: files | file ages | folders
SHA3-256: 1512c57456ffece713904ddd844649fa284f20426f507f4b74e9672d2552a221
User & Date: jan.nijtmans 2026-10-26 21:10:56.638
References
2026-10-30
13:39 • Ticket [3464070f] MenuNewEntry() return NULL -> no error msg status still Closed with 7 other changes artifact: 46054ef3 user: nemethi
13:36 • Closed ticket [3464070f]. artifact: d52d7802 user: jan.nijtmans
Context
2026-10-27
15:37
Fix d80f8cf33b: tcl/macosx Makefile has fragile `make distclean` check-in: a9969dab user: jan.nijtmans tags: trunk, main
14:28
Merge trunk check-in: 55158b77 user: kevin_walzer tags: wayland
2026-10-26
21:10
Fix [346407]: Missing error-handling when MenuNewEntry() returns NULL check-in: 1512c574 user: jan.nijtmans tags: trunk, main
17:41
Fix spacing issue in mixed emoji text check-in: bacdb2d6 user: kevin_walzer tags: trunk, main
2026-10-25
07:57
Fix [3464070fff]: when a menu entry could not be created, MenuNewEntry() freed it but left it in the entries array, and on Windows no error message was set. The slot is now removed again, and on Windows running out of menu command IDs gives "No more menu entries can be allocated." with error code TK MENU SYSTEM_RESOURCES. GetNewID() also tries the last allocated ID before giving up. New test winMenu-36.1. closed check-in: 18d8a385 user: serhiy.storchaka tags: menu-new-entry-error
Changes
Unified Diff Side-by-Side Diff Patch
Changes to changes.md.
Changes to generic/tkMenu.c.
Changes to generic/tkTest.c.
Changes to macosx/tkMacOSXAccessibility.c.
Changes to macosx/tkMacOSXColor.c.
Changes to macosx/tkMacOSXDialog.c.
Changes to macosx/tkMacOSXDraw.c.
Changes to macosx/tkMacOSXImage.c.
Changes to macosx/tkMacOSXInit.c.
Changes to macosx/tkMacOSXInt.h.
Changes to macosx/tkMacOSXKeyEvent.c.
Changes to macosx/tkMacOSXKeyboard.c.
Changes to macosx/tkMacOSXMenu.c.
Changes to macosx/tkMacOSXMenus.c.
Changes to macosx/tkMacOSXMouseEvent.c.
Changes to macosx/tkMacOSXNotify.c.
Changes to macosx/tkMacOSXPrivate.h.
Changes to macosx/tkMacOSXScrlbr.c.
Changes to macosx/tkMacOSXSubwindows.c.
Changes to macosx/tkMacOSXSysTray.c.
Changes to macosx/tkMacOSXTest.c.
Changes to macosx/tkMacOSXWindowEvent.c.
Changes to macosx/tkMacOSXWm.c.
Changes to macosx/ttkMacOSXTheme.c.
Changes to tests/winMenu.test.
Changes to win/tkWinMenu.c.