Tk Source Code

Check-in [057fd0ff]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Release too stringent constraint on numObjects that triggered a failed assertion (numObjects > 0) when running test treeview-368fa4561e. The previous implementation of tkBind.c did not have such a constraint, and the new implementation does not either. We musn't change the interface of Tk_BindEvent() - the man page does not say that numObjects must not be zero therefore we must support this case.
Downloads: Tarball | ZIP archive
Timelines: family | ancestors | descendants | both | bug6e8afe516d | tip-532
Files: files | file ages | folders
SHA3-256: 057fd0ff5f6cd9518e0d2b15c0a037395fa7c46b7999c3e52e2055cbb126533d
User & Date: fvogel 2019-06-08 22:28:17.560
Context
2019-06-16
14:57
merge 8.6 main branch check-in: 1736f843 user: dkf tags: bug6e8afe516d, tip-532
2019-06-08
22:28
Release too stringent constraint on numObjects that triggered a failed assertion (numObjects > 0) when running test treeview-368fa4561e. The previous implementation of tkBind.c did not have such a constraint, and the new implementation does not either. We musn't change the interface of Tk_BindEvent() - the man page does not say that numObjects must not be zero therefore we must support this case. check-in: 057fd0ff user: fvogel tags: bug6e8afe516d, tip-532
22:27
Release too stringent constraint on numObjects that triggered a failed assertion (numObjects > 0) when running test treeview-368fa4561e. The previous implementation of tkBind.c did not have such a constraint, and the new implementation does not either. We musn't change the interface of Tk_BindEvent() - the man page does not say that numObjects must not be zero therefore we must support this case. check-in: 8a3bf226 user: fvogel tags: bug6e8afe516d-87, tip-532
22:06
merge core-8-6-branch check-in: 5738094c user: fvogel tags: bug6e8afe516d, tip-532
Changes
Unified Diff Ignore Whitespace Patch
Changes to generic/tkBind.c.
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
    unsigned arraySize;
    unsigned newArraySize;
    unsigned i, k;

    assert(bindPtr);
    assert(eventPtr);
    assert(tkwin);
    assert(numObjects > 0);

    /*
     * Ignore events on windows that don't have names: these are windows like
     * wrapper windows that shouldn't be visible to the application.
     */

    if (!winPtr->pathName) {







|







2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
    unsigned arraySize;
    unsigned newArraySize;
    unsigned i, k;

    assert(bindPtr);
    assert(eventPtr);
    assert(tkwin);
    assert(numObjects >= 0);

    /*
     * Ignore events on windows that don't have names: these are windows like
     * wrapper windows that shouldn't be visible to the application.
     */

    if (!winPtr->pathName) {