D 2025-07-26T16:36:09.545
J icomment I\sam\sbeginning\sto\sget\san\sinkling\sof\swhat\sthis\sticket\sis\sabout.\r\n\r\nFirst,\sthere\sare\stwo\scalls\sto\sXCopyArea\sin\stkImgPhInstance.c,\sone\sof\swhich\r\nnever\sarises\sfor\smacOS.\s\sThe\sother\scall\sis\sin\sTkImgPhotoInstanceSetSize.\s\sIt\r\nis\scalled\sto\scopy\sthe\spart\sof\sthe\sold\simage\swhich\sis\salso\sinside\sof\sthe\r\nnew\sresized\simage.\s\sSo\sXCopyArea\sis\sbeing\sused\sto\scopy\sfrom\sa\spixmap\sto\sa\r\npixmap.\r\n\r\nThat\scase\sof\sXCopyArea\swas\snot\sreally\sever\simplemented\sin\s8.0,\sas\sevidenced\r\nby\sthe\scryptic\scomment:\r\n//\sXXXX\sNeed\sto\sdeal\swith\spixmaps!\r\n\r\nThe\s9.0\sXCopyArea\sdoes\sdo\ssomething\sin\sthat\scase,\sbut\sit\sis\svery\sroundabout.\r\n(I\sbelieve\sit\shardly\sever\smatters\sbecause\sin\s99%\sof\sthe\sapplications\sthe\r\nsize\schange\sis\s1x1\s->\swidthxheight\sand\sonly\shappens\sthe\sfirst\stime\sthe\r\nimage\sis\sdrawn.)\r\n\r\nI\shave\sanother\stheory,\swhich\syou\ssort\sof\shinted\sat.\s\sThat\stheory\sis\sthat\r\nyou\sare\swriting\syour\sown\simage\stype\sand\syou\sare\sbasing\syour\scode\son\r\ntkPhImgPhInstance.c.\s\sSo\syou\scopied\sthe\sResize\sfunction,\swhich\scontains\r\nthe\scall\sto\sXCopyArea,\sand\syou\sare\smeasuring\sthe\stime\sfor\sthat\scall\r\nin\syour\sown\simage\simplementation.\r\n\r\nI\salso\ssuspect\sthat\syour\scode\sis\sonly\scalling\sXCopyArea\sin\sthe\scase\swhere\r\nthe\simage\sis\sbeing\sresized\sfrom\s1x1\sto\swxh,\sso\sthe\scall\sto\sXCopyArea\sis\r\nonly\schanging\s1\spixel,\sand\seven\sif\sit\sis\snot\sactually\sdoing\sanything\sat\sall\r\nin\s8.6\sit\sstill\swould\snot\scause\sany\strouble\sfor\syour\scode.\r\n\r\nHere\sis\smy\splan.\s\sI\sam\sgoing\sto\sfix\sXCopyArea\sso\sit\shandles\sthe\spixmap\sto\r\npixmap\scase\sefficiently,\sand\snot\sworry\sabout\sthe\spixmap\sto\swindow\sand\swindow\r\nto\spixmap\scases\sfor\snow.\s\sAfter\sI\sdo\sthat,\sI\spredict\sthat\syour\stiming\sissues\r\nwill\sbe\sgone.\s\sThen\sI\scan\sworry\sabout\sthe\sother\stwo\scases,\s(or\sleave\sthem\r\nin\stheir\scurrent\sinefficiant\sstate\suntil\ssomeone\sactually\suses\sthem.\s:^}\s)
J login marc_culler
J mimetype text/plain
J username Marc\sCuller
K 4af5ca1921122de63f37a99beefb2f5dbef72518
U marc_culler
Z 4f4da36dae353b1d0535c7605e29fcc3
