Overview
| Artifact ID: | 47ac8f1513c7dcf38e380a31a8f1a3e0fa769a88ac7087f517968b9ba3f3745f |
|---|---|
| Ticket: | fee1ffa1b6037cb15b592ad550d21760e1548eda
Error in mode checking in latest checkin 1505883e4a from 2024-07-01 |
| User & Date: | anonymous on 2024-10-04 07:23:36 |
Changes
- foundin changed to: "1505883e4a from 2024-07-01"
- icomment:
Compiling tls.c on macoS (17.0/arm) yields the following warnings which I assume are errors: ``` /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:1769:18: warning: variable 'abort' set but not used [-Wunused-but-set-variable] 1769 | int off = 0, abort = 0; | ^ /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2222:11: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand] 2222 | if (mode && SSL_VERIFY_FAIL_IF_NO_PEER_CERT) { | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2222:11: note: use '&' for a bitwise operation 2222 | if (mode && SSL_VERIFY_FAIL_IF_NO_PEER_CERT) { | ^~ | & /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2222:11: note: remove constant to silence this warning 2222 | if (mode && SSL_VERIFY_FAIL_IF_NO_PEER_CERT) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2225:11: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand] 2225 | if (mode && SSL_VERIFY_CLIENT_ONCE) { | ^ ~~~~~~~~~~~~~~~~~~~~~~ /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2225:11: note: use '&' for a bitwise operation 2225 | if (mode && SSL_VERIFY_CLIENT_ONCE) { | ^~ | & /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2225:11: note: remove constant to silence this warning 2225 | if (mode && SSL_VERIFY_CLIENT_ONCE) { | ^~~~~~~~~~~~~~~~~~~~~~~~~ /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2228:11: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand] 2228 | if (mode && SSL_VERIFY_POST_HANDSHAKE) { | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2228:11: note: use '&' for a bitwise operation 2228 | if (mode && SSL_VERIFY_POST_HANDSHAKE) { | ^~ | & /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2228:11: note: remove constant to silence this warning 2228 | if (mode && SSL_VERIFY_POST_HANDSHAKE) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ 4 warnings generated. ``` Fix: Change the '&&' into '&' since the openssl function returns an int containing a bitmask. I am not converned about the unused variable `abort`. I applied this modificationlocally and everything seems to work correctly. - login: "anonymous"
- mimetype: "text/x-markdown"
- private_contact changed to: "720cbbf8ba21fd6982dfd8639b4ecf45d5cf11a3"
- severity changed to: "Severe"
- status changed to: "Open"
- title changed to:
Error in mode checking in latest chckin 1505883e4a from 2024-07-01
- type changed to: "Code Defect"