Artifacts Associated With Ticket fee1ffa1b6037cb15b592ad550d21760e1548eda

1. Ticket change [47ac8f1513] (rid 3719) by anonymous on 2024-10-04 07:23:36:

   1. foundin initialized to: "1505883e4a from 2024-07-01"
   2. icomment:

      Compiling tls.c on macoS (17.0/arm) yields the following warnings which I assume are errors:
      ```
      /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:1769:18: warning: variable 'abort' set but not used [-Wunused-but-set-variable]
       1769 |     int off = 0, abort = 0;
            |                  ^
      /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2222:11: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
       2222 |         if (mode && SSL_VERIFY_FAIL_IF_NO_PEER_CERT) {
            |                  ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2222:11: note: use '&' for a bitwise operation
       2222 |         if (mode && SSL_VERIFY_FAIL_IF_NO_PEER_CERT) {
            |                  ^~
            |                  &
      /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2222:11: note: remove constant to silence this warning
       2222 |         if (mode && SSL_VERIFY_FAIL_IF_NO_PEER_CERT) {
            |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2225:11: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
       2225 |         if (mode && SSL_VERIFY_CLIENT_ONCE) {
            |                  ^  ~~~~~~~~~~~~~~~~~~~~~~
      /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2225:11: note: use '&' for a bitwise operation
       2225 |         if (mode && SSL_VERIFY_CLIENT_ONCE) {
            |                  ^~
            |                  &
      /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2225:11: note: remove constant to silence this warning
       2225 |         if (mode && SSL_VERIFY_CLIENT_ONCE) {
            |                  ^~~~~~~~~~~~~~~~~~~~~~~~~
      /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2228:11: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
       2228 |         if (mode && SSL_VERIFY_POST_HANDSHAKE) {
            |                  ^  ~~~~~~~~~~~~~~~~~~~~~~~~~
      /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2228:11: note: use '&' for a bitwise operation
       2228 |         if (mode && SSL_VERIFY_POST_HANDSHAKE) {
            |                  ^~
            |                  &
      /opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2228:11: note: remove constant to silence this warning
       2228 |         if (mode && SSL_VERIFY_POST_HANDSHAKE) {
            |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      4 warnings generated.
      ```
      Fix:
      Change the '&&' into '&' since the openssl function returns an int containing a bitmask. I am not converned about the unused variable `abort`. I applied this modificationlocally and everything seems to work correctly.
      

   3. login: "anonymous"
   4. mimetype: "text/x-markdown"
   5. private_contact initialized to: "720cbbf8ba21fd6982dfd8639b4ecf45d5cf11a3"
   6. severity initialized to: "Severe"
   7. status initialized to: "Open"
   8. title initialized to:

      Error in mode checking in latest chckin 1505883e4a from 2024-07-01
      

   9. type initialized to: "Code Defect"

2. Ticket change [73f193cb73] (rid 3720) by anonymous on 2024-10-04 09:42:07:

   1. icomment: "Corrected typo in description."
   2. login: "anonymous"
   3. mimetype: "text/x-markdown"
   4. priority changed to: "Immediate"
   5. resolution changed to: "Open"
   6. title changed to:

      Error in mode checking in latest checkin 1505883e4a from 2024-07-01
      

3. Ticket change [04f7923dd1] (rid 3801) by bohagan on 2024-10-28 03:04:17:

   1. icomment:

      This should be corrected in [c747afd2002a4cbf]. Let me know if you agree.
      

   2. login: "bohagan"
   3. mimetype: "text/x-fossil-plain"
   4. status changed to: "Fixed"

4. Ticket change [d7b9f76ceb] (rid 3819) by bohagan on 2024-11-04 02:46:49:

   1. login: "bohagan"
   2. mimetype: "text/x-markdown"
   3. resolution changed to: "Fixed"
   4. status changed to: "Closed"