Tcl Library Source Code

View Ticket
Login
Ticket UUID: da4520f0bc2a19b4855420ffda5a52ffe52884fb
Title: Review branch pt/avoid-old-ssl
Type: Patch Version: 1.5.3
Submitter: patthoyts Created on: 2017-10-28 13:40:23
Subsystem: http :: autoproxy Assigned To: aku
Priority: 7 High Severity: Minor
Status: Closed Last Modified: 2017-10-31 03:42:53
Resolution: Accepted Closed By: aku
    Closed on: 2017-10-31 03:42:53
Description:
Pull request for fixes to tests that try and use ssl2/ssl3 which is not supported in recent openssl. Switch to tls1.
Also fixed issues in autoproxy and crc16 in other commits on this branch.
User Comments: aku added on 2017-10-31 03:42:53:

Confirmed with testing on trunk that all the failures are on trunk, and caused by the changes.

Merged. Fixed doc issues, and regenerated docs. Fixed a split in the trunk due the merge.

Commit [ca0b7e688f is final merge result.


aku added on 2017-10-30 23:24:45:
Various failures in the full test which have nothing to do with the change, it looks like.

Will merge.

aku added on 2017-10-30 21:55:51:
Version bump committed.
Final test run in progress (all packages).

aku added on 2017-10-30 21:48:00:
Testing ok ...

hephaistos:(621) ~/Play/Tcllib/dev.tcllib-pat > ./sak.tcl test run -l X crc http comm pop3
[    ]  Starting ...                                                   
[    ]  [8.4.20] crc  ~~       T   135 P   135 S     0 F     0
[    ]  [8.4.20] http ~~       T    16 P    16 S     0 F     0
[    ]  [8.4.20] comm ~~       T    22 P    21 S     1 F     0
[    ]  [8.4.20] pop3 ~~       T    45 P    44 S     1 F     0
[    ]  [8.5.18] crc  ~~       T   135 P   135 S     0 F     0
[    ]  [8.5.18] http ~~       T    16 P    16 S     0 F     0
[    ]  [8.5.18] comm ~~       T    22 P    21 S     1 F     0
[    ]  [8.5.18] pop3 ~~       T    45 P    44 S     1 F     0
[    ]  [8.6.4]  crc  ~~       T   135 P   135 S     0 F     0
[    ]  [8.6.4]  http ~~       T    16 P    16 S     0 F     0
[    ]  [8.6.4]  comm ~~       T    22 P    21 S     1 F     0
[    ]  [8.6.4]  pop3 ~~       T    45 P    44 S     1 F     0

hephaistos:(622) ~/Play/Tcllib/dev.tcllib-pat > ./sak.tcl test run -l X -s /home/aku/opt/ActiveTcl/bin/tclsh crc http comm pop3
[    ]  Starting ...                        
[    ]  [8.5.14] crc  ~~       T   210 P   210 S     0 F     0
[    ]  [8.5.14] http ~~       T    16 P    16 S     0 F     0
[    ]  [8.5.14] comm ~~       T    22 P    22 S     0 F     0
[    ]  [8.5.14] pop3 ~~       T    45 P    45 S     0 F     0

The second run is with a tclsh having tls. The others are without tls.

aku added on 2017-10-30 21:34:53:
Notes:
- Bump version of crc16 -- Bugfix - Patchlevel
- Bump version of autoproxy - While done new (backward compatible) functionality prompts a change of the minor version, not patchlevel.

aku added on 2017-10-30 21:27:39:
Review started.
Don't seem to have a Test tclsh with TclTLS installed.
May have to run against the user tclsh (an AT) for this.