Tcl Library Source Code

View Ticket
Login
Ticket UUID: c91ffaae34ae4874b4457ea190e8f4a3deb142b
Title: Improved and debug-ready NX PARAM engine [9877877dcd]
Type: Bug Version: 1.1.1.0
Submitter: ssoberni Created on: 2018-02-07 17:28:23
Subsystem: pt (parsetools) Assigned To: aku
Priority: 8 Severity: Important
Status: Closed Last Modified: 2018-02-09 05:42:34
Resolution: Accepted Closed By: aku
    Closed on: 2018-02-09 05:42:34
Description:
Hi Andreas!

Pls. consider the improvements on branch pt-fixes2-ssoberni [9877877dcd] for inclusion into the mainline (maybe also the 1.19 rc?).

Background: Working on the FFP patch, I realized that the debug mode was broken for the NX engine, because of the subtle differences between TclOO and NX when it comes to namespace contexts. I fixed this, one can now "debug on pt/rdengine" and "debug off pt/rdengine" as available for the other backends. Along the way, I also micro-improved the generated NX code so that the typical instruction methods (in non-debug mode) run ~25% faster on standard parsing loads (by managing variable imports à la TclOO in NX more selectively). 

The pt test suite runs just fine. There are no API changes or backward compat issues, so a bump of version numbers should not be necessary.

Thank you for your help.
User Comments: aku added on 2018-02-09 05:42:34:

Merged to release, commit [720355a2d8]

Merged to trunk, commit [3a942ffbf3]


aku added on 2018-02-09 04:07:37:
Looks ok. Currently running tests.

ssoberni added on 2018-02-08 22:58:58:
Agreed. I bumped the patch level. I also refactored some [expr] calls in [f94401b3e2], I hope this is fine with you?

aku added on 2018-02-08 05:27:42:
So the commit and it looked easy enough.

The change to the debugging can be seen as bug fix, with patchlevel version increment. You actually describe it as such (... broken ... I fixed ...)