| Ticket UUID: | b9725d990bad71033ec286dc01ac0d110c505fc3 | |||
| Title: | ::zipfile::mkzip::walk fails with directory names preceded with '-' | |||
| Type: | Patch | Version: | 1.19 | |
| Submitter: | hromojaro | Created on: | 2019-03-08 20:03:55 | |
| Subsystem: | zip | Assigned To: | aku | |
| Priority: | 7 High | Severity: | Important | |
| Status: | Closed | Last Modified: | 2019-04-15 23:14:05 | |
| Resolution: | Accepted | Closed By: | aku | |
| Closed on: | 2019-04-15 23:14:05 | |||
| Description: |
::zipfile::mkzip::walk fails with sub-directories which names start with '-', due to missing '--' in glob expressions. Can be reproduced like this: $ mkdir -- -1 $ ls -1/ $ tclsh % package require Tcl 8.6 8.6.7 % package require zipfile::mkzip 1.2 % ::zipfile::mkzip::mkzip my.zip -directory . bad option "-1/*": must be -directory, -join, -nocomplain, -path, -tails, -types, or --Please consider applying the attached patch with a fix.
Regards, | |||
| User Comments: |
aku added on 2019-04-15 23:14:05:
Fixed with commit [5f3611f96a]. Patch accepted as is for the fix. Added a testsuite for mkzip. Well, the seed of one. Currently covers only the basic wrong#args and this issue. | |||
Attachments:
- mkzip.tcl.patch [download] added by hromojaro on 2019-03-08 20:04:17. [details]