| Ticket UUID: | a753cade839f466391b1af0c1b334f5a601ddbc | |||
| Title: | New improved huddle version | |||
| Type: | Bug | Version: | ||
| Submitter: | anonymous | Created on: | 2015-04-23 15:15:59 | |
| Subsystem: | huddle | Assigned To: | aku | |
| Priority: | 7 High | Severity: | Minor | |
| Status: | Open | Last Modified: | 2015-04-23 19:15:34 | |
| Resolution: | None | Closed By: | nobody | |
| Closed on: | ||||
| Description: |
I have a new improved version of huddle. It's more readable and it pass all the tests. I attach to this file. I want to continue doing improvements. | |||
| User Comments: |
aku added on 2015-04-23 19:15:34:
I have put the new code with some basic integration work into branch "huddle-a753cade83". The current revision is [4c78dcbc6f].
This looks to be incomplete.
When running the testsuite I see the huddle tests passing, and then failures for yaml and rb tests. These are:
Aborting the tests found in "yaml.test"
Error in yaml.tcl: too many nested evaluations (infinite loop?)
When I looked a bit deeper, using the full stacktrace I saw that yaml contains code like
proc $procname {command args} [string map "@TYPE@ $type @TAG@ $tag" {
switch -- $command {
setting { ; # type definition
return {
type @TYPE@
method {}
tag {@TAG@ child}
constructor ""
str @TAG@
}
}
default {
return [huddle call s $command $args]
}
}
Now, as you changed this in huddle from "setting" to "settings" (added a trailing "s") the unchanged yaml I have goes into the 'default' case of the switch, which in turn goes through the callback to re-invoke this same procedure, ad infinitum.
When I fixed that I got the next error as
can't read "isContainer": no such variable
while executing
"set types(isContainer:$tag) $isContainer"
(body of "dict with")
invoked from within
which seems to indicate more changes are needed in the yaml package to match it to the changed huddle.
Can you please check in your environment if you have such changes, and if yes, provide them here ?
aku added on 2015-04-23 17:21:28: Thank you for the submission. I welcome future submissions as well. Assigned to self for review and integration. Bumped priority. | |||
Attachments:
- huddle.tcl [download] added by anonymous on 2015-04-23 16:58:52. [details]
