Tcl Library Source Code

View Ticket
Login
Ticket UUID: 1566389
Title: tests fail in fileutil 1.9
Type: Bug Version: None
Submitter: dgp Created on: 2006-09-27 14:52:34
Subsystem: fileutil Assigned To: andreas_kupries
Priority: 5 Medium Severity:
Status: Open Last Modified: 2007-08-09 02:51:08
Resolution: None Closed By:
    Closed on:
Description:
@@ Tcl 8.4.14
@@ MatchTests *
@@ SkipFiles l.*.test
@@ MatchFiles *.test
@@ Start 1159368646
@@ Module fileutil
@@ Testsuite modules/fileutil/fileutil.test
- tcllib::testutils 1.1
- cmdline 1.2.5
* fileutil 1.9]

...

==== install-2.1 install a directory FAILED
==== Contents of test case:

    list [catch {
        fileutil::install [file join installSrc subdir]
installDst
        set result [lsort [glob -tails -directory [file
join installDst subdir] [file join . / *]]]
        file delete -force installDst
        set result
    } err] $err

---- Result was:
0 {/subfile1 /subfile2 /subfile3}
---- Result should have been (exact matching):
0 {subfile1 subfile2 subfile3}
==== install-2.1 FAILED

---- install-2.2 start

==== install-2.2 install a directory FAILED
==== Contents of test case:

    list [catch {
        fileutil::install [file join installSrc subdir]
installDst
        set result [lsort [glob -directory [file join
installDst subdir] [file join . / *]]]
        file delete -force installDst
        set result
    } err] $err

---- Result was:
0 {installDst/subdir//subfile1
installDst/subdir//subfile2 installDst/subdir//subfile3}
---- Result should have been (exact matching):
0 {installDst/subdir/subfile1
installDst/subdir/subfile2 installDst/subdir/subfile3}
==== install-2.2 FAILED
User Comments: andreas_kupries added on 2007-08-09 02:51:08:
Logged In: YES 
user_id=75003
Originator: NO

Heh. I just ran into these test failures again, I think. Ok on Linux, failed on Windows.
Will try to understand what is done and wanted.

dgp added on 2006-10-02 11:09:33:
Logged In: YES 
user_id=80530

see 1569042

dgp added on 2006-09-28 22:47:18:
Logged In: YES 
user_id=80530


ok, at least one relevant issue
is a [glob] bug fix apparently
not backported to 8.4.

% info patch
8.5a5
% glob *
foo
% glob -dir . /foo
./foo

andreas_kupries added on 2006-09-28 22:40:47:
Logged In: YES 
user_id=75003

The glob outout (.//foo) certainly looks broken. If this is
the expected output and the intentation of thests. I don't
know. They test the 'fileutil::install' command ... Written
by David Welton in 2003. So he should be able to get us
better answers. He is 'davidw' here, we could reassign this
to him.

dgp added on 2006-09-28 22:30:00:
Logged In: YES 
user_id=80530


The use of [file join . / *]
in these tests is suspect.
Perhaps it's combining with
[glob] and [file] bugs here?

What's intended by these tests?

dgp added on 2006-09-28 22:27:35:
Logged In: YES 
user_id=80530

dgp% glob *
foo
% glob -dir . /foo
.//foo
[11:26]dgpIs that broken?

andreas_kupries added on 2006-09-28 06:47:59:
Logged In: YES 
user_id=75003

Hm. I am on a solaris 2.6 box, and cannot repro these
failures. The testsuite runs fine.

andreas_kupries added on 2006-09-27 22:37:46:
Logged In: YES 
user_id=75003

Ok, while I have no access to a Linux/Alpha box a Solaris
box is at hand.

dgp added on 2006-09-27 22:32:08:
Logged In: YES 
user_id=80530


Linux/Alpha and Solaris

andreas_kupries added on 2006-09-27 22:23:19:
Logged In: YES 
user_id=75003

Platform ?