Tcl Library Source Code

View Ticket
Login
2018-01-24
20:02 • Closed ticket [b9a39c02c7]: ldap::search broken -- needs blocking socket plus 6 other changes artifact: b79daf13e6 user: aku
20:02 • Closed ticket [5f4f30667b]: Error from LDAP package when requesting a larger base64 encoded JPEG image plus 6 other changes artifact: 129fbb2958 user: aku
19:16 • Closed ticket [c247ed5db4]: LDAP protocol error plus 6 other changes artifact: 974728a28b user: aku
19:12
Tkt [c247ed5db4] ldap/ldap <B,D>. Merge of fix for protocol error, into release prep. check-in: 2f3369f04b user: aku tags: tcllib-1-19-rc
19:11
Tkt [c247ed5db4] ldap/ldap <B,D>. Merge of fix for protocol error. check-in: 0826350f8d user: aku tags: trunk
2017-11-01
22:53 • Ticket [b9a39c02c7] ldap::search broken -- needs blocking socket status still Open with 5 other changes artifact: d1dc310c90 user: aku
22:50 • Ticket [c247ed5db4] LDAP protocol error status still Open with 3 other changes artifact: 26ce48683e user: aku
22:48
Ticket [c247ed5db4]. Fixed handling of partial reception. Thanks to [email protected] for report and patch. Bumped version to 1.9.2. Note, this may fix tickets [b9a39c02c7] and [5f4f30667b] as well. Ping their reporters. closed check-in: 8b8f10e2bb user: aku tags: fix-ldap-partial
22:38 • Ticket [c247ed5db4] LDAP protocol error status still Open with 3 other changes artifact: cff60ca328 user: aku
22:32 • Ticket [c247ed5db4]: 4 changes artifact: 5539e75fb8 user: aku
2017-05-26
17:42 • Ticket [c247ed5db4]: 3 changes artifact: 366d2d5399 user: aku
2017-03-21
12:10 • Ticket [c247ed5db4]: 3 changes artifact: 93948a7f18 user: pda
10:41 • Add attachment ldap.tcl.patch to ticket [c247ed5db4] artifact: f3e295181c user: pda
10:25 • Ticket [c247ed5db4] LDAP protocol error status still Open with 4 other changes artifact: 69a6e7423c user: pda
10:22 • New ticket [c247ed5db4]. artifact: 52fa086635 user: pda

Ticket UUID: c247ed5db42e373470bf8a6302717e76eb3c6106
Title: LDAP protocol error
Type: Bug Version: 1.18
Submitter: pda Created on: 2017-03-21 10:22:56
Subsystem: ldap Assigned To: aku
Priority: 8 Severity: Critical
Status: Closed Last Modified: 2018-01-24 19:16:45
Resolution: Accepted Closed By: aku
    Closed on: 2018-01-24 19:16:45
Description:
Under some circumstances (large LDAP entries, e.g. with a large jpegPhoto), the LDAP module returns the following error:

Protocol error: Error reading SEQUENCE response for handle ::ldap::ldapsock15a3700

The ReceiveBytes proc seems to return 0 bytes (partial read) instead of the SEQUENCE byte. The partial read is treated as an error in MessageReceiver.
User Comments: aku added on 2018-01-24 19:16:45:

Ok. I Have not heard back from the submitters of the other tickets, for about 2.5 months. No need to hold back anymore.

This fix is now merged into both `trunk` and `tcllib-1-19-rc` (Latter is where the 1.19 release is currently getting prepared). The relevant merge commits are

  • [0826350f8d] = `trunk`
  • [2f3369f04b] = `tcllib-1-19-rc`


aku added on 2017-11-01 22:50:56:
Your fix is now applied in commit [8b8f10e2bb],
on branch [fix-ldap-partial].

It is not merged to trunk yet, as I would like to ping the reporters of the two tickets you referenced to see if their issues are solved by this too.

aku added on 2017-11-01 22:38:31:

Make refs actual links.

* [b9a39c02c7855865fb48c32d1d4dcbf8ee22750b]

* [5f4f30667b4bc066593e0aa37ddf88b62e1830b5]


pda added on 2017-03-21 12:10:23:
The attached patch may fix tickets:
b9a39c02c7855865fb48c32d1d4dcbf8ee22750b
5f4f30667b4bc066593e0aa37ddf88b62e1830b5

pda added on 2017-03-21 10:25:07:
The following patch solves the problem (I did not found the way to attach a patch in the ticket Web interface, sorry):

--- ldap.tcl.bak        2017-03-21 11:01:54.716595089 +0100
+++ ldap.tcl    2017-03-21 11:02:25.956334530 +0100
@@ -738,7 +738,10 @@
                     set conn(pdu,partial) 1
                     append conn(pdu,received) $type
                 }
-                }
+           }
+           partial {
+               return
+           }
             eof {
                 CleanupWaitingMessages $handle
                 set conn(lastError) "Server closed connection"

Attachments: