Tcl Library Source Code

Check-in [3b14767f50]
Login
Bounty program for improvements to Tcl and certain Tcl packages.

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Ticket [f58015fbd0]: ftp - DisplayMsg - Removed bogus use of ::errorInfo. Simplified the code a bit.
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1: 3b14767f50651768d8990c8dbe84af1b2b22fa2c
User & Date: andreask 2014-01-29 19:29:48
References
2014-01-31
06:31
Bumped ftp to 2.4.12, see [3b14767f50]. check-in: 6e03cd1a77 user: aku tags: tcllib-1-16-rc
2014-01-29
19:31 Closed ticket [f58015fbd0]: Incorrect error handling in ftp module plus 7 other changes artifact: 157ed460bc user: aku
Context
2014-01-30
20:05
Solving two tickets regarding the math::geometry package check-in: ffa444f6ab user: markus tags: trunk
2014-01-29
21:12
Merge RC with latest fixes check-in: 59ef0e2775 user: andreask tags: tcllib-1-16-rc
21:11
Ticket [eb0b15d598] - ftp - Extended debug narrative for the state machine operation to help investigation of the problem check-in: 0adb77c50b user: andreask tags: ftp-bug-eb0b15d598
19:29
Ticket [f58015fbd0]: ftp - DisplayMsg - Removed bogus use of ::errorInfo. Simplified the code a bit. check-in: 3b14767f50 user: andreask tags: trunk
19:23
Tweaked the last change a bit to follow coding guidelines. check-in: 71d074f491 user: andreask tags: trunk
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to modules/ftp/ftp.tcl.

97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
    #              tcllib, which is much easier to customize for the
    #              needs of any application using the ftp module. The
    #              variable VERBOSE is still relevant as it controls
    #              whether this procedure is called or not.

    global errorInfo
    switch -exact -- $state {
        data    {log::log debug "$state | $msg"}
        control {log::log debug "$state | $msg"}
        error   {log::log error "$state | E: $msg:\n$errorInfo"}
        default {log::log debug "$state | $msg"}
    }
    return
}

#############################################################################
#






<
<
|







97
98
99
100
101
102
103


104
105
106
107
108
109
110
111
    #              tcllib, which is much easier to customize for the
    #              needs of any application using the ftp module. The
    #              variable VERBOSE is still relevant as it controls
    #              whether this procedure is called or not.

    global errorInfo
    switch -exact -- $state {


        error   {log::log error "$state | $msg"}
        default {log::log debug "$state | $msg"}
    }
    return
}

#############################################################################
#