| Ticket UUID: | 528434 | |||
| Title: | New sources for calculus module | |||
| Type: | Bug | Version: | None | |
| Submitter: | arjenmarkus | Created on: | 2002-03-11 10:37:08 | |
| Subsystem: | math | Assigned To: | andreas_kupries | |
| Priority: | 5 Medium | Severity: | ||
| Status: | Closed | Last Modified: | 2002-03-16 04:43:43 | |
| Resolution: | Fixed | Closed By: | andreas_kupries | |
| Closed on: | 2002-03-15 21:43:43 | |||
| Description: |
See previous "bug report" - something went wrong with the attached file | |||
| User Comments: |
andreas_kupries added on 2002-03-16 04:43:43:
Logged In: YES user_id=75003 Committed after approval by Arjen. andreas_kupries added on 2002-03-15 23:08:35: Logged In: YES user_id=75003 Styleguide: http://tcl.tk/doc/styleGuide.pdf arjenmarkus added on 2002-03-15 14:12:38: Logged In: YES user_id=400048 Yes, I will do that. I will make sure that my own copy is replaced by yours (of course, if I am convinced you did the right thing :-). I was not aware of the styleguide's recommendation concerning exported commands. But I will adhere to it. Where can I find the styleguide? andreas_kupries added on 2002-03-15 03:31:14: File Added - 19367: calculus-ak.tar.gz Logged In: YES user_id=75003 Enclosed the sources for the calculus modules as changed by me to fit them into tcllib. Changes I made: * namespace Calculus => math::calculus * Braced some expressions, prevented frink from complaining for unbraceable expr's * According to docs solveTri... is public, but was not exported. Is now exported. * Styleguide says that exported commands begin with a lowercase letter. Changed all exported commands to follow this. Arjen, please check that my changes are ok with you. If they are I will commit and expect that the committed variant is the master from then on. I say this because I hade to make some changes I did during the first integration again this time and would like to avoid this in the future. andreas_kupries added on 2002-03-15 02:35:54: Logged In: YES user_id=75003 See 528433 for the actual description. Here we have the sources to look at. arjenmarkus added on 2002-03-12 14:08:04: Logged In: YES user_id=400048 Yes, well, still learning the etiquette :-) andreas_kupries added on 2002-03-12 04:12:38: Logged In: YES user_id=75003 Ah. There is no need to generate a new bug report by the way. It is possible to attach files to existing reports, after their creation. arjenmarkus added on 2002-03-11 17:37:08: File Added - 19146: calculus.tar.gz | |||
Home
Blog
Docs
Downloads
Tickets
Timeline
Branches
Tags
Wiki